You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pinot.apache.org by "priyen-stripe (via GitHub)" <gi...@apache.org> on 2025/09/18 22:00:05 UTC

[I] Metrics in PerQueryCPUMemAccountantFactory not working (flatline / 0) because its using a noop ServerMetrics [pinot]

priyen-stripe opened a new issue, #16849:
URL: https://github.com/apache/pinot/issues/16849

   Noticed this while testing query killing:
   Metrics in PerQueryCPUMemAccountantFactory not working (flatline / 0) 
   
   
    Timeline:
     1. Feb 1, 2023 (1d370a8c24): PerQueryCPUMemAccountantFactory added ServerMetrics.get() call in WatcherTask() constructor
     2. May 10, 2023 (3a8c578020): Thread accountant initialization added to BaseServerStarter after ServerInstance creation - No problem yet
     3. July 3, 2025 (d40731f972): Thread accountant initialization moved before ServerInstance creation - Bug introduced!
   
     The commit moved the Tracing.ThreadAccountantOps.initializeThreadAccountant() call from AFTER ServerInstance creation to BEFORE ServerInstance creation, and also modified ServerInstance constructor to take Tracing.getThreadAccountant() as a parameter.
   
     1. createThreadAccountant() - Creates PerQueryCPUMemAccountantFactory → calls ServerMetrics.get() → gets NOOP
     2. new ServerInstance() - Creates and registers real ServerMetrics but PerQueryCPUMemAccountantFactory continues to use the NOOP


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

Re: [I] Metrics in PerQueryCPUMemAccountantFactory not working (flatline / 0) because its using a noop ServerMetrics [pinot]

Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.

Jackie-Jiang closed issue #16849: Metrics in PerQueryCPUMemAccountantFactory not working (flatline / 0) because its using a noop ServerMetrics
URL: https://github.com/apache/pinot/issues/16849


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org