Re: [PR] [improve] Support specifying multiple journalDirs for the bookie server start cmd options [bookkeeper]

["eolivelli (via GitHub)" <gi...@apache.org>]

eolivelli commented on code in PR #4181:
URL: https://github.com/apache/bookkeeper/pull/4181#discussion_r1512257396


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/server/Main.java:
##########
@@ -61,7 +61,9 @@ public class Main {
         BK_OPTS.addOption("m", "zkledgerpath", true, "Zookeeper ledgers root path");
         BK_OPTS.addOption("p", "bookieport", true, "bookie port exported");
         BK_OPTS.addOption("hp", "httpport", true, "bookie http port exported");
-        BK_OPTS.addOption("j", "journal", true, "bookie journal directory");

Review Comment:
   please don't break compatibility



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org