You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/04/09 05:03:52 UTC

[GitHub] [echarts] pissang opened a new pull request #14630: fix(pie): fix pie display NaN labels 

pissang opened a new pull request #14630:
URL: https://github.com/apache/echarts/pull/14630


   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [x] bug fixing
   - [ ] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   This is a bug that happens after this change [ecomfe/zrender#730](https://github.com/ecomfe/zrender/pull/730). Because the sector shape will be set to a valid value from NaN before start the animation, which leads to the label being placed at the start.
   
   Also, this PR adds a test case for the fixing in [ecomfe/zrender#730](https://github.com/ecomfe/zrender/pull/730)
   
   
   ### Fixed issues
   
   <!--
   - #xxxx: ...
   -->
   
   
   ## Details
   
   ### Before: What was the problem?
   
   
   ![image](https://user-images.githubusercontent.com/841551/114130833-fb187d00-9933-11eb-9969-a23f3bf6728c.png)
   
   
   ### After: How is it fixed in this PR?
   
   
   ![image](https://user-images.githubusercontent.com/841551/114130843-0075c780-9934-11eb-9595-08e536578527.png)
   
   
   ## Usage
   
   ### Are there any API changes?
   
   - [ ] The API has been changed.
   
   <!-- LIST THE API CHANGES HERE -->
   
   
   
   ### Related test cases or examples to use the new APIs
   
   NA.
   
   
   
   ## Others
   
   ### Merging options
   
   - [ ] Please squash the commits into a single one when merge.
   
   ### Other information
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] pissang merged pull request #14630: fix(pie): fix pie display NaN labels

Posted by GitBox <gi...@apache.org>.
pissang merged pull request #14630:
URL: https://github.com/apache/echarts/pull/14630


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #14630: fix(pie): fix pie display NaN labels

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #14630:
URL: https://github.com/apache/echarts/pull/14630#issuecomment-816405966


   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
   
   The pull request is marked to be `PR: author is committer` because you are a committer of this project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #14630: fix(pie): fix pie display NaN labels

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #14630:
URL: https://github.com/apache/echarts/pull/14630#issuecomment-816427159


   Congratulations! Your PR has been merged. Thanks for your contribution! 👍


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org