You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2023/01/16 06:56:55 UTC

[GitHub] [iceberg] pvary opened a new pull request, #6602: Flink: Backport: Flink: Refactor sink tests to use HadoopCatalogResource

pvary opened a new pull request, #6602:
URL: https://github.com/apache/iceberg/pull/6602

   Backport of #6583


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] pvary commented on pull request #6602: Flink: Backport: Flink: Refactor sink tests to use HadoopCatalogResource

Posted by GitBox <gi...@apache.org>.
pvary commented on PR #6602:
URL: https://github.com/apache/iceberg/pull/6602#issuecomment-1383844429

   Created #6603 for backporting #4699 to v1.14


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] pvary commented on pull request #6602: Flink: Backport: Flink: Refactor sink tests to use HadoopCatalogResource

Posted by GitBox <gi...@apache.org>.
pvary commented on PR #6602:
URL: https://github.com/apache/iceberg/pull/6602#issuecomment-1383814310

   The root cause of the difference of the backport is that #4699 is missing from the v1.14 code path.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] pvary commented on pull request #6602: Flink: Backport: Flink: Refactor sink tests to use HadoopCatalogResource

Posted by GitBox <gi...@apache.org>.
pvary commented on PR #6602:
URL: https://github.com/apache/iceberg/pull/6602#issuecomment-1384903152

   Merged to master. 
   Thanks for the review @stevenzwu!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] pvary merged pull request #6602: Flink: Backport: Flink: Refactor sink tests to use HadoopCatalogResource

Posted by GitBox <gi...@apache.org>.
pvary merged PR #6602:
URL: https://github.com/apache/iceberg/pull/6602


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] pvary commented on pull request #6602: Flink: Backport: Flink: Refactor sink tests to use HadoopCatalogResource

Posted by GitBox <gi...@apache.org>.
pvary commented on PR #6602:
URL: https://github.com/apache/iceberg/pull/6602#issuecomment-1383593672

   - 1.15 is a clean backport
   - 1.14 the `tablePath` is a class variable, so it is not clean, but easy to follow the changes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org