You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kylin.apache.org by "Shaofeng SHI (JIRA)" <ji...@apache.org> on 2015/04/14 08:16:12 UTC
[jira] [Commented] (KYLIN-684) Remove holistic distinct count and
multiple column distinct count from sample cube
[ https://issues.apache.org/jira/browse/KYLIN-684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14493647#comment-14493647 ]
Shaofeng SHI commented on KYLIN-684:
------------------------------------
Code change submitted to staging branch; And I run the sample cube once, it can be successfully built. The change will be roll out in next binary package update;
> Remove holistic distinct count and multiple column distinct count from sample cube
> ----------------------------------------------------------------------------------
>
> Key: KYLIN-684
> URL: https://issues.apache.org/jira/browse/KYLIN-684
> Project: Kylin
> Issue Type: Bug
> Components: General
> Affects Versions: v0.7.1
> Reporter: Shaofeng SHI
> Assignee: Shaofeng SHI
>
> In the sample cube "kylin_sales_cube_desc", there are two advanced measures which are not formally supported yet. This makes user confusing. So drop them should be better than keep them there.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: [jira] [Commented] (KYLIN-684) Remove holistic distinct count
and multiple column distinct count from sample cube
Posted by "Shi, Shaofeng" <sh...@ebay.com>.
Hongbin, yes, they were just removed from the sample cube; The test case
cubes still keep these functions.
On 4/14/15, 2:24 PM, "hongbin ma" <ma...@apache.org> wrote:
>Is it possible that you remove them in sample cubes but keep them in test
>cases? Although we don't encourage customers to abuse it, we do have
>commitments to existing customers.
>
>so it's best to make sure such functions are still in test coverage
>
>On Tue, Apr 14, 2015 at 2:16 PM, Shaofeng SHI (JIRA) <ji...@apache.org>
>wrote:
>
>>
>> [
>>
>>https://issues.apache.org/jira/browse/KYLIN-684?page=com.atlassian.jira.p
>>lugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14493647#co
>>mment-14493647
>> ]
>>
>> Shaofeng SHI commented on KYLIN-684:
>> ------------------------------------
>>
>> Code change submitted to staging branch; And I run the sample cube once,
>> it can be successfully built. The change will be roll out in next binary
>> package update;
>>
>> > Remove holistic distinct count and multiple column distinct count from
>> sample cube
>> >
>>
>>-------------------------------------------------------------------------
>>---------
>> >
>> > Key: KYLIN-684
>> > URL: https://issues.apache.org/jira/browse/KYLIN-684
>> > Project: Kylin
>> > Issue Type: Bug
>> > Components: General
>> > Affects Versions: v0.7.1
>> > Reporter: Shaofeng SHI
>> > Assignee: Shaofeng SHI
>> >
>> > In the sample cube "kylin_sales_cube_desc", there are two advanced
>> measures which are not formally supported yet. This makes user
>>confusing.
>> So drop them should be better than keep them there.
>>
>>
>>
>> --
>> This message was sent by Atlassian JIRA
>> (v6.3.4#6332)
>>
>
>
>
>--
>Regards,
>
>*Bin Mahone | 马洪宾*
>Apache Kylin: http://kylin.io
>Github: https://github.com/binmahone
Re: [jira] [Commented] (KYLIN-684) Remove holistic distinct count and
multiple column distinct count from sample cube
Posted by hongbin ma <ma...@apache.org>.
Is it possible that you remove them in sample cubes but keep them in test
cases? Although we don't encourage customers to abuse it, we do have
commitments to existing customers.
so it's best to make sure such functions are still in test coverage
On Tue, Apr 14, 2015 at 2:16 PM, Shaofeng SHI (JIRA) <ji...@apache.org>
wrote:
>
> [
> https://issues.apache.org/jira/browse/KYLIN-684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14493647#comment-14493647
> ]
>
> Shaofeng SHI commented on KYLIN-684:
> ------------------------------------
>
> Code change submitted to staging branch; And I run the sample cube once,
> it can be successfully built. The change will be roll out in next binary
> package update;
>
> > Remove holistic distinct count and multiple column distinct count from
> sample cube
> >
> ----------------------------------------------------------------------------------
> >
> > Key: KYLIN-684
> > URL: https://issues.apache.org/jira/browse/KYLIN-684
> > Project: Kylin
> > Issue Type: Bug
> > Components: General
> > Affects Versions: v0.7.1
> > Reporter: Shaofeng SHI
> > Assignee: Shaofeng SHI
> >
> > In the sample cube "kylin_sales_cube_desc", there are two advanced
> measures which are not formally supported yet. This makes user confusing.
> So drop them should be better than keep them there.
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.3.4#6332)
>
--
Regards,
*Bin Mahone | 马洪宾*
Apache Kylin: http://kylin.io
Github: https://github.com/binmahone