You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/07/25 15:38:11 UTC

[GitHub] [incubator-devlake] e2corporation opened a new pull request, #2598: `hotfix` `v0.12.0` blueprint detail: update current run object status on refresh

e2corporation opened a new pull request, #2598:
URL: https://github.com/apache/incubator-devlake/pull/2598

   ### 🆘 Config-UI / Blueprints / Blueprint Detail - **Current Run Activity**
   
   ### Description
   
   This PR applies a supplemental hotfix to the last PR #2595 that further updates status on the **Current Run's** Activity, as well as resolves the **Started At** and **Duration** display values to take into consideration the pipeline's Pending or "Created State".
   
   ### Does this close any open issues?
   #2593 
   
   ### Screenshots
   <img width="1032" alt="Screen Shot 2022-07-25 at 11 36 13 AM" src="https://user-images.githubusercontent.com/1742233/180818278-6f8b61f0-6f5c-461e-a784-4ebd9b1beabe.png">
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] klesh merged pull request #2598: `hotfix` `v0.12.0` blueprint detail: update current run object status on refresh

Posted by GitBox <gi...@apache.org>.
klesh merged PR #2598:
URL: https://github.com/apache/incubator-devlake/pull/2598


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] e2corporation commented on a diff in pull request #2598: `hotfix` `v0.12.0` blueprint detail: update current run object status on refresh

Posted by GitBox <gi...@apache.org>.
e2corporation commented on code in PR #2598:
URL: https://github.com/apache/incubator-devlake/pull/2598#discussion_r929051339


##########
config-ui/src/pages/blueprints/blueprint-detail.jsx:
##########
@@ -684,10 +683,10 @@ const BlueprintDetail = (props) => {
         status: lastPipeline.status,
         statusLabel: TaskStatusLabels[lastPipeline.status],
         icon: getTaskStatusIcon(lastPipeline.status),
-        startedAt: dayjs(lastPipeline.beganAt).format('L LTS'),
+        startedAt: dayjs(lastPipeline.beganAt || lastPipeline.createdAt).format('L LTS'),

Review Comment:
   startedAt set to `-` for created state



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] likyh commented on a diff in pull request #2598: `hotfix` `v0.12.0` blueprint detail: update current run object status on refresh

Posted by GitBox <gi...@apache.org>.
likyh commented on code in PR #2598:
URL: https://github.com/apache/incubator-devlake/pull/2598#discussion_r929031603


##########
config-ui/src/pages/blueprints/blueprint-detail.jsx:
##########
@@ -684,10 +683,10 @@ const BlueprintDetail = (props) => {
         status: lastPipeline.status,
         statusLabel: TaskStatusLabels[lastPipeline.status],
         icon: getTaskStatusIcon(lastPipeline.status),
-        startedAt: dayjs(lastPipeline.beganAt).format('L LTS'),
+        startedAt: dayjs(lastPipeline.beganAt || lastPipeline.createdAt).format('L LTS'),

Review Comment:
   It should be set as empty instead of `createdAt`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org