You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/02/22 13:04:40 UTC
[GitHub] [accumulo] KikiManjaro opened a new pull request #2515: replace some calculation with TimeUnit
KikiManjaro opened a new pull request #2515:
URL: https://github.com/apache/accumulo/pull/2515
Related to #2512
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] DomGarguilo edited a comment on pull request #2515: replace some calculation with TimeUnit
Posted by GitBox <gi...@apache.org>.
DomGarguilo edited a comment on pull request #2515:
URL: https://github.com/apache/accumulo/pull/2515#issuecomment-1048252497
> When you are talking about a wildcard import * are you refering to: `import static java.util.concurrent.TimeUnit.*;` Is so, why can't i use that ?
The project does not allow for wildcard imports. Instead you will have to import all the parts separately i.e.
```java
import static java.util.concurrent.TimeUnit.DAYS;
import static java.util.concurrent.TimeUnit.HOURS;
import static java.util.concurrent.TimeUnit.MINUTES;
```
instead of
```java
import static java.util.concurrent.TimeUnit.*;
```
> I'm unable to run `mvn clean package -DskipTests` without issues:
What is your version of maven and operating system?
EDIT: I was writing this at the same time as the comment above which gives a better response so refer to that one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] KikiManjaro commented on a change in pull request #2515: replace some calculation with TimeUnit
Posted by GitBox <gi...@apache.org>.
KikiManjaro commented on a change in pull request #2515:
URL: https://github.com/apache/accumulo/pull/2515#discussion_r812406685
##########
File path: core/src/test/java/org/apache/accumulo/core/conf/ConfigurationTypeHelperTest.java
##########
@@ -80,11 +81,11 @@ public void testGetMemoryAsBytesFailureCases2() {
@Test
public void testGetTimeInMillis() {
- assertEquals(42L * 24 * 60 * 60 * 1000, ConfigurationTypeHelper.getTimeInMillis("42d"));
- assertEquals(42L * 60 * 60 * 1000, ConfigurationTypeHelper.getTimeInMillis("42h"));
- assertEquals(42L * 60 * 1000, ConfigurationTypeHelper.getTimeInMillis("42m"));
- assertEquals(42L * 1000, ConfigurationTypeHelper.getTimeInMillis("42s"));
- assertEquals(42L * 1000, ConfigurationTypeHelper.getTimeInMillis("42"));
+ assertEquals(DAYS.toMillis(42), ConfigurationTypeHelper.getTimeInMillis("42d"));
+ assertEquals(HOURS.toMillis(42), ConfigurationTypeHelper.getTimeInMillis("42h"));
+ assertEquals(MINUTES.toMillis(42), ConfigurationTypeHelper.getTimeInMillis("42m"));
+ assertEquals(SECONDS.toMillis(42), ConfigurationTypeHelper.getTimeInMillis("42s"));
+ assertEquals(42_000L, ConfigurationTypeHelper.getTimeInMillis("42"));
Review comment:
42_000L seemed shorter and cleaner to me :p
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] DomGarguilo commented on pull request #2515: replace some calculation with TimeUnit
Posted by GitBox <gi...@apache.org>.
DomGarguilo commented on pull request #2515:
URL: https://github.com/apache/accumulo/pull/2515#issuecomment-1048252497
> When you are talking about a wildcard import * are you refering to: `import static java.util.concurrent.TimeUnit.*;` Is so, why can't i use that ?
The project does not allow for wildcard imports. Instead you will have to import all the parts separately i.e.
```java
import static java.util.concurrent.TimeUnit.DAYS;
import static java.util.concurrent.TimeUnit.HOURS;
import static java.util.concurrent.TimeUnit.MINUTES;
```
instead of
```java
import static java.util.concurrent.TimeUnit.*;
```
> I'm unable to run `mvn clean package -DskipTests` without issues:
What is your version of maven and operating system?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on a change in pull request #2515: replace some calculation with TimeUnit
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #2515:
URL: https://github.com/apache/accumulo/pull/2515#discussion_r812394724
##########
File path: core/src/test/java/org/apache/accumulo/core/conf/ConfigurationTypeHelperTest.java
##########
@@ -80,11 +81,11 @@ public void testGetMemoryAsBytesFailureCases2() {
@Test
public void testGetTimeInMillis() {
- assertEquals(42L * 24 * 60 * 60 * 1000, ConfigurationTypeHelper.getTimeInMillis("42d"));
- assertEquals(42L * 60 * 60 * 1000, ConfigurationTypeHelper.getTimeInMillis("42h"));
- assertEquals(42L * 60 * 1000, ConfigurationTypeHelper.getTimeInMillis("42m"));
- assertEquals(42L * 1000, ConfigurationTypeHelper.getTimeInMillis("42s"));
- assertEquals(42L * 1000, ConfigurationTypeHelper.getTimeInMillis("42"));
+ assertEquals(DAYS.toMillis(42), ConfigurationTypeHelper.getTimeInMillis("42d"));
+ assertEquals(HOURS.toMillis(42), ConfigurationTypeHelper.getTimeInMillis("42h"));
+ assertEquals(MINUTES.toMillis(42), ConfigurationTypeHelper.getTimeInMillis("42m"));
+ assertEquals(SECONDS.toMillis(42), ConfigurationTypeHelper.getTimeInMillis("42s"));
+ assertEquals(42_000L, ConfigurationTypeHelper.getTimeInMillis("42"));
Review comment:
Why not?
```suggestion
assertEquals(SECONDS.toMillis(42), ConfigurationTypeHelper.getTimeInMillis("42"));
```
##########
File path: core/src/test/java/org/apache/accumulo/core/rpc/TTimeoutTransportTest.java
##########
@@ -75,7 +76,7 @@ public void testFailedSocketOpenIsClosed() throws IOException {
@Test
public void testFailedInputStreamClosesSocket() throws IOException {
- long timeout = 2 * 60_000; // 2 mins
+ long timeout = MINUTES.toMillis(2); // 2 mins
Review comment:
```suggestion
long timeout = MINUTES.toMillis(2);
```
##########
File path: core/src/main/java/org/apache/accumulo/core/classloader/DefaultContextClassLoaderFactory.java
##########
@@ -69,7 +71,7 @@ private static void startCleanupThread(final AccumuloConfiguration conf,
.collect(Collectors.toSet());
LOG.trace("{}-cleanup thread, contexts in use: {}", className, contextsInUse);
AccumuloVFSClassLoader.removeUnusedContexts(contextsInUse);
- }), 60_000, 60_000, TimeUnit.MILLISECONDS);
+ }), MINUTES.toMillis(1), MINUTES.toMillis(1), TimeUnit.MILLISECONDS);
Review comment:
You could static import the MILLISECONDS as well, to be consistent. Or, in this case, you could do:
```suggestion
}), 1, 1, MINUTES);
```
##########
File path: test/src/main/java/org/apache/accumulo/test/functional/KerberosIT.java
##########
@@ -616,13 +617,13 @@ public void testDelegationTokenWithReducedLifetime() throws Throwable {
assertEquals(rootUser.getPrincipal(), client.whoami());
return client.securityOperations().getDelegationToken(
- new DelegationTokenConfig().setTokenLifetime(5, TimeUnit.MINUTES));
+ new DelegationTokenConfig().setTokenLifetime(5, MINUTES));
}
});
AuthenticationTokenIdentifier identifier = ((DelegationTokenImpl) dt).getIdentifier();
assertTrue("Expected identifier to expire in no more than 5 minutes: " + identifier,
- identifier.getExpirationDate() - identifier.getIssueDate() <= (5 * 60_000));
+ identifier.getExpirationDate() - identifier.getIssueDate() <= (MINUTES.toMillis(5)));
Review comment:
After the conversion, this has some extra parens that could be removed:
```suggestion
identifier.getExpirationDate() - identifier.getIssueDate() <= MINUTES.toMillis(5));
```
##########
File path: core/src/test/java/org/apache/accumulo/core/rpc/TTimeoutTransportTest.java
##########
@@ -105,7 +106,7 @@ public void testFailedInputStreamClosesSocket() throws IOException {
@Test
public void testFailedOutputStreamClosesSocket() throws IOException {
- long timeout = 2 * 60_000; // 2 mins
+ long timeout = MINUTES.toMillis(2); // 2 mins
Review comment:
```suggestion
long timeout = MINUTES.toMillis(2);
```
##########
File path: test/src/main/java/org/apache/accumulo/test/functional/FateConcurrencyIT.java
##########
@@ -135,7 +136,7 @@ public void changeTableStateTest() throws Exception {
OnlineOpTiming timing1 = task.get();
log.trace("Online 1 in {} ms",
- TimeUnit.MILLISECONDS.convert(timing1.runningTime(), TimeUnit.NANOSECONDS));
+ MILLISECONDS.convert(timing1.runningTime(), NANOSECONDS));
Review comment:
`.convert()` is a very confusing, because it's not obvious which direction it is converting. The following would be better for these:
```suggestion
NANOSECONDS.toMillis(timing1.runningTime()));
```
##########
File path: server/base/src/test/java/org/apache/accumulo/server/security/delegation/ZooAuthenticationKeyWatcherTest.java
##########
@@ -66,7 +68,7 @@ public static void setupKeyGenerator() throws Exception {
private ZooReader zk;
private InstanceId instanceId;
private String baseNode;
- private long tokenLifetime = 7 * 24 * 60 * 60_000; // 7days
+ private long tokenLifetime = DAYS.toMillis(7); // 7days
Review comment:
```suggestion
private long tokenLifetime = DAYS.toMillis(7);
```
##########
File path: server/base/src/main/java/org/apache/accumulo/server/ServerContext.java
##########
@@ -434,7 +435,7 @@ private void monitorSwappiness() {
} catch (Exception t) {
log.error("", t);
}
- }, 1000, 10 * 60_000, TimeUnit.MILLISECONDS);
+ }, 1000, MINUTES.toMillis(10), TimeUnit.MILLISECONDS);
Review comment:
```suggestion
}, SECONDS.toMillis(1), MINUTES.toMillis(10), TimeUnit.MILLISECONDS);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on a change in pull request #2515: replace some calculation with TimeUnit
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #2515:
URL: https://github.com/apache/accumulo/pull/2515#discussion_r812411184
##########
File path: test/src/main/java/org/apache/accumulo/test/functional/FateConcurrencyIT.java
##########
@@ -135,7 +136,7 @@ public void changeTableStateTest() throws Exception {
OnlineOpTiming timing1 = task.get();
log.trace("Online 1 in {} ms",
- TimeUnit.MILLISECONDS.convert(timing1.runningTime(), TimeUnit.NANOSECONDS));
+ MILLISECONDS.convert(timing1.runningTime(), NANOSECONDS));
Review comment:
This note applied to the other occurrences in the same file (and possibly elsewhere).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] KikiManjaro edited a comment on pull request #2515: replace some calculation with TimeUnit
Posted by GitBox <gi...@apache.org>.
KikiManjaro edited a comment on pull request #2515:
URL: https://github.com/apache/accumulo/pull/2515#issuecomment-1048235294
When you are talking about a wildcard import * are you refering to:
`
import static java.util.concurrent.TimeUnit.*;
`
Is so, why can't i use that ?
<details>
<summary>I'm unable to run `mvn clean package -DskipTests` without issues:</summary>
```
mvn clean package -DskipTests
[INFO] Scanning for projects...
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Build Order:
[INFO]
[INFO] Apache Accumulo Project [pom]
[INFO] Apache Accumulo Start [jar]
[INFO] Apache Accumulo Core [jar]
[INFO] Apache Accumulo Server Base [jar]
[INFO] Apache Accumulo Compaction Coordinator [jar]
[INFO] Apache Accumulo Compactor [jar]
[INFO] Apache Accumulo GC Server [jar]
[INFO] Apache Accumulo Manager Server [jar]
[INFO] Apache Accumulo Monitor Server [jar]
[INFO] Apache Accumulo Tablet Server [jar]
[INFO] Apache Accumulo MiniCluster [jar]
[INFO] Apache Accumulo Native Libraries [pom]
[INFO] Apache Accumulo Shell [jar]
[INFO] Apache Accumulo Iterator Test Harness [jar]
[INFO] Apache Accumulo Testing [jar]
[INFO] Apache Accumulo Hadoop MapReduce [jar]
[INFO] Apache Accumulo [pom]
[INFO] Apache Accumulo Master Server (Deprecated) [pom]
[INFO]
[INFO] ----------------< org.apache.accumulo:accumulo-project >----------------
[INFO] Building Apache Accumulo Project 2.1.0-SNAPSHOT [1/18]
[INFO] --------------------------------[ pom ]---------------------------------
[INFO]
[INFO] --- maven-clean-plugin:3.1.0:clean (default-clean) @ accumulo-project ---
[INFO] Deleting /mnt/c/Users/kylia/Documents/Projects/accumulo/target
[INFO] Deleting /mnt/c/Users/kylia/Documents/Projects/accumulo (includes = [**/*.pyc, **/*.so], excludes = [])
[INFO]
[INFO] --- build-helper-maven-plugin:3.3.0:parse-version (parse-project-version) @ accumulo-project ---
[INFO]
[INFO] --- maven-enforcer-plugin:3.0.0-M3:enforce (enforce-maven-version) @ accumulo-project ---
[INFO]
[INFO] --- maven-enforcer-plugin:3.0.0-M3:enforce (enforce-java-version) @ accumulo-project ---
[INFO]
[INFO] --- maven-enforcer-plugin:3.0.0-M3:enforce (enforce-output-timestamp-property) @ accumulo-project ---
[INFO]
[INFO] --- maven-enforcer-plugin:3.0.0-M3:enforce (enforce-accumulo-rules) @ accumulo-project ---
[INFO]
[INFO] --- mavanagaiata:1.0.0:commit (git-commit) @ accumulo-project ---
[INFO]
[INFO] --- sortpom-maven-plugin:3.0.0:sort (sort-pom) @ accumulo-project ---
[INFO] Sorting file /mnt/c/Users/kylia/Documents/Projects/accumulo/pom.xml
[INFO] Pom file is already sorted, exiting
[INFO]
[INFO] --- formatter-maven-plugin:2.17.1:format (format-java-source) @ accumulo-project ---
[INFO]
[INFO] --- impsort-maven-plugin:1.6.2:sort (sort-imports) @ accumulo-project ---
[INFO] Processed 0 files in 00:00.001 (Already Sorted: 0, Needed Sorting: 0)
[INFO]
[INFO] --- maven-remote-resources-plugin:1.7.0:process (process-resource-bundles) @ accumulo-project ---
[INFO] Preparing remote bundle org.apache:apache-jar-resource-bundle:1.4
[INFO] Copying 3 resources from 1 bundle.
[INFO]
[INFO] --- license-maven-plugin:4.1:format (license-headers) @ accumulo-project ---
[INFO] Updating license headers...
[INFO]
[INFO] --- modernizer-maven-plugin:2.2.0:modernizer (modernizer) @ accumulo-project ---
[INFO]
[INFO] --- warbucks-maven-plugin:1.1.2:check (check-junit-categories-on-its) @ accumulo-project ---
[INFO] Rule 0: Class Matches: 0
[INFO] Rule 0: Class Failures: 0
[INFO] Total class failures: 0
[INFO]
[INFO] --- apache-rat-plugin:0.13:check (check-licenses) @ accumulo-project ---
[INFO] Enabled default license matchers.
[INFO] Will parse SCM ignores for exclusions...
[INFO] Parsing exclusions from /mnt/c/Users/kylia/Documents/Projects/accumulo/.gitignore
[INFO] Finished adding exclusions from SCM ignore files.
[INFO] 91 implicit excludes (use -debug for more details).
[INFO] 7 explicit excludes (use -debug for more details).
[INFO] 15 resources included (use -debug for more details)
[INFO] Rat check: Summary over all files. Unapproved: 0, unknown: 0, generated: 0, approved: 10 licenses.
[INFO]
[INFO] --- maven-site-plugin:3.9.1:attach-descriptor (attach-descriptor) @ accumulo-project ---
[INFO] Attaching 'src/site/site.xml' site descriptor with classifier 'site'.
[INFO]
[INFO] -----------------< org.apache.accumulo:accumulo-start >-----------------
[INFO] Building Apache Accumulo Start 2.1.0-SNAPSHOT [2/18]
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- maven-clean-plugin:3.1.0:clean (default-clean) @ accumulo-start ---
[INFO] Deleting /mnt/c/Users/kylia/Documents/Projects/accumulo/start/target
[INFO] Deleting /mnt/c/Users/kylia/Documents/Projects/accumulo/start (includes = [**/*.pyc, **/*.so], excludes = [])
[INFO]
[INFO] --- build-helper-maven-plugin:3.3.0:parse-version (parse-project-version) @ accumulo-start ---
[INFO]
[INFO] --- maven-enforcer-plugin:3.0.0-M3:enforce (enforce-maven-version) @ accumulo-start ---
[INFO]
[INFO] --- maven-enforcer-plugin:3.0.0-M3:enforce (enforce-java-version) @ accumulo-start ---
[INFO]
[INFO] --- maven-enforcer-plugin:3.0.0-M3:enforce (enforce-output-timestamp-property) @ accumulo-start ---
[INFO]
[INFO] --- maven-enforcer-plugin:3.0.0-M3:enforce (enforce-accumulo-rules) @ accumulo-start ---
[INFO]
[INFO] --- mavanagaiata:1.0.0:commit (git-commit) @ accumulo-start ---
[INFO]
[INFO] --- sortpom-maven-plugin:3.0.0:sort (sort-pom) @ accumulo-start ---
[INFO] Sorting file /mnt/c/Users/kylia/Documents/Projects/accumulo/start/pom.xml
[INFO] Pom file is already sorted, exiting
[INFO]
[INFO] --- formatter-maven-plugin:2.17.1:format (format-java-source) @ accumulo-start ---
[INFO] Processed 24 files in 1s348ms (Formatted: 0, Unchanged: 24, Failed: 0, Readonly: 0)
[INFO]
[INFO] --- impsort-maven-plugin:1.6.2:sort (sort-imports) @ accumulo-start ---
[INFO] Processed 24 files in 00:00.372 (Already Sorted: 24, Needed Sorting: 0)
[INFO]
[INFO] --- maven-remote-resources-plugin:1.7.0:process (process-resource-bundles) @ accumulo-start ---
[INFO] Preparing remote bundle org.apache:apache-jar-resource-bundle:1.4
[INFO] Copying 3 resources from 1 bundle.
[INFO]
[INFO] --- maven-resources-plugin:3.2.0:resources (default-resources) @ accumulo-start ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Using 'UTF-8' encoding to copy filtered properties files.
[INFO] skip non existing resourceDirectory /mnt/c/Users/kylia/Documents/Projects/accumulo/start/src/main/resources
[INFO] Copying 3 resources
[INFO]
[INFO] --- maven-compiler-plugin:3.8.1:compile (default-compile) @ accumulo-start ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 17 source files to /mnt/c/Users/kylia/Documents/Projects/accumulo/start/target/classes
[INFO]
[INFO] --- maven-resources-plugin:3.2.0:testResources (default-testResources) @ accumulo-start ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Using 'UTF-8' encoding to copy filtered properties files.
[INFO] Copying 1 resource
[INFO] Copying 3 resources
[INFO]
[INFO] --- license-maven-plugin:4.1:format (license-headers) @ accumulo-start ---
[INFO] Updating license headers...
[INFO]
[INFO] --- maven-compiler-plugin:3.8.1:testCompile (default-testCompile) @ accumulo-start ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 7 source files to /mnt/c/Users/kylia/Documents/Projects/accumulo/start/target/test-classes
[INFO]
[INFO] --- modernizer-maven-plugin:2.2.0:modernizer (modernizer) @ accumulo-start ---
[INFO]
[INFO] --- warbucks-maven-plugin:1.1.2:check (check-junit-categories-on-its) @ accumulo-start ---
[INFO] Rule 0: Class Matches: 0
[INFO] Rule 0: Class Failures: 0
[INFO] Total class failures: 0
[INFO]
[INFO] --- exec-maven-plugin:3.0.0:exec (Build Test jars) @ accumulo-start ---
/usr/bin/env: ‘bash\r’: No such file or directory
[ERROR] Command execution failed.
org.apache.commons.exec.ExecuteException: Process exited with an error: 127 (Exit value: 127)
at org.apache.commons.exec.DefaultExecutor.executeInternal (DefaultExecutor.java:404)
at org.apache.commons.exec.DefaultExecutor.execute (DefaultExecutor.java:166)
at org.codehaus.mojo.exec.ExecMojo.executeCommandLine (ExecMojo.java:982)
at org.codehaus.mojo.exec.ExecMojo.executeCommandLine (ExecMojo.java:929)
at org.codehaus.mojo.exec.ExecMojo.execute (ExecMojo.java:457)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:210)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81)
at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:972)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:196)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:566)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)
at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Apache Accumulo Project 2.1.0-SNAPSHOT:
[INFO]
[INFO] Apache Accumulo Project ............................ SUCCESS [01:03 min]
[INFO] Apache Accumulo Start .............................. FAILURE [02:00 min]
[INFO] Apache Accumulo Core ............................... SKIPPED
[INFO] Apache Accumulo Server Base ........................ SKIPPED
[INFO] Apache Accumulo Compaction Coordinator ............. SKIPPED
[INFO] Apache Accumulo Compactor .......................... SKIPPED
[INFO] Apache Accumulo GC Server .......................... SKIPPED
[INFO] Apache Accumulo Manager Server ..................... SKIPPED
[INFO] Apache Accumulo Monitor Server ..................... SKIPPED
[INFO] Apache Accumulo Tablet Server ...................... SKIPPED
[INFO] Apache Accumulo MiniCluster ........................ SKIPPED
[INFO] Apache Accumulo Native Libraries ................... SKIPPED
[INFO] Apache Accumulo Shell .............................. SKIPPED
[INFO] Apache Accumulo Iterator Test Harness .............. SKIPPED
[INFO] Apache Accumulo Testing ............................ SKIPPED
[INFO] Apache Accumulo Hadoop MapReduce ................... SKIPPED
[INFO] Apache Accumulo .................................... SKIPPED
[INFO] Apache Accumulo Master Server (Deprecated) ......... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 03:05 min
[INFO] Finished at: 2022-02-22T22:31:39+01:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:3.0.0:exec (Build Test jars) on project accumulo-start: Command execution failed.: Process exited with an error: 127 (Exit value: 127) -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn <args> -rf :accumulo-start
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] KikiManjaro commented on pull request #2515: replace some calculation with TimeUnit
Posted by GitBox <gi...@apache.org>.
KikiManjaro commented on pull request #2515:
URL: https://github.com/apache/accumulo/pull/2515#issuecomment-1048235294
When you are talking about a wildcard import * are you refering to:
`
import static java.util.concurrent.TimeUnit.*;
`
Is so, why can't i use that ?
I'm unable to run `mvn clean package -DskipTests` without issues:
`
mvn clean package -DskipTests
[INFO] Scanning for projects...
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Build Order:
[INFO]
[INFO] Apache Accumulo Project [pom]
[INFO] Apache Accumulo Start [jar]
[INFO] Apache Accumulo Core [jar]
[INFO] Apache Accumulo Server Base [jar]
[INFO] Apache Accumulo Compaction Coordinator [jar]
[INFO] Apache Accumulo Compactor [jar]
[INFO] Apache Accumulo GC Server [jar]
[INFO] Apache Accumulo Manager Server [jar]
[INFO] Apache Accumulo Monitor Server [jar]
[INFO] Apache Accumulo Tablet Server [jar]
[INFO] Apache Accumulo MiniCluster [jar]
[INFO] Apache Accumulo Native Libraries [pom]
[INFO] Apache Accumulo Shell [jar]
[INFO] Apache Accumulo Iterator Test Harness [jar]
[INFO] Apache Accumulo Testing [jar]
[INFO] Apache Accumulo Hadoop MapReduce [jar]
[INFO] Apache Accumulo [pom]
[INFO] Apache Accumulo Master Server (Deprecated) [pom]
[INFO]
[INFO] ----------------< org.apache.accumulo:accumulo-project >----------------
[INFO] Building Apache Accumulo Project 2.1.0-SNAPSHOT [1/18]
[INFO] --------------------------------[ pom ]---------------------------------
[INFO]
[INFO] --- maven-clean-plugin:3.1.0:clean (default-clean) @ accumulo-project ---
[INFO] Deleting /mnt/c/Users/kylia/Documents/Projects/accumulo/target
[INFO] Deleting /mnt/c/Users/kylia/Documents/Projects/accumulo (includes = [**/*.pyc, **/*.so], excludes = [])
[INFO]
[INFO] --- build-helper-maven-plugin:3.3.0:parse-version (parse-project-version) @ accumulo-project ---
[INFO]
[INFO] --- maven-enforcer-plugin:3.0.0-M3:enforce (enforce-maven-version) @ accumulo-project ---
[INFO]
[INFO] --- maven-enforcer-plugin:3.0.0-M3:enforce (enforce-java-version) @ accumulo-project ---
[INFO]
[INFO] --- maven-enforcer-plugin:3.0.0-M3:enforce (enforce-output-timestamp-property) @ accumulo-project ---
[INFO]
[INFO] --- maven-enforcer-plugin:3.0.0-M3:enforce (enforce-accumulo-rules) @ accumulo-project ---
[INFO]
[INFO] --- mavanagaiata:1.0.0:commit (git-commit) @ accumulo-project ---
[INFO]
[INFO] --- sortpom-maven-plugin:3.0.0:sort (sort-pom) @ accumulo-project ---
[INFO] Sorting file /mnt/c/Users/kylia/Documents/Projects/accumulo/pom.xml
[INFO] Pom file is already sorted, exiting
[INFO]
[INFO] --- formatter-maven-plugin:2.17.1:format (format-java-source) @ accumulo-project ---
[INFO]
[INFO] --- impsort-maven-plugin:1.6.2:sort (sort-imports) @ accumulo-project ---
[INFO] Processed 0 files in 00:00.001 (Already Sorted: 0, Needed Sorting: 0)
[INFO]
[INFO] --- maven-remote-resources-plugin:1.7.0:process (process-resource-bundles) @ accumulo-project ---
[INFO] Preparing remote bundle org.apache:apache-jar-resource-bundle:1.4
[INFO] Copying 3 resources from 1 bundle.
[INFO]
[INFO] --- license-maven-plugin:4.1:format (license-headers) @ accumulo-project ---
[INFO] Updating license headers...
[INFO]
[INFO] --- modernizer-maven-plugin:2.2.0:modernizer (modernizer) @ accumulo-project ---
[INFO]
[INFO] --- warbucks-maven-plugin:1.1.2:check (check-junit-categories-on-its) @ accumulo-project ---
[INFO] Rule 0: Class Matches: 0
[INFO] Rule 0: Class Failures: 0
[INFO] Total class failures: 0
[INFO]
[INFO] --- apache-rat-plugin:0.13:check (check-licenses) @ accumulo-project ---
[INFO] Enabled default license matchers.
[INFO] Will parse SCM ignores for exclusions...
[INFO] Parsing exclusions from /mnt/c/Users/kylia/Documents/Projects/accumulo/.gitignore
[INFO] Finished adding exclusions from SCM ignore files.
[INFO] 91 implicit excludes (use -debug for more details).
[INFO] 7 explicit excludes (use -debug for more details).
[INFO] 15 resources included (use -debug for more details)
[INFO] Rat check: Summary over all files. Unapproved: 0, unknown: 0, generated: 0, approved: 10 licenses.
[INFO]
[INFO] --- maven-site-plugin:3.9.1:attach-descriptor (attach-descriptor) @ accumulo-project ---
[INFO] Attaching 'src/site/site.xml' site descriptor with classifier 'site'.
[INFO]
[INFO] -----------------< org.apache.accumulo:accumulo-start >-----------------
[INFO] Building Apache Accumulo Start 2.1.0-SNAPSHOT [2/18]
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- maven-clean-plugin:3.1.0:clean (default-clean) @ accumulo-start ---
[INFO] Deleting /mnt/c/Users/kylia/Documents/Projects/accumulo/start/target
[INFO] Deleting /mnt/c/Users/kylia/Documents/Projects/accumulo/start (includes = [**/*.pyc, **/*.so], excludes = [])
[INFO]
[INFO] --- build-helper-maven-plugin:3.3.0:parse-version (parse-project-version) @ accumulo-start ---
[INFO]
[INFO] --- maven-enforcer-plugin:3.0.0-M3:enforce (enforce-maven-version) @ accumulo-start ---
[INFO]
[INFO] --- maven-enforcer-plugin:3.0.0-M3:enforce (enforce-java-version) @ accumulo-start ---
[INFO]
[INFO] --- maven-enforcer-plugin:3.0.0-M3:enforce (enforce-output-timestamp-property) @ accumulo-start ---
[INFO]
[INFO] --- maven-enforcer-plugin:3.0.0-M3:enforce (enforce-accumulo-rules) @ accumulo-start ---
[INFO]
[INFO] --- mavanagaiata:1.0.0:commit (git-commit) @ accumulo-start ---
[INFO]
[INFO] --- sortpom-maven-plugin:3.0.0:sort (sort-pom) @ accumulo-start ---
[INFO] Sorting file /mnt/c/Users/kylia/Documents/Projects/accumulo/start/pom.xml
[INFO] Pom file is already sorted, exiting
[INFO]
[INFO] --- formatter-maven-plugin:2.17.1:format (format-java-source) @ accumulo-start ---
[INFO] Processed 24 files in 1s348ms (Formatted: 0, Unchanged: 24, Failed: 0, Readonly: 0)
[INFO]
[INFO] --- impsort-maven-plugin:1.6.2:sort (sort-imports) @ accumulo-start ---
[INFO] Processed 24 files in 00:00.372 (Already Sorted: 24, Needed Sorting: 0)
[INFO]
[INFO] --- maven-remote-resources-plugin:1.7.0:process (process-resource-bundles) @ accumulo-start ---
[INFO] Preparing remote bundle org.apache:apache-jar-resource-bundle:1.4
[INFO] Copying 3 resources from 1 bundle.
[INFO]
[INFO] --- maven-resources-plugin:3.2.0:resources (default-resources) @ accumulo-start ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Using 'UTF-8' encoding to copy filtered properties files.
[INFO] skip non existing resourceDirectory /mnt/c/Users/kylia/Documents/Projects/accumulo/start/src/main/resources
[INFO] Copying 3 resources
[INFO]
[INFO] --- maven-compiler-plugin:3.8.1:compile (default-compile) @ accumulo-start ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 17 source files to /mnt/c/Users/kylia/Documents/Projects/accumulo/start/target/classes
[INFO]
[INFO] --- maven-resources-plugin:3.2.0:testResources (default-testResources) @ accumulo-start ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Using 'UTF-8' encoding to copy filtered properties files.
[INFO] Copying 1 resource
[INFO] Copying 3 resources
[INFO]
[INFO] --- license-maven-plugin:4.1:format (license-headers) @ accumulo-start ---
[INFO] Updating license headers...
[INFO]
[INFO] --- maven-compiler-plugin:3.8.1:testCompile (default-testCompile) @ accumulo-start ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 7 source files to /mnt/c/Users/kylia/Documents/Projects/accumulo/start/target/test-classes
[INFO]
[INFO] --- modernizer-maven-plugin:2.2.0:modernizer (modernizer) @ accumulo-start ---
[INFO]
[INFO] --- warbucks-maven-plugin:1.1.2:check (check-junit-categories-on-its) @ accumulo-start ---
[INFO] Rule 0: Class Matches: 0
[INFO] Rule 0: Class Failures: 0
[INFO] Total class failures: 0
[INFO]
[INFO] --- exec-maven-plugin:3.0.0:exec (Build Test jars) @ accumulo-start ---
/usr/bin/env: ‘bash\r’: No such file or directory
[ERROR] Command execution failed.
org.apache.commons.exec.ExecuteException: Process exited with an error: 127 (Exit value: 127)
at org.apache.commons.exec.DefaultExecutor.executeInternal (DefaultExecutor.java:404)
at org.apache.commons.exec.DefaultExecutor.execute (DefaultExecutor.java:166)
at org.codehaus.mojo.exec.ExecMojo.executeCommandLine (ExecMojo.java:982)
at org.codehaus.mojo.exec.ExecMojo.executeCommandLine (ExecMojo.java:929)
at org.codehaus.mojo.exec.ExecMojo.execute (ExecMojo.java:457)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:210)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81)
at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:972)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:196)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:566)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)
at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Apache Accumulo Project 2.1.0-SNAPSHOT:
[INFO]
[INFO] Apache Accumulo Project ............................ SUCCESS [01:03 min]
[INFO] Apache Accumulo Start .............................. FAILURE [02:00 min]
[INFO] Apache Accumulo Core ............................... SKIPPED
[INFO] Apache Accumulo Server Base ........................ SKIPPED
[INFO] Apache Accumulo Compaction Coordinator ............. SKIPPED
[INFO] Apache Accumulo Compactor .......................... SKIPPED
[INFO] Apache Accumulo GC Server .......................... SKIPPED
[INFO] Apache Accumulo Manager Server ..................... SKIPPED
[INFO] Apache Accumulo Monitor Server ..................... SKIPPED
[INFO] Apache Accumulo Tablet Server ...................... SKIPPED
[INFO] Apache Accumulo MiniCluster ........................ SKIPPED
[INFO] Apache Accumulo Native Libraries ................... SKIPPED
[INFO] Apache Accumulo Shell .............................. SKIPPED
[INFO] Apache Accumulo Iterator Test Harness .............. SKIPPED
[INFO] Apache Accumulo Testing ............................ SKIPPED
[INFO] Apache Accumulo Hadoop MapReduce ................... SKIPPED
[INFO] Apache Accumulo .................................... SKIPPED
[INFO] Apache Accumulo Master Server (Deprecated) ......... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 03:05 min
[INFO] Finished at: 2022-02-22T22:31:39+01:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:3.0.0:exec (Build Test jars) on project accumulo-start: Command execution failed.: Process exited with an error: 127 (Exit value: 127) -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn <args> -rf :accumulo-start
`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on pull request #2515: replace some calculation with TimeUnit
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #2515:
URL: https://github.com/apache/accumulo/pull/2515#issuecomment-1048250962
> When you are talking about a wildcard import * are you refering to: `import static java.util.concurrent.TimeUnit.*;` Is so, why can't i use that ?
It's a style choice. We like to be explicit with our imports. Here are some reasons people have made: https://stackoverflow.com/q/147454/196405
The Google Style Guide for Java also forbids it (but doesn't give a reason): https://google.github.io/styleguide/javaguide.html#s3.3.1-wildcard-imports
>
> I'm unable to run `mvn clean package -DskipTests` without issues:
Please don't paste the full build output into chat. It makes it harder to follow. I edited your comment to make it easier to read. You can typically just show the last few lines that show the error, if you run into a problem.
Based on the message, it looks like you don't have `bash` installed. This would be true if you were building on Windows (which we don't support), but could be true in other environments as well. Typically, you'd just install `bash`, but depending on your environment, you may need to do more than that to install all the build prerequisites. You could just let the PR checks do the build for you, since they build in a Linux environment already, but that's not as convenient as being able to build locally as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] KikiManjaro commented on pull request #2515: replace some calculation with TimeUnit
Posted by GitBox <gi...@apache.org>.
KikiManjaro commented on pull request #2515:
URL: https://github.com/apache/accumulo/pull/2515#issuecomment-1048532221
> Based on the message, it looks like you don't have `bash` installed. This would be true if you were building on Windows (which we don't support), but could be true in other environments as well. Typically, you'd just install `bash`, but depending on your environment, you may need to do more than that to install all the build prerequisites. You could just let the PR checks do the build for you, since they build in a Linux environment already, but that's not as convenient as being able to build locally as well.
It look like running the command with WSL and setting project line break to LF instead of CRLF is a good start 😊 thanks:
<details>
<summary>`mvn clean package -DskipTests` is now working well</summary>
```
[INFO] Apache Accumulo Project ............................ SUCCESS [02:22 min]
[INFO] Apache Accumulo Start .............................. SUCCESS [02:01 min]
[INFO] Apache Accumulo Core ............................... SUCCESS [09:23 min]
[INFO] Apache Accumulo Server Base ........................ SUCCESS [02:55 min]
[INFO] Apache Accumulo Compaction Coordinator ............. SUCCESS [01:38 min]
[INFO] Apache Accumulo Compactor .......................... SUCCESS [01:55 min]
[INFO] Apache Accumulo GC Server .......................... SUCCESS [01:51 min]
[INFO] Apache Accumulo Manager Server ..................... SUCCESS [02:17 min]
[INFO] Apache Accumulo Monitor Server ..................... SUCCESS [02:36 min]
[INFO] Apache Accumulo Tablet Server ...................... SUCCESS [02:19 min]
[INFO] Apache Accumulo MiniCluster ........................ SUCCESS [02:59 min]
[INFO] Apache Accumulo Native Libraries ................... SUCCESS [ 55.629 s]
[INFO] Apache Accumulo Shell .............................. SUCCESS [02:03 min]
[INFO] Apache Accumulo Iterator Test Harness .............. SUCCESS [01:34 min]
[INFO] Apache Accumulo Testing ............................ SUCCESS [04:13 min]
[INFO] Apache Accumulo Hadoop MapReduce ................... SUCCESS [02:56 min]
[INFO] Apache Accumulo .................................... SUCCESS [03:56 min]
[INFO] Apache Accumulo Master Server (Deprecated) ......... SUCCESS [ 9.202 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 48:11 min
[INFO] Finished at: 2022-02-23T03:09:33+01:00
[INFO] ------------------------------------------------------------------------
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii merged pull request #2515: Replace some calculation with TimeUnit
Posted by GitBox <gi...@apache.org>.
ctubbsii merged pull request #2515:
URL: https://github.com/apache/accumulo/pull/2515
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org