[GitHub] [arrow-datafusion] alamb opened a new pull request, #7334: Minor: Move shared testing code into datafusion_common

["alamb (via GitHub)" <gi...@apache.org>]

alamb opened a new pull request, #7334:
URL: https://github.com/apache/arrow-datafusion/pull/7334

   ## Which issue does this PR close?
   
   Final prep for #1754 
   
   ## Rationale for this change
   
   physical plan can't depend on code in core when I pull it out
   
   ## What changes are included in this PR?
   
   move some functions from `datafusion/core/src/test_util.rs` to `datafusion/common/src/test_util.rs`
   
   ## Are these changes tested?
   covered by existing tests
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   2. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
   -->
   
   ## Are there any user-facing changes?
   No -- I left backward compatible `pub use`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb merged pull request #7334: Minor: Move shared testing code into datafusion_common

["alamb (via GitHub)" <gi...@apache.org>]

alamb merged PR #7334:
URL: https://github.com/apache/arrow-datafusion/pull/7334


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #7334: Minor: Move shared testing code into datafusion_common

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #7334:
URL: https://github.com/apache/arrow-datafusion/pull/7334#discussion_r1298714626


##########
datafusion/common/src/test_util.rs:
##########
@@ -62,3 +64,152 @@ macro_rules! assert_not_contains {
         );
     };
 }
+
+/// Returns the arrow test data directory, which is by default stored

Review Comment:
   this is moved  code -- no changes



##########
datafusion/core/src/datasource/physical_plan/csv.rs:
##########
@@ -1249,4 +1249,20 @@ mod tests {
             }
         }
     }
+
+    /// Get the schema for the aggregate_test_* csv files with an additional filed not present in the files.
+    fn aggr_test_schema_with_missing_col() -> SchemaRef {

Review Comment:
   I moved this out as this is the only place it is used and rewrote it to append the column explicitly rather than copy/paste with one line difference



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org