You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Trevor Wennblom <no...@github.com> on 2013/05/26 01:12:58 UTC
[jclouds] ami2.clj doesn't make use of incubator-specific nilsafe
operator (#20)
You can merge this Pull Request by running:
git pull https://github.com/trevor/jclouds patch-2
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/20
-- Commit Summary --
* ami2.clj doesn't make use of incubator-specific nilsafe operator
-- File Changes --
M apis/ec2/src/main/clojure/org/jclouds/ec2/ami2.clj (2)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/20.patch
https://github.com/jclouds/jclouds/pull/20.diff
Re: [jclouds] ami2.clj doesn't make use of incubator-specific nilsafe
operator (#20)
Posted by Andrew Phillips <no...@github.com>.
Committed to [1.6.x](https://git-wip-us.apache.org/repos/asf?p=incubator-jclouds.git;a=commit;h=e06222bbabb254cbb2cbe57708c64187d50eace3). Thanks again, @trevor and @adriancole !
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/20#issuecomment-19813073
Re: [jclouds] ami2.clj doesn't make use of incubator-specific nilsafe
operator (#20)
Posted by Andrew Phillips <no...@github.com>.
Reopened #20.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/20
Re: [jclouds] ami2.clj doesn't make use of incubator-specific nilsafe
operator (#20)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #52](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/52/) FAILURE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/20#issuecomment-18456253
Re: [jclouds] ami2.clj doesn't make use of incubator-specific nilsafe
operator (#20)
Posted by Andrew Phillips <no...@github.com>.
> Is this and #19 ready to be pulled / closed?
@trevor Thanks for the ping. Have asked for someone with more clojure-fu to take a look. I'll also close-and-reopen this now to trigger BuildHive again.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/20#issuecomment-19024472
Re: [jclouds] ami2.clj doesn't make use of incubator-specific nilsafe
operator (#20)
Posted by Trevor Wennblom <no...@github.com>.
Is this and #19 ready to be pulled / closed?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/20#issuecomment-19007464
Re: [jclouds] ami2.clj doesn't make use of incubator-specific nilsafe
operator (#20)
Posted by Andrew Phillips <no...@github.com>.
> jclouds » jclouds #52 FAILURE
Wow, this one barfed with a merge conflict now. I suspect the BuildHive workspace might need resetting. The Java 7 PR build job should kick in a bit - let's see what that does: https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/423/
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/20#issuecomment-18456304
Re: [jclouds] ami2.clj doesn't make use of incubator-specific nilsafe
operator (#20)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #436](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/436/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/20#issuecomment-19025755
Re: [jclouds] ami2.clj doesn't make use of incubator-specific nilsafe
operator (#20)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #77](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/77/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/20#issuecomment-19025375
Re: [jclouds] ami2.clj doesn't make use of incubator-specific nilsafe
operator (#20)
Posted by Andrew Phillips <no...@github.com>.
Created [JCLOUDS-123](https://issues.apache.org/jira/browse/JCLOUDS-123) for this.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/20#issuecomment-19274855
Re: [jclouds] ami2.clj doesn't make use of incubator-specific nilsafe
operator (#20)
Posted by Trevor Wennblom <no...@github.com>.
how should I be interpreting this output from buildhive?
```
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ filesystem ---
[INFO] Compiling 10 source files to /scratch/jenkins/workspace/jclouds/jclouds/apis/filesystem/target/classes
[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /scratch/jenkins/workspace/jclouds/jclouds/apis/filesystem/src/main/java/org/jclouds/filesystem/strategy/internal/FilesystemStorageStrategyImpl.java:[57,7] error: FilesystemStorageStrategyImpl is not abstract and does not override abstract method getBlobKeysInsideContainer(String,String) in LocalStorageStrategy
[ERROR] /scratch/jenkins/workspace/jclouds/jclouds/apis/filesystem/src/main/java/org/jclouds/filesystem/strategy/internal/FilesystemStorageStrategyImpl.java:[152,3] error: method does not override or implement a method from a supertype
```
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/20#issuecomment-18455731
Re: [jclouds] ami2.clj doesn't make use of incubator-specific nilsafe
operator (#20)
Posted by Andrew Phillips <no...@github.com>.
Closed #20.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/20
Re: [jclouds] ami2.clj doesn't make use of incubator-specific nilsafe
operator (#20)
Posted by Andrew Phillips <no...@github.com>.
> how should I be interpreting this output from buildhive?
Not good. But also doesn't appear to be unrelated to your change. On the other hand, [pull request 19](https://buildhive.cloudbees.com/view/All/job/jclouds/job/jclouds/50/) was OK, so I'm not sure why this would suddenly fail unless the BuildHive job parameters have changed.
I'll close and re-open to trigger BuildHive again and see if this is reproducible.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/20#issuecomment-18456250
Re: [jclouds] ami2.clj doesn't make use of incubator-specific nilsafe
operator (#20)
Posted by Andrew Phillips <no...@github.com>.
@adriancole Backport to 1.6.x and 1.5.x, where applicable?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/20#issuecomment-19274713
Re: [jclouds] ami2.clj doesn't make use of incubator-specific nilsafe
operator (#20)
Posted by Andrew Phillips <no...@github.com>.
Committed to [master](https://git-wip-us.apache.org/repos/asf?p=incubator-jclouds.git;a=commit;h=f8fae7d557197de44b3dded7e40cb8d5fb4d650a). Thanks, @trevor !
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/20#issuecomment-19312404
Re: [jclouds] ami2.clj doesn't make use of incubator-specific nilsafe
operator (#20)
Posted by Andrew Phillips <no...@github.com>.
@trevor Let me try to ping someone with more clojure-fu than myself again to take a look...
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/20#issuecomment-19246170
Re: [jclouds] ami2.clj doesn't make use of incubator-specific nilsafe
operator (#20)
Posted by Adrian Cole <no...@github.com>.
+1 thanks for taking a close look, @trevor
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/20#issuecomment-19265889
Re: [jclouds] ami2.clj doesn't make use of incubator-specific nilsafe
operator (#20)
Posted by Andrew Phillips <no...@github.com>.
Closed #20.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/20
Re: [jclouds] ami2.clj doesn't make use of incubator-specific nilsafe
operator (#20)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #51](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/51/) FAILURE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/20#issuecomment-18455604
Re: [jclouds] ami2.clj doesn't make use of incubator-specific nilsafe
operator (#20)
Posted by Andrew Phillips <no...@github.com>.
Note: [this PR build](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/423/) also included the change from this PR. So looks good to go from that perspective.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/20#issuecomment-18466759
Re: [jclouds] ami2.clj doesn't make use of incubator-specific nilsafe
operator (#20)
Posted by Andrew Phillips <no...@github.com>.
Committed to [1.5.x](https://git-wip-us.apache.org/repos/asf?p=incubator-jclouds.git;h=9606d83). 1.6.x still waiting on the release...
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/20#issuecomment-19350190
Re: [jclouds] ami2.clj doesn't make use of incubator-specific nilsafe
operator (#20)
Posted by Andrew Phillips <no...@github.com>.
Reopened #20.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/20
Re: [jclouds] ami2.clj doesn't make use of incubator-specific nilsafe
operator (#20)
Posted by Andrew Phillips <no...@github.com>.
Closed #20.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/20
Re: [jclouds] ami2.clj doesn't make use of incubator-specific nilsafe
operator (#20)
Posted by Adrian Cole <no...@github.com>.
+1
On Tue, Jun 11, 2013 at 9:52 AM, Andrew Phillips
<no...@github.com>wrote:
> @adriancole <https://github.com/adriancole> Backport to 1.6.x and 1.5.x,
> where applicable?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/jclouds/jclouds/pull/20#issuecomment-19274713>
> .
>
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/20#issuecomment-19281614