You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Pradeep Soundararajan <pr...@citrix.com> on 2013/03/06 12:59:00 UTC
Review Request: Adding awsapi in the require section of cloud.spec as it
resolves issue with EC2 QUERY API Feature.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9776/
-----------------------------------------------------------
Review request for cloudstack, Chip Childers, Hugo Trippaers, Wido den Hollander, and Noa Resare.
Description
-------
Initial issue was cloudstack-awsapi is not installing along with MS and then webapps7080 folder is missing on the management server.
Solution:
Adding awsapi in the require section of cloud.spec as it resolves issue with EC2 QUERY API Feature.
Moved the post awsapi section to the post management since it was trying to provide symb link before installing management server.
Diffs
-----
packaging/centos63/cloud.spec 1ef35414dfd87c5ac04ce83b09aa1e409f1702e7
Diff: https://reviews.apache.org/r/9776/diff/
Testing
-------
Tested with the new build + packaging
Thanks,
Pradeep Soundararajan
Re: Review Request: Adding awsapi in the require section of
cloud.spec as it resolves issue with EC2 QUERY API Feature.
Posted by Chiradeep Vittal <Ch...@citrix.com>.
+1 on being part of default cloudstack install.
On 3/7/13 12:07 PM, "Chip Childers" <ch...@sungard.com> wrote:
>
>-----------------------------------------------------------
>This is an automatically generated e-mail. To reply, visit:
>https://reviews.apache.org/r/9776/#review17569
>-----------------------------------------------------------
>
>
>I'm waiting for resolution on the question asked before applying this
>patch to 4.1.
>
>Thanks!
>
>- Chip Childers
>
>
>On March 6, 2013, 11:58 a.m., Pradeep Soundararajan wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/9776/
>> -----------------------------------------------------------
>>
>> (Updated March 6, 2013, 11:58 a.m.)
>>
>>
>> Review request for cloudstack, Chip Childers, Hugo Trippaers, Wido den
>>Hollander, and Noa Resare.
>>
>>
>> Description
>> -------
>>
>> Initial issue was cloudstack-awsapi is not installing along with MS and
>>then webapps7080 folder is missing on the management server.
>>
>> Solution:
>> Adding awsapi in the require section of cloud.spec as it resolves issue
>>with EC2 QUERY API Feature.
>>
>> Moved the post awsapi section to the post management since it was
>>trying to provide symb link before installing management server.
>>
>>
>> Diffs
>> -----
>>
>> packaging/centos63/cloud.spec
>>1ef35414dfd87c5ac04ce83b09aa1e409f1702e7
>>
>> Diff: https://reviews.apache.org/r/9776/diff/
>>
>>
>> Testing
>> -------
>>
>> Tested with the new build + packaging
>>
>>
>> Thanks,
>>
>> Pradeep Soundararajan
>>
>>
>
Re: Review Request: Adding awsapi in the require section of cloud.spec as it
resolves issue with EC2 QUERY API Feature.
Posted by Chip Childers <ch...@sungard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9776/#review17569
-----------------------------------------------------------
I'm waiting for resolution on the question asked before applying this patch to 4.1.
Thanks!
- Chip Childers
On March 6, 2013, 11:58 a.m., Pradeep Soundararajan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9776/
> -----------------------------------------------------------
>
> (Updated March 6, 2013, 11:58 a.m.)
>
>
> Review request for cloudstack, Chip Childers, Hugo Trippaers, Wido den Hollander, and Noa Resare.
>
>
> Description
> -------
>
> Initial issue was cloudstack-awsapi is not installing along with MS and then webapps7080 folder is missing on the management server.
>
> Solution:
> Adding awsapi in the require section of cloud.spec as it resolves issue with EC2 QUERY API Feature.
>
> Moved the post awsapi section to the post management since it was trying to provide symb link before installing management server.
>
>
> Diffs
> -----
>
> packaging/centos63/cloud.spec 1ef35414dfd87c5ac04ce83b09aa1e409f1702e7
>
> Diff: https://reviews.apache.org/r/9776/diff/
>
>
> Testing
> -------
>
> Tested with the new build + packaging
>
>
> Thanks,
>
> Pradeep Soundararajan
>
>
Re: Review Request: Adding awsapi in the require section of cloud.spec as it
resolves issue with EC2 QUERY API Feature.
Posted by Chip Childers <ch...@sungard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9776/#review17735
-----------------------------------------------------------
Ship it!
Applied to 4.1:
commit 4f071bcdf8279b3edcf7ab43df697ba2a0d6dcdf
Author: Pradeep <pr...@citrix.com>
Date: Tue Mar 12 11:28:51 2013 +0530
Adding awsapi in the require section of cloud.spec as it resolves issue with EC2 QUERY API Feature.
Moved the post awsapi section to the post management since it is trying to provide symb link before installing management server.
Signed-off-by: Pradeep <pr...@citrix.com>
- Chip Childers
On March 12, 2013, 6:27 a.m., Pradeep Soundararajan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9776/
> -----------------------------------------------------------
>
> (Updated March 12, 2013, 6:27 a.m.)
>
>
> Review request for cloudstack, Chip Childers, Hugo Trippaers, Wido den Hollander, and Noa Resare.
>
>
> Description
> -------
>
> Initial issue was cloudstack-awsapi is not installing along with MS and then webapps7080 folder is missing on the management server.
>
> Solution:
> Adding awsapi in the require section of cloud.spec as it resolves issue with EC2 QUERY API Feature.
>
> Moved the post awsapi section to the post management since it was trying to provide symb link before installing management server.
>
>
> Diffs
> -----
>
> packaging/centos63/cloud.spec 63c59e2
>
> Diff: https://reviews.apache.org/r/9776/diff/
>
>
> Testing
> -------
>
> Tested with the new build + packaging
>
>
> Thanks,
>
> Pradeep Soundararajan
>
>
Re: Review Request: Adding awsapi in the require section of cloud.spec as it
resolves issue with EC2 QUERY API Feature.
Posted by Pradeep Soundararajan <pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9776/
-----------------------------------------------------------
(Updated March 12, 2013, 6:27 a.m.)
Review request for cloudstack, Chip Childers, Hugo Trippaers, Wido den Hollander, and Noa Resare.
Changes
-------
Updated the patch diff with the latest changes.
As per Chiradeep, "+1 on being part of default cloudstack install".
Could you please review and submit it.
Description
-------
Initial issue was cloudstack-awsapi is not installing along with MS and then webapps7080 folder is missing on the management server.
Solution:
Adding awsapi in the require section of cloud.spec as it resolves issue with EC2 QUERY API Feature.
Moved the post awsapi section to the post management since it was trying to provide symb link before installing management server.
Diffs (updated)
-----
packaging/centos63/cloud.spec 63c59e2
Diff: https://reviews.apache.org/r/9776/diff/
Testing
-------
Tested with the new build + packaging
Thanks,
Pradeep Soundararajan
Re: Review Request: Adding awsapi in the require section of
cloud.spec as it resolves issue with EC2 QUERY API Feature.
Posted by prasanna <ts...@apache.org>.
On 6 March 2013 21:13, Chip Childers <ch...@sungard.com> wrote:
> On Wed, Mar 06, 2013 at 03:35:17PM +0000, Hugo Trippaers wrote:
>> I automatically assumed it's an optional component, but I don't think we actually discussed this. It's also optional in the maven compile/build I've noticed. I'm certainly not against it being part of the "main" management server, but the dependencies are not really aligned yet. So it's going to be a huge rpm if we make a single package out of it.
>>
>
> The switch to make it optional in maven was done (per comments on the
> list) to speed up build time.
>
> I'd also be OK with calling this optional, but then we need to document
> the installation as a specific optional step.
>
> My preference is to have it be installed by default though. Having an
> AWS compatible API that's easily enabled (easily being a qualitative and
> debatable term) is a Good Thing (tm).
>
What I meant was it should be like the cloudstack-agent. I install it
if I run KVM hypervisors. Something like cloudstack-awsapi may be.
Having it install by default when you install cloudstack-management
shouldn't be necessary.
Re: Review Request: Adding awsapi in the require section of
cloud.spec as it resolves issue with EC2 QUERY API Feature.
Posted by Chip Childers <ch...@sungard.com>.
On Wed, Mar 06, 2013 at 03:35:17PM +0000, Hugo Trippaers wrote:
> I automatically assumed it's an optional component, but I don't think we actually discussed this. It's also optional in the maven compile/build I've noticed. I'm certainly not against it being part of the "main" management server, but the dependencies are not really aligned yet. So it's going to be a huge rpm if we make a single package out of it.
>
The switch to make it optional in maven was done (per comments on the
list) to speed up build time.
I'd also be OK with calling this optional, but then we need to document
the installation as a specific optional step.
My preference is to have it be installed by default though. Having an
AWS compatible API that's easily enabled (easily being a qualitative and
debatable term) is a Good Thing (tm).
> We should make a point of redoing the axis stuff to generate new classes and try to get the dependencies in line with the management server. But that's something for later. We could technically use the maven axis task to generate that part of the code automagically.
>
> Cheers,
>
> Hugo
>
> > -----Original Message-----
> > From: Chip Childers [mailto:chip.childers@sungard.com]
> > Sent: Wednesday, March 06, 2013 4:22 PM
> > To: cloudstack-dev@incubator.apache.org; Prasanna Santhanam
> > Cc: Wido den Hollander; Noa Resare; Hugo Trippaers; Pradeep Soundararajan
> > Subject: Re: Review Request: Adding awsapi in the require section of
> > cloud.spec as it resolves issue with EC2 QUERY API Feature.
> >
> > On Wed, Mar 06, 2013 at 12:23:09PM +0000, Prasanna Santhanam wrote:
> > >
> > > -----------------------------------------------------------
> > > This is an automatically generated e-mail. To reply, visit:
> > > https://reviews.apache.org/r/9776/#review17472
> > > -----------------------------------------------------------
> > >
> > >
> > > But awsapi should be an optional component to install, right?
> >
> > Why? Isn't it part of the core product now, with only a global setting as it's
> > flag to enable / disable the feature?
> >
> > IMO, it should be part of the default installation.
>
RE: Review Request: Adding awsapi in the require section of
cloud.spec as it resolves issue with EC2 QUERY API Feature.
Posted by Hugo Trippaers <HT...@schubergphilis.com>.
I automatically assumed it's an optional component, but I don't think we actually discussed this. It's also optional in the maven compile/build I've noticed. I'm certainly not against it being part of the "main" management server, but the dependencies are not really aligned yet. So it's going to be a huge rpm if we make a single package out of it.
We should make a point of redoing the axis stuff to generate new classes and try to get the dependencies in line with the management server. But that's something for later. We could technically use the maven axis task to generate that part of the code automagically.
Cheers,
Hugo
> -----Original Message-----
> From: Chip Childers [mailto:chip.childers@sungard.com]
> Sent: Wednesday, March 06, 2013 4:22 PM
> To: cloudstack-dev@incubator.apache.org; Prasanna Santhanam
> Cc: Wido den Hollander; Noa Resare; Hugo Trippaers; Pradeep Soundararajan
> Subject: Re: Review Request: Adding awsapi in the require section of
> cloud.spec as it resolves issue with EC2 QUERY API Feature.
>
> On Wed, Mar 06, 2013 at 12:23:09PM +0000, Prasanna Santhanam wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/9776/#review17472
> > -----------------------------------------------------------
> >
> >
> > But awsapi should be an optional component to install, right?
>
> Why? Isn't it part of the core product now, with only a global setting as it's
> flag to enable / disable the feature?
>
> IMO, it should be part of the default installation.
Re: Review Request: Adding awsapi in the require section of
cloud.spec as it resolves issue with EC2 QUERY API Feature.
Posted by Chip Childers <ch...@sungard.com>.
On Wed, Mar 06, 2013 at 12:23:09PM +0000, Prasanna Santhanam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9776/#review17472
> -----------------------------------------------------------
>
>
> But awsapi should be an optional component to install, right?
Why? Isn't it part of the core product now, with only a global setting
as it's flag to enable / disable the feature?
IMO, it should be part of the default installation.
RE: Review Request: Adding awsapi in the require section of
cloud.spec as it resolves issue with EC2 QUERY API Feature.
Posted by Pradeep Soundararajan <pr...@citrix.com>.
I have also noticed cloudstack-awsapi*.rpm is getting generated as part of packaging which is irrespective of awsapi build. That is the reason I have included the same as part of MS install.
“mvn -P awsapi package -Dsystemvm”
Thanks,
Pradeep S
From: Prasanna Santhanam [mailto:noreply@reviews.apache.org] On Behalf Of Prasanna Santhanam
Sent: Wednesday, March 06, 2013 5:53 PM
To: Chip Childers; Wido den Hollander; Noa Resare; Hugo Trippaers
Cc: cloudstack; Prasanna Santhanam; Pradeep Soundararajan
Subject: Re: Review Request: Adding awsapi in the require section of cloud.spec as it resolves issue with EC2 QUERY API Feature.
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9776/
But awsapi should be an optional component to install, right?
- Prasanna
On March 6th, 2013, 11:58 a.m., Pradeep Soundararajan wrote:
Review request for cloudstack, Chip Childers, Hugo Trippaers, Wido den Hollander, and Noa Resare.
By Pradeep Soundararajan.
Updated March 6, 2013, 11:58 a.m.
Description
Initial issue was cloudstack-awsapi is not installing along with MS and then webapps7080 folder is missing on the management server.
Solution:
Adding awsapi in the require section of cloud.spec as it resolves issue with EC2 QUERY API Feature.
Moved the post awsapi section to the post management since it was trying to provide symb link before installing management server.
Testing
Tested with the new build + packaging
Diffs
* packaging/centos63/cloud.spec (1ef35414dfd87c5ac04ce83b09aa1e409f1702e7)
View Diff<https://reviews.apache.org/r/9776/diff/>
Re: Review Request: Adding awsapi in the require section of cloud.spec as it
resolves issue with EC2 QUERY API Feature.
Posted by Prasanna Santhanam <Pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9776/#review17472
-----------------------------------------------------------
But awsapi should be an optional component to install, right?
- Prasanna Santhanam
On March 6, 2013, 11:58 a.m., Pradeep Soundararajan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9776/
> -----------------------------------------------------------
>
> (Updated March 6, 2013, 11:58 a.m.)
>
>
> Review request for cloudstack, Chip Childers, Hugo Trippaers, Wido den Hollander, and Noa Resare.
>
>
> Description
> -------
>
> Initial issue was cloudstack-awsapi is not installing along with MS and then webapps7080 folder is missing on the management server.
>
> Solution:
> Adding awsapi in the require section of cloud.spec as it resolves issue with EC2 QUERY API Feature.
>
> Moved the post awsapi section to the post management since it was trying to provide symb link before installing management server.
>
>
> Diffs
> -----
>
> packaging/centos63/cloud.spec 1ef35414dfd87c5ac04ce83b09aa1e409f1702e7
>
> Diff: https://reviews.apache.org/r/9776/diff/
>
>
> Testing
> -------
>
> Tested with the new build + packaging
>
>
> Thanks,
>
> Pradeep Soundararajan
>
>