You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by ahgittin <gi...@git.apache.org> on 2016/11/09 14:12:37 UTC
[GitHub] brooklyn-server pull request #421: Show info after application start
GitHub user ahgittin opened a pull request:
https://github.com/apache/brooklyn-server/pull/421
Show info after application start
handy with the docker one-line deployer
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ahgittin/brooklyn-server show-info-after-start
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/421.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #421
----
commit d28e196413358bcd179b367bb06ae2dd617e2234
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2016-11-09T14:10:30Z
display info on started apps in the log / stdout
handy with the docker one-line deployer
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #421: Show info after application start
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the issue:
https://github.com/apache/brooklyn-server/pull/421
LGTM in that case, merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #421: Show info after application start
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/421
this is classic only, as that's what the docker container uses at present (and the normal brooklyn dist), and it was easier to get going.
fully accept that when we move to osgi we'll have to change and do this all another way.
BTW i had been thinking the move to osgi would drop these args, most args in fact, in favour of config files and sending additional commands to the server afterwards, and we'd have to rebuild the `Dockerfile` of course. however it's worth bearing in mind that that the multi-command approach is a little tedious in docker-land however, as containers prefer the "just-one-process" model ... and many shells like alpine don't have job control to be able to background. entirely possible but maybe worth a discussion about whether to send startup instructions / duplicate this flag to brooklyn osgi or not.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #421: Show info after application start
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/421#discussion_r87215451
--- Diff: launcher-common/src/main/java/org/apache/brooklyn/launcher/common/BasicLauncher.java ---
@@ -724,6 +725,15 @@ protected void startApps() {
try {
LOG.info("Starting brooklyn application {} in location{} {}", new Object[] { app, locations.size()!=1?"s":"", locations });
((Startable)app).start(locations);
+ Entities.dumpInfo(app);
+ String sensors = "";
+ if (app.getAttribute(Attributes.MAIN_URI_MAPPED_PUBLIC)!=null) {
+ sensors = ": "+app.getAttribute(Attributes.MAIN_URI_MAPPED_PUBLIC);
+ } else if (app.getAttribute(Attributes.MAIN_URI)!=null) {
+ sensors += ": "+app.getAttribute(Attributes.MAIN_URI);
+ }
+ LOG.info("Started brooklyn application {} in location{} {}{}", new Object[] { app, locations.size()!=1?"s":"", locations,
+ sensors });
--- End diff --
I thought this is executed in classic mode only, no? How is the app passed to the osgi launcher?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #421: Show info after application start
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/421
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---