You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/03/30 06:23:20 UTC

[GitHub] [orc] dongjoon-hyun commented on a change in pull request #674: ORC-777: Make the vectorized row batch size configurable in MR record…

dongjoon-hyun commented on a change in pull request #674:
URL: https://github.com/apache/orc/pull/674#discussion_r603812715



##########
File path: java/mapreduce/src/java/org/apache/orc/mapreduce/OrcMapreduceRecordReader.java
##########
@@ -53,16 +53,20 @@ public OrcMapreduceRecordReader(RecordReader reader,
     rowInBatch = 0;
     this.row = (V) OrcStruct.createValue(schema);
   }
+  public OrcMapreduceRecordReader(Reader fileReader,
+      Reader.Options options) throws IOException {
+    this(fileReader, options, VectorizedRowBatch.DEFAULT_SIZE);

Review comment:
       Is there a reason why we use `DEFAULT_SIZE`, a fixed value?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org