[GitHub] [superset] ktmud commented on a change in pull request #12770: chore(explore): Reorder dataset search results based on property relevance

[GitBox <gi...@apache.org>]

ktmud commented on a change in pull request #12770:
URL: https://github.com/apache/superset/pull/12770#discussion_r564785396



##########
File path: superset-frontend/spec/javascripts/explore/components/DatasourcePanel_spec.jsx
##########
@@ -66,4 +77,47 @@ describe('datasourcepanel', () => {
     expect(screen.getByText('Columns')).toBeTruthy();
     expect(screen.getByText('Metrics')).toBeTruthy();
   });
+
+  it('should render search results', () => {
+    const { container } = render(
+      <ThemeProvider theme={supersetTheme}>
+        <DatasourcePanel {...props} />
+      </ThemeProvider>,
+    );

Review comment:
       You can use 
   
   ```ts
   /**
    * @jest-environment jsdom
    */
   
   import { render } from 'spec/helpers/testing-library';
   ```
   
   It adds the `ThemeProvider` for you.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org