[jira] [Resolved] (IMPALA-6895) Reduce flush, close and open calls in SimpleLogger::flush()

["Tim Armstrong (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/IMPALA-6895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tim Armstrong resolved IMPALA-6895.
-----------------------------------
    Resolution: Won't Do

> Reduce flush, close and open calls in SimpleLogger::flush()
> -----------------------------------------------------------
>
>                 Key: IMPALA-6895
>                 URL: https://issues.apache.org/jira/browse/IMPALA-6895
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Backend
>    Affects Versions: Impala 3.0
>            Reporter: Zoram Thanga
>            Priority: Minor
>              Labels: ramp-up
>
> Currently, SimpleLogger provides a Flush() interface which is used by its client(s) to periodically (hard-coded to 5 seconds) flush the log file. We could eliminate these flush threads by keeping track of last flush time, and have the caller of SimpleLogger::AppendEntry() flush on demand (now - last_flush_time >= 5 seconds or whatever).
> This has the added benefit of reducing contention on the SimpleLogger::log_file_lock_ mutex to just between the threads adding entries to the log file.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)