You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/29 11:39:46 UTC

[GitHub] [flink] aljoscha commented on pull request #13820: [FLINK-19671][codestyle] Revert .editorconfig change violating our coding style

aljoscha commented on pull request #13820:
URL: https://github.com/apache/flink/pull/13820#issuecomment-718697677


   I still maintain that the `.editorconfig` file was good as is: Out of the box, you got a setup with import ordering and code style that worked and passed our checkstyle and that quite some people already use anyways. That was better than what we had before.
   
   With this change all indentation is now only 1 level which is not very helpful.
   
   (The code base is not consistent when it comes to indentation and with this config it would mean that new people would start producing a consistent style.)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org