You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2020/05/25 03:32:51 UTC

[GitHub] [thrift] zeshuai007 commented on a change in pull request #2148: THRIFT-5212: Thrift Visual Studio project throw errors when build

zeshuai007 commented on a change in pull request #2148:
URL: https://github.com/apache/thrift/pull/2148#discussion_r429718115



##########
File path: lib/cpp/libthrift.vcxproj
##########
@@ -134,45 +182,53 @@
     <ConfigurationType>StaticLibrary</ConfigurationType>
     <UseDebugLibraries>true</UseDebugLibraries>
     <CharacterSet>MultiByte</CharacterSet>
+    <PlatformToolset>v142</PlatformToolset>

Review comment:
       Hi @emmenlau , I remove it and load the project but it can't builds correctly. The Visual Studio's working mechanism is: it will replace the `PlatformToolset` with your current environment's `PlatformToolset`. If your setting is not match with your current environment, it can't work.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org