You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by tr...@apache.org on 2021/08/26 07:47:18 UTC
[flink] branch master updated (e5de4a2 -> 6a7b5e8)
This is an automated email from the ASF dual-hosted git repository.
trohrmann pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git.
from e5de4a2 [FLINK-23965][e2e] Store logs under FLINK_DIR/log
add 0a20560 [hotfix][e2e] Only retrieve allocated ports if no sudo password is required
add 2fef9ed [FLINK-23954][tests] Add more logging to test_queryable_state_restart_tm.sh for debugging purposes
new 6a7b5e8 [FLINK-23954][e2e] Add debug logging to KvStateSerializer
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../tests/queryablestate/QsStateClient.java | 5 ++++
.../tests/queryablestate/QsStateProducer.java | 30 ++++++++++++----------
.../test-scripts/test-runner-common.sh | 8 ++++--
.../test_queryable_state_restart_tm.sh | 10 +++++---
.../state/serialization/KvStateSerializer.java | 9 +++++++
tools/ci/log4j.properties | 4 +++
6 files changed, 46 insertions(+), 20 deletions(-)
[flink] 01/01: [FLINK-23954][e2e] Add debug logging to
KvStateSerializer
Posted by tr...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
trohrmann pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git
commit 6a7b5e8079cfced519ac5e106f0fb7277131f8bd
Author: Till Rohrmann <tr...@apache.org>
AuthorDate: Wed Aug 25 15:46:49 2021 +0200
[FLINK-23954][e2e] Add debug logging to KvStateSerializer
This closes #16986.
---
.../client/state/serialization/KvStateSerializer.java | 9 +++++++++
tools/ci/log4j.properties | 4 ++++
2 files changed, 13 insertions(+)
diff --git a/flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/client/state/serialization/KvStateSerializer.java b/flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/client/state/serialization/KvStateSerializer.java
index 5903777..9f09b61 100644
--- a/flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/client/state/serialization/KvStateSerializer.java
+++ b/flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/client/state/serialization/KvStateSerializer.java
@@ -23,6 +23,9 @@ import org.apache.flink.api.java.tuple.Tuple2;
import org.apache.flink.core.memory.DataInputDeserializer;
import org.apache.flink.core.memory.DataOutputSerializer;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
import java.io.IOException;
import java.nio.ByteBuffer;
import java.util.ArrayList;
@@ -32,6 +35,7 @@ import java.util.Map;
/** Serialization and deserialization the different state types and namespaces. */
public final class KvStateSerializer {
+ private static final Logger LOG = LoggerFactory.getLogger(KvStateSerializer.class);
// The magic number is as a flag between key and namespace.
private static final int MAGIC_NUMBER = 42;
@@ -225,6 +229,7 @@ public final class KvStateSerializer {
// Serialize
DataOutputSerializer dos = new DataOutputSerializer(32);
+ int size = 0;
for (Map.Entry<UK, UV> entry : entries) {
keySerializer.serialize(entry.getKey(), dos);
@@ -234,8 +239,12 @@ public final class KvStateSerializer {
dos.writeBoolean(false);
valueSerializer.serialize(entry.getValue(), dos);
}
+
+ size++;
}
+ LOG.debug("Serialized map has {} entries.", size);
+
return dos.getCopyOfBuffer();
} else {
return null;
diff --git a/tools/ci/log4j.properties b/tools/ci/log4j.properties
index a9cacb0..411ceda 100644
--- a/tools/ci/log4j.properties
+++ b/tools/ci/log4j.properties
@@ -59,3 +59,7 @@ logger.yarn1.appenderRef.out.ref = ConsoleAppender
logger.yarn2.name = org.apache.flink.yarn.YARNSessionCapacitySchedulerITCase
logger.yarn2.level = INFO
logger.yarn2.appenderRef.out.ref = ConsoleAppender
+
+# debug information for queryable state
+logger.qs.name = org.apache.flink.queryablestate.client.state.serialization.KvStateSerializer
+logger.qs.level = DEBUG