You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/02/10 02:12:57 UTC

[GitHub] [iotdb] JerryZhangZZY commented on pull request #5018: [IOTDB-2512]Replaced some static variables with TSDataType.toString

JerryZhangZZY commented on pull request #5018:
URL: https://github.com/apache/iotdb/pull/5018#issuecomment-1034418427


   Good idea, thanks for your suggestion!
   
   从 Windows 版邮件发送
   
   发件人: Changqi
   发送时间: 2022年2月9日 下午 5:41
   收件人: apache/iotdb
   抄送: Zhang Zeyu; State change
   主题: Re: [apache/iotdb] [IOTDB-2512]Replaced some static variables withTSDataType.toString (PR #5018)
   
   why not just remove abstract for these methods in Statistics class, and add default implementations throw StatisticsClassException(String.format(STATS_UNSUPPORTED_MSG, getType(), "***"))
   —
   Reply to this email directly, view it on GitHub, or unsubscribe.
   Triage notifications on the go with GitHub Mobile for iOS or Android. 
   You are receiving this because you modified the open/close state.Message ID: ***@***.***>
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org