You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "Brian Hulette (Jira)" <ji...@apache.org> on 2020/07/06 15:59:00 UTC

[jira] [Commented] (BEAM-10402) Eliminate nullability errors from Beam Java

    [ https://issues.apache.org/jira/browse/BEAM-10402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152122#comment-17152122 ] 

Brian Hulette commented on BEAM-10402:
--------------------------------------

Once [https://github.com/apache/beam/pull/12162] is merged this will be a pretty good starter task. Here are some directions for anyone new to Beam who'd like to help out with this:

To see all the issues with a module run it's compileJava task with -PenableChecker=true, e.g. for the SQL extensions: {{./gradlew :sdks:java:extensions:sql:compileJava -PenableChecker=true}}

 Then squash all of the nullability bugs (most likely this will just require adding some {{@Nullable}} annotations to variables or arguments).

When all the bugs are fixed, set enableChecker=true in the applyJavaNature call in the module's build.gradle, e.g. [sdks/java/extensions/sql/build.gradle|https://github.com/apache/beam/blob/70a93993c3623e097d892ad8bcecca19da6f2c3f/sdks/java/extensions/sql/build.gradle#L25]

> Eliminate nullability errors from Beam Java
> -------------------------------------------
>
>                 Key: BEAM-10402
>                 URL: https://issues.apache.org/jira/browse/BEAM-10402
>             Project: Beam
>          Issue Type: Improvement
>          Components: io-java-amqp, io-java-avro, io-java-aws, io-java-azure, io-java-cassandra, io-java-clickhouse, io-java-elasticsearch, io-java-files, io-java-gcp, io-java-hadoop-file-system, io-java-hadoop-format, io-java-hbase, io-java-hcatalog, io-java-jdbc, io-java-jms, io-java-kafka, io-java-kinesis, io-java-kudu, io-java-mongodb, io-java-mqtt, io-java-parquet, io-java-rabbitmq, io-java-redis, io-java-solr, io-java-text, io-java-tfrecord, io-java-tika, io-java-utilities, io-java-xml, sdk-java-core, sdk-java-harness
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
>            Priority: P1
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> I enabled the checker framework and the core SDK exceeds 100 nullability errors immediately. We should make this number zero, since nullability errors are solved problem in computer science and they do periodically impact Beam.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)