You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/11/28 09:30:15 UTC

[GitHub] [flink] rkhachatryan opened a new pull request #10345: Flink 12484 synchronize all mailbox actions

rkhachatryan opened a new pull request #10345: Flink 12484 synchronize all mailbox actions
URL: https://github.com/apache/flink/pull/10345
 
 
   ## What is the purpose of the change
   
   * Synchronize all mailbox actions, so there is no need to acquire checkpoint lock in any code that is executed by the main task thread. This will further allow to drop getCheckpointLock() method from StreamTask
   
   ## Brief change log
   
     - introduce `ExecutionDecorator` field in `StreamTask`, `MailboxProcessor`, `MailboxExecutor`
     - use `SynchronizedExecutionDecorator` as a value for now
     - later (another PR) only `SourceStreamTask` will use it. All other tasks will use a decorator which just executes the action directly
   
   ## Verifying this change
   
   
   This change is covered by a new `StreamTaskExecutionDecorationTest`, as well as existing tests: `SourceStreamTaskTest`, `StreamTaskTest`.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): **no**
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
     -- code available through `@PublicEvolving` is modified: `AbstractStreamOperator.getContainingTask.getCheckpointLock` is dropped
     - The serializers: **no**
     - The runtime per-record code paths (performance sensitive): **yes** (coarser lock granularity for SourceStreamTask)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: **no**
     - The S3 file system connector: **no**
   
   ## Documentation
   
     - Does this pull request introduce a new feature? **no**
     - If yes, how is the feature documented? **not applicable**
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services