You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/02/23 19:38:18 UTC

[GitHub] [maven-wagon] michael-o opened a new pull request #63: [WAGON-576] Retry handler docs are possibly wrong

michael-o opened a new pull request #63: [WAGON-576] Retry handler docs are possibly wrong
URL: https://github.com/apache/maven-wagon/pull/63
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven-wagon] michael-o commented on issue #63: [WAGON-576] Retry handler docs are possibly wrong

Posted by GitBox <gi...@apache.org>.
michael-o commented on issue #63: [WAGON-576] Retry handler docs are possibly wrong
URL: https://github.com/apache/maven-wagon/pull/63#issuecomment-590108533
 
 
   @ok2c Please see whether this makes sense.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven-wagon] michael-o commented on issue #63: [WAGON-576] Retry handler docs are possibly wrong

Posted by GitBox <gi...@apache.org>.
michael-o commented on issue #63: [WAGON-576] Retry handler docs are possibly wrong
URL: https://github.com/apache/maven-wagon/pull/63#issuecomment-590340566
 
 
   @ok2c Done. It should be fine now.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven-wagon] ok2c commented on a change in pull request #63: [WAGON-576] Retry handler docs are possibly wrong

Posted by GitBox <gi...@apache.org>.
ok2c commented on a change in pull request #63: [WAGON-576] Retry handler docs are possibly wrong
URL: https://github.com/apache/maven-wagon/pull/63#discussion_r383143310
 
 

 ##########
 File path: wagon-providers/wagon-http/src/site/apt/index.apt
 ##########
 @@ -66,13 +66,20 @@ Features
 
     * <<<default>>> will use an instance of {{{http://hc.apache.org/httpcomponents-client-ga/httpclient/apidocs/org/apache/http/impl/client/DefaultHttpRequestRetryHandler.html}<<<DefaultHttpRequestRetryHandler>>>}} respecting <<<requestSentEnabled>>>, <<<count>>> and <<<nonRetryableClasses>>>.
 
-    *<< <standard>>> will use an instance of {{{http://hc.apache.org/httpcomponents-client-ga/httpclient/apidocs/org/apache/http/impl/client/StandardHttpRequestRetryHandler.html}<<<StandardHttpRequestRetryHandler>>>}} respecting <<<requestSentEnabled>>> and <<<count>>>.
+    *<<<standard>>> will use an instance of {{{http://hc.apache.org/httpcomponents-client-ga/httpclient/apidocs/org/apache/http/impl/client/StandardHttpRequestRetryHandler.html}<<<StandardHttpRequestRetryHandler>>>}} respecting <<<requestSentEnabled>>> and <<<count>>>.
 
     * Any fully qualified name of a {{{https://hc.apache.org/httpcomponents-client-ga/httpclient/apidocs/org/apache/http/client/HttpRequestRetryHandler.html}<<<HttpRequestRetryHandler>>>}} implementation will be instantiated with its default constructor.
 
+        [Attention] This will not work with the shaded version bundled with Maven.
+
  * <<<maven.wagon.http.retryHandler.requestSentEnabled>>> = <<<requestSentEnabled>>> for <<<default>>> or <<<standard>>> implementations.
 
  * <<<maven.wagon.http.retryHandler.count>>> = number of retries for <<<default>>> or <<<standard>>> implementations.
 
  * <<<maven.wagon.http.retryHandler.nonRetryableClasses>>> = a comma-separated list of fully qualified class names bypassing the retries (only the <<<default>>> implementation).
  If not set, the default value from {{{http://hc.apache.org/httpcomponents-client-ga/httpclient/apidocs/org/apache/http/impl/client/DefaultHttpRequestRetryHandler.html}<<<DefaultHttpRequestRetryHandler>>>}} will be used.
+
+ []
+
+        [Attention] Any retry handler will only react on initial exceptions, it will <not> salvage in-flight failures of ongoing streams.
 
 Review comment:
   @michael-o I would rather say 
   ```
   Any retry handler can only react to exception when executing the request and receiving the response head. It will <not> salvage in-flight failures of ongoing response body streams.
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven-wagon] asfgit closed pull request #63: [WAGON-576] Retry handler docs are possibly wrong

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #63: [WAGON-576] Retry handler docs are possibly wrong
URL: https://github.com/apache/maven-wagon/pull/63
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven-wagon] ok2c commented on a change in pull request #63: [WAGON-576] Retry handler docs are possibly wrong

Posted by GitBox <gi...@apache.org>.
ok2c commented on a change in pull request #63: [WAGON-576] Retry handler docs are possibly wrong
URL: https://github.com/apache/maven-wagon/pull/63#discussion_r383143803
 
 

 ##########
 File path: wagon-providers/wagon-http/src/site/apt/index.apt
 ##########
 @@ -66,13 +66,20 @@ Features
 
     * <<<default>>> will use an instance of {{{http://hc.apache.org/httpcomponents-client-ga/httpclient/apidocs/org/apache/http/impl/client/DefaultHttpRequestRetryHandler.html}<<<DefaultHttpRequestRetryHandler>>>}} respecting <<<requestSentEnabled>>>, <<<count>>> and <<<nonRetryableClasses>>>.
 
-    *<< <standard>>> will use an instance of {{{http://hc.apache.org/httpcomponents-client-ga/httpclient/apidocs/org/apache/http/impl/client/StandardHttpRequestRetryHandler.html}<<<StandardHttpRequestRetryHandler>>>}} respecting <<<requestSentEnabled>>> and <<<count>>>.
+    *<<<standard>>> will use an instance of {{{http://hc.apache.org/httpcomponents-client-ga/httpclient/apidocs/org/apache/http/impl/client/StandardHttpRequestRetryHandler.html}<<<StandardHttpRequestRetryHandler>>>}} respecting <<<requestSentEnabled>>> and <<<count>>>.
 
 Review comment:
   @michael-o As of today we have two GA branches. You should rather use `http://hc.apache.org/httpcomponents-client-4.5.x/` here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services