You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yuqi Du (Code Review)" <ge...@cloudera.org> on 2022/07/04 10:38:49 UTC

[kudu-CR] [unittest] LogRollingITest offen failed at asan, because of glog' leak

Yuqi Du has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18699


Change subject: [unittest] LogRollingITest offen failed at asan, because of glog' leak
......................................................................

[unittest] LogRollingITest offen failed at asan, because of glog' leak

Change-Id: I969dee0f04c1bea6c9b8de2040f3ccefeb5ec00c
---
M src/kudu/integration-tests/log-rolling-itest.cc
1 file changed, 6 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/99/18699/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18699
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I969dee0f04c1bea6c9b8de2040f3ccefeb5ec00c
Gerrit-Change-Number: 18699
Gerrit-PatchSet: 1
Gerrit-Owner: Yuqi Du <sh...@gmail.com>

[kudu-CR] [unittest] LogRollingITest offen failed at asan, because of glog' leak

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18699 )

Change subject: [unittest] LogRollingITest offen failed at asan, because of glog' leak
......................................................................


Patch Set 5: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18699
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I969dee0f04c1bea6c9b8de2040f3ccefeb5ec00c
Gerrit-Change-Number: 18699
Gerrit-PatchSet: 5
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Wed, 06 Jul 2022 16:04:11 +0000
Gerrit-HasComments: No

[kudu-CR] [unittest] LogRollingITest offen failed at asan, because of glog' leak

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18699 )

Change subject: [unittest] LogRollingITest offen failed at asan, because of glog' leak
......................................................................

[unittest] LogRollingITest offen failed at asan, because of glog' leak

Change-Id: I969dee0f04c1bea6c9b8de2040f3ccefeb5ec00c
Reviewed-on: http://gerrit.cloudera.org:8080/18699
Tested-by: Kudu Jenkins
Reviewed-by: Yingchun Lai <ac...@gmail.com>
---
M src/kudu/integration-tests/log-rolling-itest.cc
1 file changed, 7 insertions(+), 0 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Yingchun Lai: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/18699
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I969dee0f04c1bea6c9b8de2040f3ccefeb5ec00c
Gerrit-Change-Number: 18699
Gerrit-PatchSet: 6
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>

[kudu-CR] [unittest] LogRollingITest offen failed at asan, because of glog' leak

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18699 )

Change subject: [unittest] LogRollingITest offen failed at asan, because of glog' leak
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/18699/1/src/kudu/integration-tests/log-rolling-itest.cc
File src/kudu/integration-tests/log-rolling-itest.cc:

http://gerrit.cloudera.org:8080/#/c/18699/1/src/kudu/integration-tests/log-rolling-itest.cc@59
PS1, Line 59: which allocated by new operator, but no delete operator
> There is the delete operator, and it's invoked when calling ShutdownLogging
thank you.  would fix it.


http://gerrit.cloudera.org:8080/#/c/18699/1/src/kudu/integration-tests/log-rolling-itest.cc@60
PS1, Line 60:   GTEST_S
> That's the best way to skip a test: using GTEST_SKIP() is better since it r
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/18699
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I969dee0f04c1bea6c9b8de2040f3ccefeb5ec00c
Gerrit-Change-Number: 18699
Gerrit-PatchSet: 2
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Tue, 05 Jul 2022 06:06:59 +0000
Gerrit-HasComments: Yes

[kudu-CR] [unittest] LogRollingITest offen failed at asan, because of glog' leak

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18699

to look at the new patch set (#3).

Change subject: [unittest] LogRollingITest offen failed at asan, because of glog' leak
......................................................................

[unittest] LogRollingITest offen failed at asan, because of glog' leak

Change-Id: I969dee0f04c1bea6c9b8de2040f3ccefeb5ec00c
---
M src/kudu/integration-tests/log-rolling-itest.cc
1 file changed, 7 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/99/18699/3
-- 
To view, visit http://gerrit.cloudera.org:8080/18699
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I969dee0f04c1bea6c9b8de2040f3ccefeb5ec00c
Gerrit-Change-Number: 18699
Gerrit-PatchSet: 3
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>

[kudu-CR] [unittest] LogRollingITest offen failed at asan, because of glog' leak

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18699 )

Change subject: [unittest] LogRollingITest offen failed at asan, because of glog' leak
......................................................................


Patch Set 5: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18699
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I969dee0f04c1bea6c9b8de2040f3ccefeb5ec00c
Gerrit-Change-Number: 18699
Gerrit-PatchSet: 5
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Fri, 08 Jul 2022 02:56:16 +0000
Gerrit-HasComments: No

[kudu-CR] [unittest] LogRollingITest offen failed at asan, because of glog' leak

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18699 )

Change subject: [unittest] LogRollingITest offen failed at asan, because of glog' leak
......................................................................


Patch Set 4: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18699
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I969dee0f04c1bea6c9b8de2040f3ccefeb5ec00c
Gerrit-Change-Number: 18699
Gerrit-PatchSet: 4
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Wed, 06 Jul 2022 10:17:21 +0000
Gerrit-HasComments: No

[kudu-CR] [unittest] LogRollingITest offen failed at asan, because of glog' leak

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18699

to look at the new patch set (#4).

Change subject: [unittest] LogRollingITest offen failed at asan, because of glog' leak
......................................................................

[unittest] LogRollingITest offen failed at asan, because of glog' leak

Change-Id: I969dee0f04c1bea6c9b8de2040f3ccefeb5ec00c
---
M src/kudu/integration-tests/log-rolling-itest.cc
1 file changed, 7 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/99/18699/4
-- 
To view, visit http://gerrit.cloudera.org:8080/18699
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I969dee0f04c1bea6c9b8de2040f3ccefeb5ec00c
Gerrit-Change-Number: 18699
Gerrit-PatchSet: 4
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>

[kudu-CR] [unittest] LogRollingITest offen failed at asan, because of glog' leak

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18699 )

Change subject: [unittest] LogRollingITest offen failed at asan, because of glog' leak
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/18699/1/src/kudu/integration-tests/log-rolling-itest.cc
File src/kudu/integration-tests/log-rolling-itest.cc:

http://gerrit.cloudera.org:8080/#/c/18699/1/src/kudu/integration-tests/log-rolling-itest.cc@59
PS1, Line 59: which allocated by new operator, but no delete operator
There is the delete operator, and it's invoked when calling ShutdownLoggingSafe().  The problem is that ShutdownLoggingSafe() isn't called as needed.


http://gerrit.cloudera.org:8080/#/c/18699/1/src/kudu/integration-tests/log-rolling-itest.cc@60
PS1, Line 60:   return;
That's the best way to skip a test: using GTEST_SKIP() is better since it reports on the skipped tests in the stats printout.



-- 
To view, visit http://gerrit.cloudera.org:8080/18699
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I969dee0f04c1bea6c9b8de2040f3ccefeb5ec00c
Gerrit-Change-Number: 18699
Gerrit-PatchSet: 1
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 04 Jul 2022 15:38:34 +0000
Gerrit-HasComments: Yes

[kudu-CR] [unittest] LogRollingITest offen failed at asan, because of glog' leak

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18699

to look at the new patch set (#2).

Change subject: [unittest] LogRollingITest offen failed at asan, because of glog' leak
......................................................................

[unittest] LogRollingITest offen failed at asan, because of glog' leak

Change-Id: I969dee0f04c1bea6c9b8de2040f3ccefeb5ec00c
---
M src/kudu/integration-tests/log-rolling-itest.cc
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/99/18699/2
-- 
To view, visit http://gerrit.cloudera.org:8080/18699
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I969dee0f04c1bea6c9b8de2040f3ccefeb5ec00c
Gerrit-Change-Number: 18699
Gerrit-PatchSet: 2
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)