You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@sentry.apache.org by "kalyan kumar kalvagadda (JIRA)" <ji...@apache.org> on 2018/03/08 14:41:00 UTC

[jira] [Created] (SENTRY-2167) Fix the logs in NotificationProcessor

kalyan kumar kalvagadda created SENTRY-2167:
-----------------------------------------------

             Summary: Fix the logs in NotificationProcessor
                 Key: SENTRY-2167
                 URL: https://issues.apache.org/jira/browse/SENTRY-2167
             Project: Sentry
          Issue Type: Bug
          Components: Sentry
    Affects Versions: 2.1.0
            Reporter: kalyan kumar kalvagadda


Log levels of the couple of log messages looks to be in-correct. This has to be fixed.

Here is one of them

{noformat}

if ((oldDbName.equals(newDbName))
 && (oldTableName.equals(newTableName))
 && (oldLocation.equals(newLocation))) {
 LOGGER.error(String.format("Alter table notification ignored as neither name nor "
 + "location has changed: oldAuthzObj = %s, oldLocation = %s, newAuthzObj = %s, "
 + "newLocation = %s", oldDbName + "." + oldTableName, oldLocation,
 newDbName + "." + newTableName, newLocation));
 return false;
}

{noformat}

 

1. When the location and name of the object is not changed, sentry ignores that event. It is not an error. This should be logged with debug level.

2. When ever, SentryNoSuchObjectException is thrown, it is logged with INFO level. It is common that sentry doesn't have permissions on the objects that are changed. It need not be logged with INFO, instead it should be logged with debug level.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)