You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/12 20:29:24 UTC

[GitHub] [airflow] mik-laj commented on a change in pull request #12320: Fix/Enhancement: Disable forms and communicate to user when no DAG Runs

mik-laj commented on a change in pull request #12320:
URL: https://github.com/apache/airflow/pull/12320#discussion_r522406502



##########
File path: airflow/models/dag.py
##########
@@ -661,6 +661,15 @@ def get_last_dagrun(self, session=None, include_externally_triggered=False):
             self.dag_id, session=session, include_externally_triggered=include_externally_triggered
         )
 
+    @provide_session
+    def has_no_dag_runs(self, session=None, include_externally_triggered=True) -> bool:

Review comment:
       I have mixed feelings about methods that have negations in their names. What do you think about "has_dag_runs"?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org