You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/08/09 20:28:36 UTC
[GitHub] [superset] m-ajay opened a new pull request #16154: feat(dashboard): Let users re-arrange native filters
m-ajay opened a new pull request #16154:
URL: https://github.com/apache/superset/pull/16154
### SUMMARY
Allows users to re-arrange the dashboard native filters
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
### TESTING INSTRUCTIONS
- Click Edit icon (✏️) in native filters section on the left side of the dashboard
- Re-arrange the native filters in the opened modal box
- Save and verify that the order has changed in the UI
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [x] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-925366318
⚠️ @m-ajay Your base branch `master` has just also updated `superset/migrations`.
❗ **Please consider rebasing your branch to avoid db migration conflicts.**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-895530605
# [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16154](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d3ee2f7) into [master](https://codecov.io/gh/apache/superset/commit/331de0c4aed436a0975b618f0449e7cf10bf133f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (331de0c) will **decrease** coverage by `0.14%`.
> The diff coverage is `90.19%`.
> :exclamation: Current head d3ee2f7 differs from pull request most recent head 4db826e. Consider uploading reports for the commit 4db826e to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16154 +/- ##
==========================================
- Coverage 76.95% 76.81% -0.15%
==========================================
Files 1021 1006 -15
Lines 54846 54110 -736
Branches 7481 7332 -149
==========================================
- Hits 42206 41562 -644
+ Misses 12393 12308 -85
+ Partials 247 240 -7
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.35% <ø> (-0.11%)` | :arrow_down: |
| mysql | `81.69% <ø> (-0.15%)` | :arrow_down: |
| postgres | `81.75% <ø> (-0.16%)` | :arrow_down: |
| python | `82.15% <ø> (-0.11%)` | :arrow_down: |
| sqlite | `81.41% <ø> (-0.08%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nfigModal/FiltersConfigForm/CollapsibleControl.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0NvbGxhcHNpYmxlQ29udHJvbC50c3g=) | `88.46% <0.00%> (ø)` | |
| [...mponents/nativeFilters/FiltersConfigModal/utils.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL3V0aWxzLnRz) | `72.22% <0.00%> (ø)` | |
| [...nd/src/dashboard/components/nativeFilters/state.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc3RhdGUudHM=) | `75.00% <0.00%> (ø)` | |
| [...nd/src/dashboard/components/nativeFilters/utils.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdXRpbHMudHM=) | `56.25% <ø> (ø)` | |
| [...ilters/FilterBar/FilterControls/FilterControls.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlckNvbnRyb2xzLnRzeA==) | `80.00% <75.00%> (ø)` | |
| [...eFilters/FiltersConfigModal/FiltersConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdNb2RhbC50c3g=) | `94.31% <96.87%> (+4.89%)` | :arrow_up: |
| [...ts/nativeFilters/FiltersConfigModal/FilterTabs.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlclRhYnMudHN4) | `86.66% <100.00%> (ø)` | |
| [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `73.20% <100.00%> (-0.63%)` | :arrow_down: |
| [...nd/src/dashboard/components/nativeFilters/types.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdHlwZXMudHM=) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/components/Select/utils.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3V0aWxzLnRz) | `61.53% <0.00%> (-30.77%)` | :arrow_down: |
| ... and [181 more](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [331de0c...4db826e](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-895530605
# [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16154](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4645e8a) into [master](https://codecov.io/gh/apache/superset/commit/ccfc95fbe68da36f5eebd57421c2f5e57f7226e9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ccfc95f) will **decrease** coverage by `0.05%`.
> The diff coverage is `56.97%`.
> :exclamation: Current head 4645e8a differs from pull request most recent head daae259. Consider uploading reports for the commit daae259 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16154 +/- ##
==========================================
- Coverage 76.73% 76.67% -0.06%
==========================================
Files 996 997 +1
Lines 52999 53172 +173
Branches 6738 6782 +44
==========================================
+ Hits 40668 40772 +104
- Misses 12102 12169 +67
- Partials 229 231 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `70.89% <56.97%> (-0.08%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...mponents/nativeFilters/FiltersConfigModal/utils.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL3V0aWxzLnRz) | `72.97% <25.00%> (-0.64%)` | :arrow_down: |
| [...ilters/FilterBar/FilterControls/FilterControls.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlckNvbnRyb2xzLnRzeA==) | `80.00% <50.00%> (ø)` | |
| [...ativeFilters/FiltersConfigModal/FilterTabTitle.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlclRhYlRpdGxlLnRzeA==) | `55.35% <55.35%> (ø)` | |
| [...eFilters/FiltersConfigModal/FiltersConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdNb2RhbC50c3g=) | `89.00% <63.15%> (-6.46%)` | :arrow_down: |
| [...ts/nativeFilters/FiltersConfigModal/FilterTabs.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlclRhYnMudHN4) | `87.50% <80.00%> (+0.83%)` | :arrow_up: |
| [...perset-frontend/src/addSlice/AddSliceContainer.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FkZFNsaWNlQ29udGFpbmVyLnRzeA==) | `56.66% <0.00%> (-22.13%)` | :arrow_down: |
| [...tend/src/explore/components/ExploreChartHeader.jsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRIZWFkZXIuanN4) | `49.29% <0.00%> (-6.26%)` | :arrow_down: |
| [...d/src/explore/components/DatasourcePanel/index.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwvaW5kZXgudHN4) | `76.00% <0.00%> (-4.73%)` | :arrow_down: |
| [...frontend/src/dashboard/components/Header/index.jsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci9pbmRleC5qc3g=) | `59.88% <0.00%> (-3.19%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/welcome/ChartTable.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9DaGFydFRhYmxlLnRzeA==) | `73.17% <0.00%> (-1.83%)` | :arrow_down: |
| ... and [17 more](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ccfc95f...daae259](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-895530605
# [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16154](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d3ee2f7) into [master](https://codecov.io/gh/apache/superset/commit/519baa6f005a67c13ab13ad4bc2776f73afabed0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (519baa6) will **increase** coverage by `0.03%`.
> The diff coverage is `90.19%`.
> :exclamation: Current head d3ee2f7 differs from pull request most recent head e152809. Consider uploading reports for the commit e152809 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16154 +/- ##
==========================================
+ Coverage 76.77% 76.81% +0.03%
==========================================
Files 1003 1006 +3
Lines 53959 54110 +151
Branches 7330 7332 +2
==========================================
+ Hits 41427 41562 +135
- Misses 12293 12308 +15
- Partials 239 240 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.35% <ø> (+0.23%)` | :arrow_up: |
| mysql | `81.69% <ø> (+0.15%)` | :arrow_up: |
| postgres | `81.75% <ø> (+0.15%)` | :arrow_up: |
| presto | `?` | |
| python | `82.15% <ø> (+0.04%)` | :arrow_up: |
| sqlite | `81.41% <ø> (+0.19%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nfigModal/FiltersConfigForm/CollapsibleControl.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0NvbGxhcHNpYmxlQ29udHJvbC50c3g=) | `88.46% <0.00%> (ø)` | |
| [...mponents/nativeFilters/FiltersConfigModal/utils.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL3V0aWxzLnRz) | `72.22% <0.00%> (-1.39%)` | :arrow_down: |
| [...nd/src/dashboard/components/nativeFilters/state.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc3RhdGUudHM=) | `75.00% <0.00%> (ø)` | |
| [...nd/src/dashboard/components/nativeFilters/utils.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdXRpbHMudHM=) | `56.25% <ø> (ø)` | |
| [...ilters/FilterBar/FilterControls/FilterControls.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlckNvbnRyb2xzLnRzeA==) | `80.00% <75.00%> (ø)` | |
| [...eFilters/FiltersConfigModal/FiltersConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdNb2RhbC50c3g=) | `94.31% <96.87%> (-1.14%)` | :arrow_down: |
| [...ts/nativeFilters/FiltersConfigModal/FilterTabs.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlclRhYnMudHN4) | `86.66% <100.00%> (ø)` | |
| [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `73.20% <100.00%> (+0.07%)` | :arrow_up: |
| [...nd/src/dashboard/components/nativeFilters/types.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdHlwZXMudHM=) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `84.51% <0.00%> (-5.86%)` | :arrow_down: |
| ... and [57 more](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [519baa6...e152809](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-899792197
/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-895530605
# [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16154](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8a52631) into [master](https://codecov.io/gh/apache/superset/commit/5eded9fe1bcbcd77001f2a2632175f5d83f38376?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5eded9f) will **decrease** coverage by `0.02%`.
> The diff coverage is `61.22%`.
> :exclamation: Current head 8a52631 differs from pull request most recent head d577128. Consider uploading reports for the commit d577128 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16154 +/- ##
==========================================
- Coverage 76.53% 76.50% -0.03%
==========================================
Files 1000 1001 +1
Lines 53500 53568 +68
Branches 6814 6829 +15
==========================================
+ Hits 40946 40982 +36
- Misses 12316 12347 +31
- Partials 238 239 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `70.59% <61.22%> (-0.05%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...mponents/nativeFilters/FiltersConfigModal/utils.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL3V0aWxzLnRz) | `72.60% <0.00%> (-1.01%)` | :arrow_down: |
| [...nd/src/dashboard/components/nativeFilters/state.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc3RhdGUudHM=) | `73.68% <0.00%> (-1.32%)` | :arrow_down: |
| [...ilters/FilterBar/FilterControls/FilterControls.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlckNvbnRyb2xzLnRzeA==) | `80.00% <50.00%> (ø)` | |
| [...ativeFilters/FiltersConfigModal/FilterTabTitle.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlclRhYlRpdGxlLnRzeA==) | `54.54% <54.54%> (ø)` | |
| [...ts/nativeFilters/FiltersConfigModal/FilterTabs.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlclRhYnMudHN4) | `87.50% <66.66%> (+0.83%)` | :arrow_up: |
| [...eFilters/FiltersConfigModal/FiltersConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdNb2RhbC50c3g=) | `90.17% <79.41%> (-5.28%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5eded9f...d577128](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-895530605
# [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16154](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b81c9e9) into [master](https://codecov.io/gh/apache/superset/commit/87baac7650bdb6a8f8f82cf4992567a2c5c73cba?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (87baac7) will **decrease** coverage by `0.38%`.
> The diff coverage is `80.16%`.
> :exclamation: Current head b81c9e9 differs from pull request most recent head 1b2a88f. Consider uploading reports for the commit 1b2a88f to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16154 +/- ##
==========================================
- Coverage 76.97% 76.59% -0.39%
==========================================
Files 1022 1033 +11
Lines 54903 55190 +287
Branches 7485 7496 +11
==========================================
+ Hits 42262 42273 +11
- Misses 12393 12668 +275
- Partials 248 249 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `70.25% <77.21%> (-0.78%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...d/src/SqlLab/components/AceEditorWrapper/index.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIvaW5kZXgudHN4) | `58.75% <ø> (ø)` | |
| [...erset-frontend/src/SqlLab/components/App/index.jsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FwcC9pbmRleC5qc3g=) | `57.14% <ø> (ø)` | |
| [...tend/src/SqlLab/components/ColumnElement/index.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0NvbHVtbkVsZW1lbnQvaW5kZXgudHN4) | `95.45% <ø> (ø)` | |
| [...qlLab/components/EstimateQueryCostButton/index.jsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0VzdGltYXRlUXVlcnlDb3N0QnV0dG9uL2luZGV4LmpzeA==) | `20.83% <ø> (ø)` | |
| [...lLab/components/ExploreCtasResultsButton/index.jsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVDdGFzUmVzdWx0c0J1dHRvbi9pbmRleC5qc3g=) | `7.69% <ø> (ø)` | |
| [...c/SqlLab/components/ExploreResultsButton/index.jsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVSZXN1bHRzQnV0dG9uL2luZGV4LmpzeA==) | `92.00% <ø> (ø)` | |
| [...d/src/SqlLab/components/QueryAutoRefresh/index.jsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5QXV0b1JlZnJlc2gvaW5kZXguanN4) | `65.90% <ø> (ø)` | |
| [...c/SqlLab/components/RunQueryActionButton/index.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1J1blF1ZXJ5QWN0aW9uQnV0dG9uL2luZGV4LnRzeA==) | `65.11% <ø> (ø)` | |
| [...d/src/SqlLab/components/SaveDatasetModal/index.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NhdmVEYXRhc2V0TW9kYWwvaW5kZXgudHN4) | `88.23% <ø> (ø)` | |
| [...frontend/src/SqlLab/components/SaveQuery/index.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NhdmVRdWVyeS9pbmRleC50c3g=) | `75.55% <ø> (ø)` | |
| ... and [88 more](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [87baac7...1b2a88f](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #16154:
URL: https://github.com/apache/superset/pull/16154#discussion_r724522369
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/DraggableFilter.tsx
##########
@@ -0,0 +1,138 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { styled } from '@superset-ui/core';
+import React, { useRef } from 'react';
+import {
+ DragSourceMonitor,
+ DropTargetMonitor,
+ useDrag,
+ useDrop,
+ XYCoord,
+} from 'react-dnd';
+import Icons, { IconType } from 'src/components/Icons';
+
+interface TitleContainerProps {
+ readonly isDragging: boolean;
+}
+const FILTER_TYPE = 'FILTER';
+
+const Container = styled.div<TitleContainerProps>`
+ ${({ isDragging, theme }) => `
+ opacity: ${isDragging ? 0.3 : 1};
+ cursor: ${isDragging ? 'grabbing' : 'pointer'};
+ width: 100%;
+ display: flex;
+ padding: ${theme.gridUnit}px
+`}
Review comment:
```suggestion
`}
```
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterTitleContainer.tsx
##########
@@ -0,0 +1,162 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { styled, t } from '@superset-ui/core';
+import Icons from 'src/components/Icons';
+import { FilterRemoval } from './types';
+import DraggableFilter from './DraggableFilter';
+
+const FilterTitle = styled.div`
+ ${({ theme }) => `
+ display: flex;
+ padding: ${theme.gridUnit * 2}px;
+ width: 100%;
+ border-radius: ${theme.borderRadius}px;
+ &.active {
+ color: ${theme.colors.grayscale.dark1};
+ border-radius: ${theme.borderRadius}px;
+ background-color: ${theme.colors.secondary.light4};
+ span, .anticon {
+ color: ${theme.colors.grayscale.dark1};
+ }
+ }
+ &:hover {
+ color: ${theme.colors.primary.light1};
+ span, .anticon {
+ color: ${theme.colors.primary.light1};
+ }
+ }
+`}
Review comment:
```suggestion
`}
```
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/DraggableFilter.tsx
##########
@@ -0,0 +1,138 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { styled } from '@superset-ui/core';
+import React, { useRef } from 'react';
+import {
+ DragSourceMonitor,
+ DropTargetMonitor,
+ useDrag,
+ useDrop,
+ XYCoord,
+} from 'react-dnd';
+import Icons, { IconType } from 'src/components/Icons';
+
+interface TitleContainerProps {
+ readonly isDragging: boolean;
+}
+const FILTER_TYPE = 'FILTER';
+
+const Container = styled.div<TitleContainerProps>`
+ ${({ isDragging, theme }) => `
+ opacity: ${isDragging ? 0.3 : 1};
+ cursor: ${isDragging ? 'grabbing' : 'pointer'};
+ width: 100%;
+ display: flex;
+ padding: ${theme.gridUnit}px
+`}
+`;
+
+const DragIcon = styled(Icons.Drag)<IconType & { isDragging: boolean }>`
+ ${({ isDragging, theme }) => `
+ font-size: ${theme.typography.sizes.m}px;
+ margin-top: 12px;
+ cursor: ${isDragging ? 'grabbing' : 'grab'};
+ padding-left: ${theme.gridUnit}px;
+`}
Review comment:
```suggestion
`}
```
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterConfigPane.test.tsx
##########
@@ -0,0 +1,103 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { dashboardLayout } from 'spec/fixtures/mockDashboardLayout';
+import { buildNativeFilter } from 'spec/fixtures/mockNativeFilters';
+import { render, screen, fireEvent } from 'spec/helpers/testing-library';
+import FilterConfigPane from './FilterConfigurePane';
+
+const defaultProps = {
+ children: jest.fn(),
+ getFilterTitle: (id: string) => id,
+ onChange: jest.fn(),
+ onEdit: jest.fn(),
+ onRearrange: jest.fn(),
+ restoreFilter: jest.fn(),
+ currentFilterId: 'NATIVE_FILTER-1',
+ filterGroups: [['NATIVE_FILTER-2', 'NATIVE_FILTER-1'], ['NATIVE_FILTER-3']],
+ removedFilters: {},
+};
+const defaultState = {
+ dashboardInfo: {
+ metadata: {
+ native_filter_configuration: [
+ buildNativeFilter('NATIVE_FILTER-1', 'state', ['NATIVE_FILTER-2']),
+ buildNativeFilter('NATIVE_FILTER-2', 'country', []),
+ buildNativeFilter('NATIVE_FILTER-3', 'product', []),
+ ],
+ },
+ },
+ dashboardLayout,
+};
+
+function defaultRender(initialState: any = defaultState, props = defaultProps) {
+ return render(<FilterConfigPane {...props} />, {
+ initialState,
+ useDnd: true,
+ useRedux: true,
+ });
+}
+
+test('renders form', async () => {
+ defaultRender();
+ expect(defaultProps.children).toHaveBeenCalledTimes(3);
+});
+test('drag and drop', async () => {
Review comment:
```suggestion
});
test('drag and drop', async () => {
```
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControls.tsx
##########
@@ -17,16 +17,20 @@
* under the License.
*/
import React, { FC, useMemo, useState } from 'react';
-import { DataMask, styled, t } from '@superset-ui/core';
import { css } from '@emotion/react';
-import * as portals from 'react-reverse-portal';
-import { DataMaskStateWithId } from 'src/dataMask/types';
+import { DataMask, styled, t } from '@superset-ui/core';
+import {
+ createHtmlPortalNode,
+ InPortal,
+ OutPortal,
+} from 'react-reverse-portal';
import { Collapse } from 'src/common/components';
+import { DataMaskStateWithId } from 'src/dataMask/types';
+import { useDashboardHasTabs, useSelectFiltersInScope } from '../../state';
+import { Filter } from '../../types';
Review comment:
```suggestion
import {
useDashboardHasTabs,
useSelectFiltersInScope,
} from 'src/dashboard/components/nativeFilters/state';
import { Filter } from 'src/dashboard/components/nativeFilters/types';
```
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterConfigurePane.tsx
##########
@@ -0,0 +1,94 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { styled } from '@superset-ui/core';
+import React from 'react';
+import FilterTitlePane from './FilterTitlePane';
+import { FilterRemoval } from './types';
+
+interface Props {
+ children: (filterId: string) => React.ReactNode;
+ getFilterTitle: (filterId: string) => string;
+ onChange: (activeKey: string) => void;
+ onEdit: (filterId: string, action: 'add' | 'remove') => void;
+ onRearrange: (dragIndex: number, targetIndex: number) => void;
+ restoreFilter: (id: string) => void;
+ currentFilterId: string;
+ filterGroups: string[][];
+ removedFilters: Record<string, FilterRemoval>;
+}
+
+const Container = styled.div`
+ display: flex;
+ height: 100%;
+`;
+const ContentHolder = styled.div`
Review comment:
```suggestion
`;
const ContentHolder = styled.div`
```
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx
##########
@@ -92,19 +92,25 @@ import {
} from '../FiltersConfigModal';
import DatasetSelect from './DatasetSelect';
-const { TabPane } = Tabs;
+const TabPane = styled(Tabs.TabPane)`
+ padding: ${({ theme }) => theme.gridUnit * 4}px 0px;
+`;
const StyledContainer = styled.div`
+ ${({ theme }) => `
display: flex;
flex-direction: row-reverse;
justify-content: space-between;
+ padding: 0px ${theme.gridUnit * 4}px;
+`}
Review comment:
```suggestion
${({ theme }) => `
display: flex;
flex-direction: row-reverse;
justify-content: space-between;
padding: 0px ${theme.gridUnit * 4}px;
`}
```
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterConfigurePane.tsx
##########
@@ -0,0 +1,94 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { styled } from '@superset-ui/core';
+import React from 'react';
+import FilterTitlePane from './FilterTitlePane';
+import { FilterRemoval } from './types';
+
+interface Props {
+ children: (filterId: string) => React.ReactNode;
+ getFilterTitle: (filterId: string) => string;
+ onChange: (activeKey: string) => void;
+ onEdit: (filterId: string, action: 'add' | 'remove') => void;
+ onRearrange: (dragIndex: number, targetIndex: number) => void;
+ restoreFilter: (id: string) => void;
+ currentFilterId: string;
+ filterGroups: string[][];
+ removedFilters: Record<string, FilterRemoval>;
+}
+
+const Container = styled.div`
+ display: flex;
+ height: 100%;
+`;
+const ContentHolder = styled.div`
+ flex-grow: 3;
+ margin-left: ${({ theme }) => theme.gridUnit * -1 - 1};
+`;
+const TitlesContainer = styled.div`
+ width: 270px;
+ border-right: 1px solid ${({ theme }) => theme.colors.grayscale.light2};
+`;
+
+const FiltureConfigurePane: React.FC<Props> = ({
+ getFilterTitle,
+ onChange,
+ onEdit,
+ onRearrange,
+ restoreFilter,
+ children,
+ currentFilterId,
+ filterGroups,
+ removedFilters,
+}) => {
+ const active = filterGroups.flat().filter(id => id === currentFilterId)[0];
+ return (
+ <Container>
+ <TitlesContainer>
+ <FilterTitlePane
+ currentFilterId={currentFilterId}
+ filterGroups={filterGroups}
+ getFilterTitle={getFilterTitle}
+ onChange={onChange}
+ onEdit={onEdit}
+ onRearrage={onRearrange}
+ onRemove={(id: string) => onEdit(id, 'remove')}
+ removedFilters={removedFilters}
+ restoreFilter={restoreFilter}
+ />
+ </TitlesContainer>
+ <ContentHolder>
+ {filterGroups.flat().map(id => (
+ <div
+ key={id}
+ style={{
+ height: '100%',
+ overflowY: 'scroll',
Review comment:
```suggestion
overflowY: 'auto',
```
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterConfigurePane.tsx
##########
@@ -0,0 +1,94 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { styled } from '@superset-ui/core';
+import React from 'react';
+import FilterTitlePane from './FilterTitlePane';
+import { FilterRemoval } from './types';
+
+interface Props {
+ children: (filterId: string) => React.ReactNode;
+ getFilterTitle: (filterId: string) => string;
+ onChange: (activeKey: string) => void;
+ onEdit: (filterId: string, action: 'add' | 'remove') => void;
+ onRearrange: (dragIndex: number, targetIndex: number) => void;
+ restoreFilter: (id: string) => void;
+ currentFilterId: string;
+ filterGroups: string[][];
+ removedFilters: Record<string, FilterRemoval>;
+}
+
+const Container = styled.div`
+ display: flex;
+ height: 100%;
+`;
+const ContentHolder = styled.div`
+ flex-grow: 3;
+ margin-left: ${({ theme }) => theme.gridUnit * -1 - 1};
+`;
+const TitlesContainer = styled.div`
Review comment:
```suggestion
`;
const TitlesContainer = styled.div`
```
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterConfigPane.test.tsx
##########
@@ -0,0 +1,103 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { dashboardLayout } from 'spec/fixtures/mockDashboardLayout';
+import { buildNativeFilter } from 'spec/fixtures/mockNativeFilters';
+import { render, screen, fireEvent } from 'spec/helpers/testing-library';
+import FilterConfigPane from './FilterConfigurePane';
+
+const defaultProps = {
Review comment:
These new tests are generating async-related warnings. We should make sure that new tests don't throw warnings.
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal.tsx
##########
@@ -249,28 +279,69 @@ export function FiltersConfigModal({
const handleCancel = () => {
const changed = form.getFieldValue('changed');
- if (unsavedFiltersIds.length > 0 || form.isFieldsTouched() || changed) {
+ const initialOrder = buildFilterGroup(getInitialFilterHierarchy()).flat();
+ const didChangeOrder =
+ orderedFilters.flat().length !== initialOrder.length ||
+ orderedFilters.flat().some((val, index) => val !== initialOrder[index]);
+ if (
+ unsavedFiltersIds.length > 0 ||
+ form.isFieldsTouched() ||
+ changed ||
+ didChangeOrder
+ ) {
setSaveAlertVisible(true);
} else {
handleConfirmCancel();
}
};
+ const onRearrage = (dragIndex: number, targetIndex: number) => {
+ const newOrderedFilter = orderedFilters.map(group => [...group]);
+
+ const removed = newOrderedFilter.splice(dragIndex, 1)[0];
+ newOrderedFilter.splice(targetIndex, 0, removed);
+ setOrderedFilters(newOrderedFilter);
+ };
+ const handleFilterHierarchyChange = useCallback(
+ (filterId: string, parentFilter?: { value: string; label: string }) => {
+ const index = filterHierarchy.findIndex(item => item.id === filterId);
+ const newState = [...filterHierarchy];
+ newState.splice(index, 1, {
+ id: filterId,
+ parentId: parentFilter ? parentFilter.value : null,
+ });
+ setFilterHierarchy(newState);
+ setOrderedFilters(buildFilterGroup(newState));
+ },
+ [setFilterHierarchy, setOrderedFilters, filterHierarchy],
+ );
const onValuesChange = useMemo(
- () =>
- debounce((changes: any, values: NativeFiltersForm) => {
Review comment:
We shouldn't remove the `debounce` here.
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterTitleContainer.tsx
##########
@@ -0,0 +1,162 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { styled, t } from '@superset-ui/core';
+import Icons from 'src/components/Icons';
+import { FilterRemoval } from './types';
+import DraggableFilter from './DraggableFilter';
+
+const FilterTitle = styled.div`
+ ${({ theme }) => `
+ display: flex;
+ padding: ${theme.gridUnit * 2}px;
+ width: 100%;
+ border-radius: ${theme.borderRadius}px;
+ &.active {
+ color: ${theme.colors.grayscale.dark1};
+ border-radius: ${theme.borderRadius}px;
+ background-color: ${theme.colors.secondary.light4};
+ span, .anticon {
+ color: ${theme.colors.grayscale.dark1};
+ }
+ }
+ &:hover {
+ color: ${theme.colors.primary.light1};
+ span, .anticon {
+ color: ${theme.colors.primary.light1};
+ }
+ }
+`}
+`;
+
+const StyledTrashIcon = styled(Icons.Trash)`
+ color: ${({ theme }) => theme.colors.grayscale.light3};
+`;
+const Container = styled.div`
Review comment:
```suggestion
`;
const Container = styled.div`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-938012576
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] m-ajay commented on a change in pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
m-ajay commented on a change in pull request #16154:
URL: https://github.com/apache/superset/pull/16154#discussion_r727290303
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal.tsx
##########
@@ -249,28 +279,69 @@ export function FiltersConfigModal({
const handleCancel = () => {
const changed = form.getFieldValue('changed');
- if (unsavedFiltersIds.length > 0 || form.isFieldsTouched() || changed) {
+ const initialOrder = buildFilterGroup(getInitialFilterHierarchy()).flat();
+ const didChangeOrder =
+ orderedFilters.flat().length !== initialOrder.length ||
+ orderedFilters.flat().some((val, index) => val !== initialOrder[index]);
+ if (
+ unsavedFiltersIds.length > 0 ||
+ form.isFieldsTouched() ||
+ changed ||
+ didChangeOrder
+ ) {
setSaveAlertVisible(true);
} else {
handleConfirmCancel();
}
};
+ const onRearrage = (dragIndex: number, targetIndex: number) => {
+ const newOrderedFilter = orderedFilters.map(group => [...group]);
+
+ const removed = newOrderedFilter.splice(dragIndex, 1)[0];
+ newOrderedFilter.splice(targetIndex, 0, removed);
+ setOrderedFilters(newOrderedFilter);
+ };
+ const handleFilterHierarchyChange = useCallback(
+ (filterId: string, parentFilter?: { value: string; label: string }) => {
+ const index = filterHierarchy.findIndex(item => item.id === filterId);
+ const newState = [...filterHierarchy];
+ newState.splice(index, 1, {
+ id: filterId,
+ parentId: parentFilter ? parentFilter.value : null,
+ });
+ setFilterHierarchy(newState);
+ setOrderedFilters(buildFilterGroup(newState));
+ },
+ [setFilterHierarchy, setOrderedFilters, filterHierarchy],
+ );
const onValuesChange = useMemo(
- () =>
- debounce((changes: any, values: NativeFiltersForm) => {
Review comment:
Debouncing was causing a latency in filter hierarchy change when adding/removing parent filters.
Thats why I removed it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-933681537
@michael-s-molina Ephemeral environment spinning up at http://52.12.6.65:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-938134466
If I have a hierarchy of Filter 1 -> Filter 2 -> Filter 3 and I delete Filter 2, Filter 3 correctly displays that the parent was deleted which means that it doesn't belong to a hierarchy anymore, but Filter 3 is still displayed nested to Filter 1.
https://user-images.githubusercontent.com/70410625/136457472-36dc100b-c695-4cb6-9509-9922a460cc18.mov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat merged pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
graceguo-supercat merged pull request #16154:
URL: https://github.com/apache/superset/pull/16154
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-895530605
# [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16154](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4645e8a) into [master](https://codecov.io/gh/apache/superset/commit/5eded9fe1bcbcd77001f2a2632175f5d83f38376?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5eded9f) will **increase** coverage by `0.14%`.
> The diff coverage is `56.97%`.
> :exclamation: Current head 4645e8a differs from pull request most recent head d577128. Consider uploading reports for the commit d577128 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16154 +/- ##
==========================================
+ Coverage 76.53% 76.67% +0.14%
==========================================
Files 1000 997 -3
Lines 53500 53172 -328
Branches 6814 6782 -32
==========================================
- Hits 40946 40772 -174
+ Misses 12316 12169 -147
+ Partials 238 231 -7
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `70.89% <56.97%> (+0.25%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...mponents/nativeFilters/FiltersConfigModal/utils.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL3V0aWxzLnRz) | `72.97% <25.00%> (-0.64%)` | :arrow_down: |
| [...ilters/FilterBar/FilterControls/FilterControls.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlckNvbnRyb2xzLnRzeA==) | `80.00% <50.00%> (ø)` | |
| [...ativeFilters/FiltersConfigModal/FilterTabTitle.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlclRhYlRpdGxlLnRzeA==) | `55.35% <55.35%> (ø)` | |
| [...eFilters/FiltersConfigModal/FiltersConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdNb2RhbC50c3g=) | `89.00% <63.15%> (-6.46%)` | :arrow_down: |
| [...ts/nativeFilters/FiltersConfigModal/FilterTabs.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlclRhYnMudHN4) | `87.50% <80.00%> (+0.83%)` | :arrow_up: |
| [superset-frontend/src/reports/reducers/reports.js](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlcG9ydHMvcmVkdWNlcnMvcmVwb3J0cy5qcw==) | `25.00% <0.00%> (-43.75%)` | :arrow_down: |
| [superset-frontend/src/reports/actions/reports.js](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlcG9ydHMvYWN0aW9ucy9yZXBvcnRzLmpz) | `9.80% <0.00%> (-31.38%)` | :arrow_down: |
| [...rset-frontend/src/components/ReportModal/index.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUmVwb3J0TW9kYWwvaW5kZXgudHN4) | `74.46% <0.00%> (-19.29%)` | :arrow_down: |
| [...frontend/src/dashboard/components/Header/index.jsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci9pbmRleC5qc3g=) | `59.88% <0.00%> (-9.61%)` | :arrow_down: |
| [superset/commands/importers/v1/examples.py](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL2V4YW1wbGVzLnB5) | `35.44% <0.00%> (-4.10%)` | :arrow_down: |
| ... and [135 more](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5eded9f...d577128](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] m-ajay commented on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
m-ajay commented on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-907278932
@etr2460 @graceguo-supercat Could you please take a look at this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-895530605
# [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16154](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f8e6994) into [master](https://codecov.io/gh/apache/superset/commit/ccfc95fbe68da36f5eebd57421c2f5e57f7226e9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ccfc95f) will **decrease** coverage by `0.03%`.
> The diff coverage is `92.00%`.
> :exclamation: Current head f8e6994 differs from pull request most recent head 2967992. Consider uploading reports for the commit 2967992 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16154 +/- ##
==========================================
- Coverage 76.73% 76.69% -0.04%
==========================================
Files 996 996
Lines 52999 52962 -37
Branches 6738 6736 -2
==========================================
- Hits 40668 40620 -48
- Misses 12102 12117 +15
+ Partials 229 225 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `81.57% <ø> (-0.05%)` | :arrow_down: |
| postgres | `81.59% <ø> (-0.05%)` | :arrow_down: |
| presto | `81.43% <ø> (+<0.01%)` | :arrow_up: |
| python | `81.86% <ø> (-0.29%)` | :arrow_down: |
| sqlite | `81.19% <ø> (-0.09%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.27% <ø> (-0.03%)` | :arrow_down: |
| [...ilters/FilterBar/FilterControls/FilterControls.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlckNvbnRyb2xzLnRzeA==) | `80.00% <75.00%> (ø)` | |
| [...eFilters/FiltersConfigModal/FiltersConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdNb2RhbC50c3g=) | `95.45% <87.50%> (ø)` | |
| [...ts/nativeFilters/FiltersConfigModal/FilterTabs.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlclRhYnMudHN4) | `86.66% <100.00%> (ø)` | |
| [...mponents/nativeFilters/FiltersConfigModal/utils.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL3V0aWxzLnRz) | `73.61% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `69.80% <0.00%> (-16.87%)` | :arrow_down: |
| [...rontend/src/components/ListView/CardCollection.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvQ2FyZENvbGxlY3Rpb24udHN4) | `76.92% <0.00%> (-1.65%)` | :arrow_down: |
| ... and [37 more](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ccfc95f...2967992](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-942493358
@rusackas Ephemeral environment spinning up at http://34.217.68.142:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-895530605
# [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16154](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d3ee2f7) into [master](https://codecov.io/gh/apache/superset/commit/87baac7650bdb6a8f8f82cf4992567a2c5c73cba?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (87baac7) will **decrease** coverage by `0.16%`.
> The diff coverage is `90.19%`.
> :exclamation: Current head d3ee2f7 differs from pull request most recent head 390af33. Consider uploading reports for the commit 390af33 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16154 +/- ##
==========================================
- Coverage 76.97% 76.81% -0.17%
==========================================
Files 1022 1006 -16
Lines 54903 54110 -793
Branches 7485 7332 -153
==========================================
- Hits 42262 41562 -700
+ Misses 12393 12308 -85
+ Partials 248 240 -8
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.35% <ø> (-0.11%)` | :arrow_down: |
| mysql | `81.69% <ø> (-0.16%)` | :arrow_down: |
| postgres | `81.75% <ø> (-0.16%)` | :arrow_down: |
| presto | `?` | |
| python | `82.15% <ø> (-0.27%)` | :arrow_down: |
| sqlite | `81.41% <ø> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nfigModal/FiltersConfigForm/CollapsibleControl.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0NvbGxhcHNpYmxlQ29udHJvbC50c3g=) | `88.46% <0.00%> (ø)` | |
| [...mponents/nativeFilters/FiltersConfigModal/utils.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL3V0aWxzLnRz) | `72.22% <0.00%> (+1.33%)` | :arrow_up: |
| [...nd/src/dashboard/components/nativeFilters/state.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc3RhdGUudHM=) | `75.00% <0.00%> (ø)` | |
| [...nd/src/dashboard/components/nativeFilters/utils.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdXRpbHMudHM=) | `56.25% <ø> (ø)` | |
| [...ilters/FilterBar/FilterControls/FilterControls.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlckNvbnRyb2xzLnRzeA==) | `80.00% <75.00%> (ø)` | |
| [...eFilters/FiltersConfigModal/FiltersConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdNb2RhbC50c3g=) | `94.31% <96.87%> (+5.85%)` | :arrow_up: |
| [...ts/nativeFilters/FiltersConfigModal/FilterTabs.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlclRhYnMudHN4) | `86.66% <100.00%> (ø)` | |
| [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `73.20% <100.00%> (-0.63%)` | :arrow_down: |
| [...nd/src/dashboard/components/nativeFilters/types.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdHlwZXMudHM=) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/components/Select/utils.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3V0aWxzLnRz) | `61.53% <0.00%> (-30.77%)` | :arrow_down: |
| ... and [186 more](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [87baac7...390af33](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-895530605
# [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16154](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f8e6994) into [master](https://codecov.io/gh/apache/superset/commit/019e74652d823a90e09851f443f63aea13980005?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (019e746) will **decrease** coverage by `0.24%`.
> The diff coverage is `66.64%`.
> :exclamation: Current head f8e6994 differs from pull request most recent head 7e988e3. Consider uploading reports for the commit 7e988e3 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16154 +/- ##
==========================================
- Coverage 76.94% 76.69% -0.25%
==========================================
Files 986 996 +10
Lines 51978 52962 +984
Branches 7091 6736 -355
==========================================
+ Hits 39993 40620 +627
- Misses 11759 12117 +358
+ Partials 226 225 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `81.57% <83.40%> (+0.14%)` | :arrow_up: |
| postgres | `81.59% <83.42%> (+0.14%)` | :arrow_up: |
| presto | `81.43% <83.42%> (?)` | |
| python | `81.86% <83.70%> (+0.03%)` | :arrow_up: |
| sqlite | `81.19% <82.13%> (+0.10%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `44.64% <0.00%> (-1.66%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | `37.17% <0.00%> (-0.80%)` | :arrow_down: |
| [...-frontend/src/components/CronPicker/CronPicker.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ3JvblBpY2tlci9Dcm9uUGlja2VyLnRzeA==) | `91.66% <ø> (ø)` | |
| [superset-frontend/src/components/Icons/index.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbnMvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [.../src/components/dataViewCommon/TableCollection.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvZGF0YVZpZXdDb21tb24vVGFibGVDb2xsZWN0aW9uLnRzeA==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/dashboard/actions/hydrate.js](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2h5ZHJhdGUuanM=) | `1.69% <0.00%> (-0.02%)` | :arrow_down: |
| [...rc/dashboard/components/dnd/dragDroppableConfig.js](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9kcmFnRHJvcHBhYmxlQ29uZmlnLmpz) | `31.81% <0.00%> (-3.19%)` | :arrow_down: |
| [...d/src/dashboard/components/gridComponents/Tabs.jsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL1RhYnMuanN4) | `86.48% <0.00%> (-2.41%)` | :arrow_down: |
| [...ters/FiltersConfigModal/FiltersConfigForm/utils.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL3V0aWxzLnRz) | `90.47% <ø> (ø)` | |
| [...nativeFilters/FiltersConfigModal/Footer/Footer.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0Zvb3Rlci9Gb290ZXIudHN4) | `100.00% <ø> (+5.26%)` | :arrow_up: |
| ... and [178 more](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [019e746...7e988e3](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-909634779
@michael-s-molina Ephemeral environment spinning up at http://34.219.162.249:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] m-ajay commented on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
m-ajay commented on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-904933753
> it appears to me that there's some lagging when reordering. could we optimize the perf?
> https://user-images.githubusercontent.com/67837651/130310816-c0157357-55cd-48a3-85ef-df292c97cdd4.mov
@junlincc I would like to know whether it was a production build or development build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-895530605
# [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16154](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d3ee2f7) into [master](https://codecov.io/gh/apache/superset/commit/87baac7650bdb6a8f8f82cf4992567a2c5c73cba?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (87baac7) will **decrease** coverage by `0.16%`.
> The diff coverage is `90.19%`.
> :exclamation: Current head d3ee2f7 differs from pull request most recent head a7602fd. Consider uploading reports for the commit a7602fd to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16154 +/- ##
==========================================
- Coverage 76.97% 76.81% -0.17%
==========================================
Files 1022 1006 -16
Lines 54903 54110 -793
Branches 7485 7332 -153
==========================================
- Hits 42262 41562 -700
+ Misses 12393 12308 -85
+ Partials 248 240 -8
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.35% <ø> (-0.11%)` | :arrow_down: |
| mysql | `81.69% <ø> (-0.16%)` | :arrow_down: |
| postgres | `81.75% <ø> (-0.16%)` | :arrow_down: |
| presto | `?` | |
| python | `82.15% <ø> (-0.27%)` | :arrow_down: |
| sqlite | `81.41% <ø> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nfigModal/FiltersConfigForm/CollapsibleControl.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0NvbGxhcHNpYmxlQ29udHJvbC50c3g=) | `88.46% <0.00%> (ø)` | |
| [...mponents/nativeFilters/FiltersConfigModal/utils.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL3V0aWxzLnRz) | `72.22% <0.00%> (+1.33%)` | :arrow_up: |
| [...nd/src/dashboard/components/nativeFilters/state.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc3RhdGUudHM=) | `75.00% <0.00%> (ø)` | |
| [...nd/src/dashboard/components/nativeFilters/utils.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdXRpbHMudHM=) | `56.25% <ø> (ø)` | |
| [...ilters/FilterBar/FilterControls/FilterControls.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlckNvbnRyb2xzLnRzeA==) | `80.00% <75.00%> (ø)` | |
| [...eFilters/FiltersConfigModal/FiltersConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdNb2RhbC50c3g=) | `94.31% <96.87%> (+5.85%)` | :arrow_up: |
| [...ts/nativeFilters/FiltersConfigModal/FilterTabs.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlclRhYnMudHN4) | `86.66% <100.00%> (ø)` | |
| [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `73.20% <100.00%> (-0.63%)` | :arrow_down: |
| [...nd/src/dashboard/components/nativeFilters/types.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdHlwZXMudHM=) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/components/Select/utils.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3V0aWxzLnRz) | `61.53% <0.00%> (-30.77%)` | :arrow_down: |
| ... and [186 more](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [87baac7...a7602fd](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-895530605
# [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16154](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d3ee2f7) into [master](https://codecov.io/gh/apache/superset/commit/519baa6f005a67c13ab13ad4bc2776f73afabed0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (519baa6) will **increase** coverage by `0.03%`.
> The diff coverage is `90.19%`.
> :exclamation: Current head d3ee2f7 differs from pull request most recent head 0838192. Consider uploading reports for the commit 0838192 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16154 +/- ##
==========================================
+ Coverage 76.77% 76.81% +0.03%
==========================================
Files 1003 1006 +3
Lines 53959 54110 +151
Branches 7330 7332 +2
==========================================
+ Hits 41427 41562 +135
- Misses 12293 12308 +15
- Partials 239 240 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.35% <ø> (+0.23%)` | :arrow_up: |
| mysql | `81.69% <ø> (+0.15%)` | :arrow_up: |
| postgres | `81.75% <ø> (+0.15%)` | :arrow_up: |
| presto | `?` | |
| python | `82.15% <ø> (+0.04%)` | :arrow_up: |
| sqlite | `81.41% <ø> (+0.19%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nfigModal/FiltersConfigForm/CollapsibleControl.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0NvbGxhcHNpYmxlQ29udHJvbC50c3g=) | `88.46% <0.00%> (ø)` | |
| [...mponents/nativeFilters/FiltersConfigModal/utils.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL3V0aWxzLnRz) | `72.22% <0.00%> (-1.39%)` | :arrow_down: |
| [...nd/src/dashboard/components/nativeFilters/state.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc3RhdGUudHM=) | `75.00% <0.00%> (ø)` | |
| [...nd/src/dashboard/components/nativeFilters/utils.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdXRpbHMudHM=) | `56.25% <ø> (ø)` | |
| [...ilters/FilterBar/FilterControls/FilterControls.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlckNvbnRyb2xzLnRzeA==) | `80.00% <75.00%> (ø)` | |
| [...eFilters/FiltersConfigModal/FiltersConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdNb2RhbC50c3g=) | `94.31% <96.87%> (-1.14%)` | :arrow_down: |
| [...ts/nativeFilters/FiltersConfigModal/FilterTabs.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlclRhYnMudHN4) | `86.66% <100.00%> (ø)` | |
| [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `73.20% <100.00%> (+0.07%)` | :arrow_up: |
| [...nd/src/dashboard/components/nativeFilters/types.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdHlwZXMudHM=) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `84.51% <0.00%> (-5.86%)` | :arrow_down: |
| ... and [57 more](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [519baa6...0838192](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-895530605
# [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16154](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cb6bec8) into [master](https://codecov.io/gh/apache/superset/commit/93ebe3d963c857ccc4185ef3ca5c6175397e17c9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (93ebe3d) will **decrease** coverage by `0.33%`.
> The diff coverage is `76.63%`.
> :exclamation: Current head cb6bec8 differs from pull request most recent head 00c020c. Consider uploading reports for the commit 00c020c to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16154 +/- ##
==========================================
- Coverage 76.93% 76.59% -0.34%
==========================================
Files 1030 1033 +3
Lines 55019 55188 +169
Branches 7465 7499 +34
==========================================
- Hits 42331 42274 -57
- Misses 12434 12664 +230
+ Partials 254 250 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `70.24% <76.63%> (-0.68%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ilters/FilterBar/FilterControls/FilterControls.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlckNvbnRyb2xzLnRzeA==) | `26.66% <0.00%> (-53.34%)` | :arrow_down: |
| [...nd/src/dashboard/components/nativeFilters/state.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc3RhdGUudHM=) | `26.31% <0.00%> (-48.69%)` | :arrow_down: |
| [...ilters/FiltersConfigModal/FilterTitleContainer.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlclRpdGxlQ29udGFpbmVyLnRzeA==) | `57.69% <57.69%> (ø)` | |
| [...mponents/nativeFilters/FiltersConfigModal/utils.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL3V0aWxzLnRz) | `69.10% <63.04%> (-1.79%)` | :arrow_down: |
| [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `73.71% <78.57%> (-0.13%)` | :arrow_down: |
| [...eFilters/FiltersConfigModal/FiltersConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdNb2RhbC50c3g=) | `88.02% <86.53%> (-1.40%)` | :arrow_down: |
| [...tiveFilters/FiltersConfigModal/FilterTitlePane.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlclRpdGxlUGFuZS50c3g=) | `90.90% <90.90%> (ø)` | |
| [...tiveFilters/FiltersConfigModal/DraggableFilter.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0RyYWdnYWJsZUZpbHRlci50c3g=) | `92.10% <92.10%> (ø)` | |
| [...Filters/FiltersConfigModal/FilterConfigurePane.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlckNvbmZpZ3VyZVBhbmUudHN4) | `100.00% <100.00%> (ø)` | |
| [...odal/FiltersConfigForm/FilterScope/FilterScope.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL0ZpbHRlclNjb3BlLnRzeA==) | `89.13% <100.00%> (+0.24%)` | :arrow_up: |
| ... and [18 more](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [93ebe3d...00c020c](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat edited a comment on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
graceguo-supercat edited a comment on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-909743589
Thanks @michael-s-molina and @m-ajay I also played a little bit, here is my feedback:
1. only parent (top level filters) are shown in the filters list
2. In the edit mode, nested filters are also dragable and could be reordered. But there is no use to do this change, since nested filters don't show up in the filters list. In my opinion, we should probably not offer any action that is no use :)
I understand we want to allow user fully control the nested filter so we show them as first-class filter component. But make user move them up and down do not make sense to me. So my suggestion is:
- make child filter always next to parent filter,
- when user moves parent filter, children should be moved along,
- children (nested filters) itself, should not be dragable or rearrangeable.
@m-ajay @michael-s-molina @junlincc please let me know your opinion about this behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-895530605
# [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16154](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (00c020c) into [master](https://codecov.io/gh/apache/superset/commit/93ebe3d963c857ccc4185ef3ca5c6175397e17c9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (93ebe3d) will **decrease** coverage by `0.33%`.
> The diff coverage is `77.25%`.
> :exclamation: Current head 00c020c differs from pull request most recent head 5ba6717. Consider uploading reports for the commit 5ba6717 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16154 +/- ##
==========================================
- Coverage 76.93% 76.60% -0.34%
==========================================
Files 1030 1033 +3
Lines 55019 55199 +180
Branches 7465 7502 +37
==========================================
- Hits 42331 42283 -48
- Misses 12434 12666 +232
+ Partials 254 250 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `70.25% <77.25%> (-0.67%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ilters/FilterBar/FilterConfigurationLink/index.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbmZpZ3VyYXRpb25MaW5rL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...ilters/FilterBar/FilterControls/FilterControls.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlckNvbnRyb2xzLnRzeA==) | `26.66% <0.00%> (-53.34%)` | :arrow_down: |
| [...nd/src/dashboard/components/nativeFilters/state.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc3RhdGUudHM=) | `26.78% <0.00%> (-48.22%)` | :arrow_down: |
| [...ilters/FiltersConfigModal/FilterTitleContainer.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlclRpdGxlQ29udGFpbmVyLnRzeA==) | `57.69% <57.69%> (ø)` | |
| [...mponents/nativeFilters/FiltersConfigModal/utils.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL3V0aWxzLnRz) | `68.54% <61.70%> (-2.34%)` | :arrow_down: |
| [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `73.71% <78.57%> (-0.13%)` | :arrow_down: |
| [...eFilters/FiltersConfigModal/FiltersConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdNb2RhbC50c3g=) | `88.27% <87.50%> (-1.15%)` | :arrow_down: |
| [...tiveFilters/FiltersConfigModal/FilterTitlePane.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlclRpdGxlUGFuZS50c3g=) | `92.00% <92.00%> (ø)` | |
| [...tiveFilters/FiltersConfigModal/DraggableFilter.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0RyYWdnYWJsZUZpbHRlci50c3g=) | `92.10% <92.10%> (ø)` | |
| [...omponents/nativeFilters/FilterBar/Header/index.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0hlYWRlci9pbmRleC50c3g=) | `97.05% <100.00%> (-2.95%)` | :arrow_down: |
| ... and [39 more](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [93ebe3d...5ba6717](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina edited a comment on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
michael-s-molina edited a comment on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-938138868
The text and grab icon are not vertically aligned with the trash icon (center):
<img width="244" alt="Screen Shot 2021-10-07 at 5 37 43 PM" src="https://user-images.githubusercontent.com/70410625/136458535-70875cd7-a6b7-47a9-9502-7a7fc140a1da.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-931311793
@m-ajay This [PR](https://github.com/apache/superset/pull/16919) contains the drag icon. You also need to adjust the cursor accordingly (grab, grabbing).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] etr2460 commented on a change in pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #16154:
URL: https://github.com/apache/superset/pull/16154#discussion_r722781566
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBar.test.tsx
##########
@@ -88,7 +88,6 @@ const addFilterFlow = async () => {
userEvent.click(screen.getByText('Time range'));
userEvent.type(screen.getByTestId(getModalTestId('name-input')), FILTER_NAME);
userEvent.click(screen.getByText('Save'));
- await screen.findByText('All Filters (1)');
Review comment:
should this be removed?
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterTitleContainer.tsx
##########
@@ -0,0 +1,166 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { styled, t } from '@superset-ui/core';
+import Icons from 'src/components/Icons';
+import { FilterRemoval } from './types';
+import DraggableFilter from './DraggableFilter';
+
+const FilterTitle = styled.div`
+ ${({ theme }) => `
+ display: flex;
+ padding: ${theme.gridUnit * 2}px;
+ width: 100%;
+ border-radius: ${theme.borderRadius}px;
+ &.active {
+ color: ${theme.colors.grayscale.dark1};
+ border-radius: ${theme.borderRadius}px;
+ background-color: ${theme.colors.secondary.light4};
+ span, .anticon {
+ color: ${theme.colors.grayscale.dark1};
+ }
+ }
+ &:hover {
+ color: ${theme.colors.primary.light1};
+ span, .anticon {
+ color: ${theme.colors.primary.light1};
+ }
+ }
+`}
+`;
+
+const StyledTrashIcon = styled(Icons.Trash)`
+ color: ${({ theme }) => theme.colors.grayscale.light3};
+`;
+const Container = styled.div`
+ height: 100%;
+ overflow-y: auto;
+`;
+
+interface Props {
+ getFilterTitle: (filterId: string) => string;
+ onChange: (filterId: string) => void;
+ currentFilterId: string;
+ removedFilters: Record<string, FilterRemoval>;
+ onRemove: (id: string) => void;
+ restoreFilter: (id: string) => void;
+ onRearrage: (dragIndex: number, targetIndex: number) => void;
+ filterGroups: string[][];
+}
+
+const FilterTitleContainer: React.FC<Props> = ({
+ getFilterTitle,
+ onChange,
+ currentFilterId,
+ removedFilters,
+ onRemove,
+ restoreFilter,
+ onRearrage,
+ filterGroups,
+}) => {
+ const renderComponent = (id: string) => {
+ const isRemoved = !!removedFilters[id];
+ return (
+ <FilterTitle
+ role="tab"
+ key={`filter-title-tab-${id}`}
+ onClick={() => onChange(id)}
+ className={currentFilterId === id ? 'active' : ''}
+ >
+ <div css={{ display: 'flex', width: '100%' }}>
+ <div>{isRemoved ? t('(Removed)') : getFilterTitle(id)}</div>
+ {isRemoved && (
+ <span
+ css={{ alignSelf: 'flex-end', marginLeft: 'auto' }}
+ role="button"
+ data-test="undo-button"
+ tabIndex={0}
+ onClick={e => {
+ e.preventDefault();
+ restoreFilter(id);
+ }}
+ >
+ {t('Undo?')}
+ </span>
+ )}
+ </div>
+ <div css={{ alignSelf: 'flex-end', marginLeft: 'auto' }}>
+ {isRemoved ? (
+ <></>
Review comment:
why do we need an empty fragment? I assume `null` would be fine?
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterTitleContainer.tsx
##########
@@ -0,0 +1,166 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { styled, t } from '@superset-ui/core';
+import Icons from 'src/components/Icons';
+import { FilterRemoval } from './types';
+import DraggableFilter from './DraggableFilter';
+
+const FilterTitle = styled.div`
+ ${({ theme }) => `
+ display: flex;
+ padding: ${theme.gridUnit * 2}px;
+ width: 100%;
+ border-radius: ${theme.borderRadius}px;
+ &.active {
+ color: ${theme.colors.grayscale.dark1};
+ border-radius: ${theme.borderRadius}px;
+ background-color: ${theme.colors.secondary.light4};
+ span, .anticon {
+ color: ${theme.colors.grayscale.dark1};
+ }
+ }
+ &:hover {
+ color: ${theme.colors.primary.light1};
+ span, .anticon {
+ color: ${theme.colors.primary.light1};
+ }
+ }
+`}
+`;
+
+const StyledTrashIcon = styled(Icons.Trash)`
+ color: ${({ theme }) => theme.colors.grayscale.light3};
+`;
+const Container = styled.div`
+ height: 100%;
+ overflow-y: auto;
+`;
+
+interface Props {
+ getFilterTitle: (filterId: string) => string;
+ onChange: (filterId: string) => void;
+ currentFilterId: string;
+ removedFilters: Record<string, FilterRemoval>;
+ onRemove: (id: string) => void;
+ restoreFilter: (id: string) => void;
+ onRearrage: (dragIndex: number, targetIndex: number) => void;
+ filterGroups: string[][];
+}
+
+const FilterTitleContainer: React.FC<Props> = ({
+ getFilterTitle,
+ onChange,
+ currentFilterId,
+ removedFilters,
+ onRemove,
+ restoreFilter,
+ onRearrage,
+ filterGroups,
+}) => {
+ const renderComponent = (id: string) => {
+ const isRemoved = !!removedFilters[id];
+ return (
+ <FilterTitle
+ role="tab"
+ key={`filter-title-tab-${id}`}
+ onClick={() => onChange(id)}
+ className={currentFilterId === id ? 'active' : ''}
+ >
+ <div css={{ display: 'flex', width: '100%' }}>
+ <div>{isRemoved ? t('(Removed)') : getFilterTitle(id)}</div>
+ {isRemoved && (
+ <span
+ css={{ alignSelf: 'flex-end', marginLeft: 'auto' }}
+ role="button"
+ data-test="undo-button"
+ tabIndex={0}
+ onClick={e => {
+ e.preventDefault();
+ restoreFilter(id);
+ }}
+ >
+ {t('Undo?')}
+ </span>
+ )}
+ </div>
+ <div css={{ alignSelf: 'flex-end', marginLeft: 'auto' }}>
+ {isRemoved ? (
+ <></>
+ ) : (
+ <StyledTrashIcon
+ onClick={event => {
+ event.stopPropagation();
+ onRemove(id);
+ }}
+ alt="RemoveFilter"
+ />
+ )}
+ </div>
+ </FilterTitle>
+ );
+ };
+ const recursivelyRender = (
+ elementId: string,
+ nodeList: Array<{ id: string; parentId: string | null }>,
+ rendered: Array<string>,
+ ): React.ReactNode => {
+ const didAlreadyRender = rendered.indexOf(elementId) >= 0;
+ if (didAlreadyRender) {
+ return null;
+ }
+ let parent = null;
+ const element = nodeList.filter(el => el.id === elementId)[0];
+ if (!element) {
+ // eslint-disable-next-line no-console
+ console.warn(`Could not find filter with ID ${elementId}`);
Review comment:
let's clean up the console logs before merging?
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterTitlePane.tsx
##########
@@ -0,0 +1,127 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { PlusOutlined } from '@ant-design/icons';
+import { styled, t, useTheme } from '@superset-ui/core';
+import React from 'react';
+import FilterTitleContainer from './FilterTitleContainer';
+import { FilterRemoval } from './types';
+
+interface Props {
+ removedFilters: Record<string, FilterRemoval>;
+ restoreFilter: (id: string) => void;
+ getFilterTitle: (id: string) => string;
+ onRearrage: (dragIndex: number, targetIndex: number) => void;
+ onRemove: (id: string) => void;
+ currentFilterId: string;
+ onChange: (id: string) => void;
+ onEdit: (filterId: string, action: 'add' | 'remove') => void;
+ filterGroups: string[][];
+}
+
+const StyledHeader = styled.div`
+ ${({ theme }) => `
+ color: ${theme.colors.grayscale.dark1};
+ font-size: ${theme.typography.sizes.l}px;
+ padding-top: ${theme.gridUnit * 4}px;
+ padding-right: ${theme.gridUnit * 4}px;
+ padding-left: ${theme.gridUnit * 4}px;
+ padding-bottom: ${theme.gridUnit * 2}px;
+ `}
+`;
+
+const TabsContainer = styled.div`
+ height: 100%;
+ display: flex;
+ flex-direction: column;
+`;
+
+const StyledAddFilterBox = styled.div`
+ color: ${({ theme }) => theme.colors.primary.dark1};
+ padding: ${({ theme }) => theme.gridUnit * 2}px;
+ border-top: 1px solid ${({ theme }) => theme.colors.grayscale.light2};
+ cursor: pointer;
+ margin-top: auto;
+ &:hover {
+ color: ${({ theme }) => theme.colors.primary.base};
+ }
+`;
+
+const FilterTitlePane: React.FC<Props> = ({
+ getFilterTitle,
+ onChange,
+ onEdit,
+ onRemove,
+ onRearrage,
+ restoreFilter,
+ currentFilterId,
+ filterGroups,
+ removedFilters,
+}) => {
+ const theme = useTheme();
+ return (
+ <>
Review comment:
fragment is unneeded
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControls.tsx
##########
@@ -95,7 +95,13 @@ const FilterControls: FC<FilterControlsProps> = ({
))}
{filtersInScope.map(filter => {
const index = filterValues.findIndex(f => f.id === filter.id);
- return <portals.OutPortal node={portalNodes[index]} inView />;
+ return (
+ <portals.OutPortal
Review comment:
nit, i find it prettier to `import { OutPortal } from 'portals'` and use it like that in react components
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-933677084
/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #16154:
URL: https://github.com/apache/superset/pull/16154#discussion_r724522369
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/DraggableFilter.tsx
##########
@@ -0,0 +1,138 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { styled } from '@superset-ui/core';
+import React, { useRef } from 'react';
+import {
+ DragSourceMonitor,
+ DropTargetMonitor,
+ useDrag,
+ useDrop,
+ XYCoord,
+} from 'react-dnd';
+import Icons, { IconType } from 'src/components/Icons';
+
+interface TitleContainerProps {
+ readonly isDragging: boolean;
+}
+const FILTER_TYPE = 'FILTER';
+
+const Container = styled.div<TitleContainerProps>`
+ ${({ isDragging, theme }) => `
+ opacity: ${isDragging ? 0.3 : 1};
+ cursor: ${isDragging ? 'grabbing' : 'pointer'};
+ width: 100%;
+ display: flex;
+ padding: ${theme.gridUnit}px
+`}
Review comment:
```suggestion
`}
```
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterTitleContainer.tsx
##########
@@ -0,0 +1,162 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { styled, t } from '@superset-ui/core';
+import Icons from 'src/components/Icons';
+import { FilterRemoval } from './types';
+import DraggableFilter from './DraggableFilter';
+
+const FilterTitle = styled.div`
+ ${({ theme }) => `
+ display: flex;
+ padding: ${theme.gridUnit * 2}px;
+ width: 100%;
+ border-radius: ${theme.borderRadius}px;
+ &.active {
+ color: ${theme.colors.grayscale.dark1};
+ border-radius: ${theme.borderRadius}px;
+ background-color: ${theme.colors.secondary.light4};
+ span, .anticon {
+ color: ${theme.colors.grayscale.dark1};
+ }
+ }
+ &:hover {
+ color: ${theme.colors.primary.light1};
+ span, .anticon {
+ color: ${theme.colors.primary.light1};
+ }
+ }
+`}
Review comment:
```suggestion
`}
```
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/DraggableFilter.tsx
##########
@@ -0,0 +1,138 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { styled } from '@superset-ui/core';
+import React, { useRef } from 'react';
+import {
+ DragSourceMonitor,
+ DropTargetMonitor,
+ useDrag,
+ useDrop,
+ XYCoord,
+} from 'react-dnd';
+import Icons, { IconType } from 'src/components/Icons';
+
+interface TitleContainerProps {
+ readonly isDragging: boolean;
+}
+const FILTER_TYPE = 'FILTER';
+
+const Container = styled.div<TitleContainerProps>`
+ ${({ isDragging, theme }) => `
+ opacity: ${isDragging ? 0.3 : 1};
+ cursor: ${isDragging ? 'grabbing' : 'pointer'};
+ width: 100%;
+ display: flex;
+ padding: ${theme.gridUnit}px
+`}
+`;
+
+const DragIcon = styled(Icons.Drag)<IconType & { isDragging: boolean }>`
+ ${({ isDragging, theme }) => `
+ font-size: ${theme.typography.sizes.m}px;
+ margin-top: 12px;
+ cursor: ${isDragging ? 'grabbing' : 'grab'};
+ padding-left: ${theme.gridUnit}px;
+`}
Review comment:
```suggestion
`}
```
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterConfigPane.test.tsx
##########
@@ -0,0 +1,103 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { dashboardLayout } from 'spec/fixtures/mockDashboardLayout';
+import { buildNativeFilter } from 'spec/fixtures/mockNativeFilters';
+import { render, screen, fireEvent } from 'spec/helpers/testing-library';
+import FilterConfigPane from './FilterConfigurePane';
+
+const defaultProps = {
+ children: jest.fn(),
+ getFilterTitle: (id: string) => id,
+ onChange: jest.fn(),
+ onEdit: jest.fn(),
+ onRearrange: jest.fn(),
+ restoreFilter: jest.fn(),
+ currentFilterId: 'NATIVE_FILTER-1',
+ filterGroups: [['NATIVE_FILTER-2', 'NATIVE_FILTER-1'], ['NATIVE_FILTER-3']],
+ removedFilters: {},
+};
+const defaultState = {
+ dashboardInfo: {
+ metadata: {
+ native_filter_configuration: [
+ buildNativeFilter('NATIVE_FILTER-1', 'state', ['NATIVE_FILTER-2']),
+ buildNativeFilter('NATIVE_FILTER-2', 'country', []),
+ buildNativeFilter('NATIVE_FILTER-3', 'product', []),
+ ],
+ },
+ },
+ dashboardLayout,
+};
+
+function defaultRender(initialState: any = defaultState, props = defaultProps) {
+ return render(<FilterConfigPane {...props} />, {
+ initialState,
+ useDnd: true,
+ useRedux: true,
+ });
+}
+
+test('renders form', async () => {
+ defaultRender();
+ expect(defaultProps.children).toHaveBeenCalledTimes(3);
+});
+test('drag and drop', async () => {
Review comment:
```suggestion
});
test('drag and drop', async () => {
```
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControls.tsx
##########
@@ -17,16 +17,20 @@
* under the License.
*/
import React, { FC, useMemo, useState } from 'react';
-import { DataMask, styled, t } from '@superset-ui/core';
import { css } from '@emotion/react';
-import * as portals from 'react-reverse-portal';
-import { DataMaskStateWithId } from 'src/dataMask/types';
+import { DataMask, styled, t } from '@superset-ui/core';
+import {
+ createHtmlPortalNode,
+ InPortal,
+ OutPortal,
+} from 'react-reverse-portal';
import { Collapse } from 'src/common/components';
+import { DataMaskStateWithId } from 'src/dataMask/types';
+import { useDashboardHasTabs, useSelectFiltersInScope } from '../../state';
+import { Filter } from '../../types';
Review comment:
```suggestion
import {
useDashboardHasTabs,
useSelectFiltersInScope,
} from 'src/dashboard/components/nativeFilters/state';
import { Filter } from 'src/dashboard/components/nativeFilters/types';
```
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterConfigurePane.tsx
##########
@@ -0,0 +1,94 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { styled } from '@superset-ui/core';
+import React from 'react';
+import FilterTitlePane from './FilterTitlePane';
+import { FilterRemoval } from './types';
+
+interface Props {
+ children: (filterId: string) => React.ReactNode;
+ getFilterTitle: (filterId: string) => string;
+ onChange: (activeKey: string) => void;
+ onEdit: (filterId: string, action: 'add' | 'remove') => void;
+ onRearrange: (dragIndex: number, targetIndex: number) => void;
+ restoreFilter: (id: string) => void;
+ currentFilterId: string;
+ filterGroups: string[][];
+ removedFilters: Record<string, FilterRemoval>;
+}
+
+const Container = styled.div`
+ display: flex;
+ height: 100%;
+`;
+const ContentHolder = styled.div`
Review comment:
```suggestion
`;
const ContentHolder = styled.div`
```
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx
##########
@@ -92,19 +92,25 @@ import {
} from '../FiltersConfigModal';
import DatasetSelect from './DatasetSelect';
-const { TabPane } = Tabs;
+const TabPane = styled(Tabs.TabPane)`
+ padding: ${({ theme }) => theme.gridUnit * 4}px 0px;
+`;
const StyledContainer = styled.div`
+ ${({ theme }) => `
display: flex;
flex-direction: row-reverse;
justify-content: space-between;
+ padding: 0px ${theme.gridUnit * 4}px;
+`}
Review comment:
```suggestion
${({ theme }) => `
display: flex;
flex-direction: row-reverse;
justify-content: space-between;
padding: 0px ${theme.gridUnit * 4}px;
`}
```
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterConfigurePane.tsx
##########
@@ -0,0 +1,94 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { styled } from '@superset-ui/core';
+import React from 'react';
+import FilterTitlePane from './FilterTitlePane';
+import { FilterRemoval } from './types';
+
+interface Props {
+ children: (filterId: string) => React.ReactNode;
+ getFilterTitle: (filterId: string) => string;
+ onChange: (activeKey: string) => void;
+ onEdit: (filterId: string, action: 'add' | 'remove') => void;
+ onRearrange: (dragIndex: number, targetIndex: number) => void;
+ restoreFilter: (id: string) => void;
+ currentFilterId: string;
+ filterGroups: string[][];
+ removedFilters: Record<string, FilterRemoval>;
+}
+
+const Container = styled.div`
+ display: flex;
+ height: 100%;
+`;
+const ContentHolder = styled.div`
+ flex-grow: 3;
+ margin-left: ${({ theme }) => theme.gridUnit * -1 - 1};
+`;
+const TitlesContainer = styled.div`
+ width: 270px;
+ border-right: 1px solid ${({ theme }) => theme.colors.grayscale.light2};
+`;
+
+const FiltureConfigurePane: React.FC<Props> = ({
+ getFilterTitle,
+ onChange,
+ onEdit,
+ onRearrange,
+ restoreFilter,
+ children,
+ currentFilterId,
+ filterGroups,
+ removedFilters,
+}) => {
+ const active = filterGroups.flat().filter(id => id === currentFilterId)[0];
+ return (
+ <Container>
+ <TitlesContainer>
+ <FilterTitlePane
+ currentFilterId={currentFilterId}
+ filterGroups={filterGroups}
+ getFilterTitle={getFilterTitle}
+ onChange={onChange}
+ onEdit={onEdit}
+ onRearrage={onRearrange}
+ onRemove={(id: string) => onEdit(id, 'remove')}
+ removedFilters={removedFilters}
+ restoreFilter={restoreFilter}
+ />
+ </TitlesContainer>
+ <ContentHolder>
+ {filterGroups.flat().map(id => (
+ <div
+ key={id}
+ style={{
+ height: '100%',
+ overflowY: 'scroll',
Review comment:
```suggestion
overflowY: 'auto',
```
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterConfigurePane.tsx
##########
@@ -0,0 +1,94 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { styled } from '@superset-ui/core';
+import React from 'react';
+import FilterTitlePane from './FilterTitlePane';
+import { FilterRemoval } from './types';
+
+interface Props {
+ children: (filterId: string) => React.ReactNode;
+ getFilterTitle: (filterId: string) => string;
+ onChange: (activeKey: string) => void;
+ onEdit: (filterId: string, action: 'add' | 'remove') => void;
+ onRearrange: (dragIndex: number, targetIndex: number) => void;
+ restoreFilter: (id: string) => void;
+ currentFilterId: string;
+ filterGroups: string[][];
+ removedFilters: Record<string, FilterRemoval>;
+}
+
+const Container = styled.div`
+ display: flex;
+ height: 100%;
+`;
+const ContentHolder = styled.div`
+ flex-grow: 3;
+ margin-left: ${({ theme }) => theme.gridUnit * -1 - 1};
+`;
+const TitlesContainer = styled.div`
Review comment:
```suggestion
`;
const TitlesContainer = styled.div`
```
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterConfigPane.test.tsx
##########
@@ -0,0 +1,103 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { dashboardLayout } from 'spec/fixtures/mockDashboardLayout';
+import { buildNativeFilter } from 'spec/fixtures/mockNativeFilters';
+import { render, screen, fireEvent } from 'spec/helpers/testing-library';
+import FilterConfigPane from './FilterConfigurePane';
+
+const defaultProps = {
Review comment:
These new tests are generating async-related warnings. We should make sure that new tests don't throw warnings.
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal.tsx
##########
@@ -249,28 +279,69 @@ export function FiltersConfigModal({
const handleCancel = () => {
const changed = form.getFieldValue('changed');
- if (unsavedFiltersIds.length > 0 || form.isFieldsTouched() || changed) {
+ const initialOrder = buildFilterGroup(getInitialFilterHierarchy()).flat();
+ const didChangeOrder =
+ orderedFilters.flat().length !== initialOrder.length ||
+ orderedFilters.flat().some((val, index) => val !== initialOrder[index]);
+ if (
+ unsavedFiltersIds.length > 0 ||
+ form.isFieldsTouched() ||
+ changed ||
+ didChangeOrder
+ ) {
setSaveAlertVisible(true);
} else {
handleConfirmCancel();
}
};
+ const onRearrage = (dragIndex: number, targetIndex: number) => {
+ const newOrderedFilter = orderedFilters.map(group => [...group]);
+
+ const removed = newOrderedFilter.splice(dragIndex, 1)[0];
+ newOrderedFilter.splice(targetIndex, 0, removed);
+ setOrderedFilters(newOrderedFilter);
+ };
+ const handleFilterHierarchyChange = useCallback(
+ (filterId: string, parentFilter?: { value: string; label: string }) => {
+ const index = filterHierarchy.findIndex(item => item.id === filterId);
+ const newState = [...filterHierarchy];
+ newState.splice(index, 1, {
+ id: filterId,
+ parentId: parentFilter ? parentFilter.value : null,
+ });
+ setFilterHierarchy(newState);
+ setOrderedFilters(buildFilterGroup(newState));
+ },
+ [setFilterHierarchy, setOrderedFilters, filterHierarchy],
+ );
const onValuesChange = useMemo(
- () =>
- debounce((changes: any, values: NativeFiltersForm) => {
Review comment:
We shouldn't remove the `debounce` here.
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterTitleContainer.tsx
##########
@@ -0,0 +1,162 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { styled, t } from '@superset-ui/core';
+import Icons from 'src/components/Icons';
+import { FilterRemoval } from './types';
+import DraggableFilter from './DraggableFilter';
+
+const FilterTitle = styled.div`
+ ${({ theme }) => `
+ display: flex;
+ padding: ${theme.gridUnit * 2}px;
+ width: 100%;
+ border-radius: ${theme.borderRadius}px;
+ &.active {
+ color: ${theme.colors.grayscale.dark1};
+ border-radius: ${theme.borderRadius}px;
+ background-color: ${theme.colors.secondary.light4};
+ span, .anticon {
+ color: ${theme.colors.grayscale.dark1};
+ }
+ }
+ &:hover {
+ color: ${theme.colors.primary.light1};
+ span, .anticon {
+ color: ${theme.colors.primary.light1};
+ }
+ }
+`}
+`;
+
+const StyledTrashIcon = styled(Icons.Trash)`
+ color: ${({ theme }) => theme.colors.grayscale.light3};
+`;
+const Container = styled.div`
Review comment:
```suggestion
`;
const Container = styled.div`
```
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterConfigurePane.tsx
##########
@@ -0,0 +1,94 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { styled } from '@superset-ui/core';
+import React from 'react';
+import FilterTitlePane from './FilterTitlePane';
+import { FilterRemoval } from './types';
+
+interface Props {
+ children: (filterId: string) => React.ReactNode;
+ getFilterTitle: (filterId: string) => string;
+ onChange: (activeKey: string) => void;
+ onEdit: (filterId: string, action: 'add' | 'remove') => void;
+ onRearrange: (dragIndex: number, targetIndex: number) => void;
+ restoreFilter: (id: string) => void;
+ currentFilterId: string;
+ filterGroups: string[][];
+ removedFilters: Record<string, FilterRemoval>;
+}
+
+const Container = styled.div`
+ display: flex;
+ height: 100%;
+`;
+const ContentHolder = styled.div`
+ flex-grow: 3;
+ margin-left: ${({ theme }) => theme.gridUnit * -1 - 1};
+`;
+const TitlesContainer = styled.div`
+ width: 270px;
+ border-right: 1px solid ${({ theme }) => theme.colors.grayscale.light2};
+`;
+
+const FiltureConfigurePane: React.FC<Props> = ({
+ getFilterTitle,
+ onChange,
+ onEdit,
+ onRearrange,
+ restoreFilter,
+ children,
+ currentFilterId,
+ filterGroups,
+ removedFilters,
+}) => {
+ const active = filterGroups.flat().filter(id => id === currentFilterId)[0];
+ return (
+ <Container>
+ <TitlesContainer>
+ <FilterTitlePane
+ currentFilterId={currentFilterId}
+ filterGroups={filterGroups}
+ getFilterTitle={getFilterTitle}
+ onChange={onChange}
+ onEdit={onEdit}
+ onRearrage={onRearrange}
+ onRemove={(id: string) => onEdit(id, 'remove')}
+ removedFilters={removedFilters}
+ restoreFilter={restoreFilter}
+ />
+ </TitlesContainer>
+ <ContentHolder>
+ {filterGroups.flat().map(id => (
+ <div
+ key={id}
+ style={{
+ height: '100%',
+ overflowY: 'scroll',
Review comment:
This one is important to avoid showing the right panel scroll when the content fits on the screen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #16154:
URL: https://github.com/apache/superset/pull/16154#discussion_r728875706
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterConfigPane.test.tsx
##########
@@ -0,0 +1,103 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { dashboardLayout } from 'spec/fixtures/mockDashboardLayout';
+import { buildNativeFilter } from 'spec/fixtures/mockNativeFilters';
+import { render, screen, fireEvent } from 'spec/helpers/testing-library';
+import FilterConfigPane from './FilterConfigurePane';
+
+const defaultProps = {
Review comment:
We still have this warning:
`Warning: React does not recognize the isDragging prop on a DOM element.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-899794691
@michael-s-molina Ephemeral environment spinning up at http://54.218.199.88:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-910215838
@graceguo-supercat I agree with your points. We just need to make sure that the order is updated when setting the parent.
We could also do something like this to clearly indicate to the user which filters are draggable and also to help with the visual group separation:
<img width="230" alt="Screen Shot 2021-09-01 at 8 53 55 AM" src="https://user-images.githubusercontent.com/70410625/131667081-60ac8b86-de7c-41b0-80b8-e49c200f1288.png">
It would be nice if the drag animation shows the whole group being dragged. If the group is big we could limit the animation to the first 3 and add `...`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-909634779
@michael-s-molina Ephemeral environment spinning up at http://34.219.162.249:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] m-ajay commented on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
m-ajay commented on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-896288526
@jinghua-qa Thanks for testing. It happens when we newly add filters and try re-arrange them. I have fixed it now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-895593521
/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-895530605
# [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16154](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d3ee2f7) into [master](https://codecov.io/gh/apache/superset/commit/87baac7650bdb6a8f8f82cf4992567a2c5c73cba?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (87baac7) will **decrease** coverage by `0.16%`.
> The diff coverage is `90.19%`.
> :exclamation: Current head d3ee2f7 differs from pull request most recent head 33fa6f3. Consider uploading reports for the commit 33fa6f3 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16154 +/- ##
==========================================
- Coverage 76.97% 76.81% -0.17%
==========================================
Files 1022 1006 -16
Lines 54903 54110 -793
Branches 7485 7332 -153
==========================================
- Hits 42262 41562 -700
+ Misses 12393 12308 -85
+ Partials 248 240 -8
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.35% <ø> (-0.11%)` | :arrow_down: |
| mysql | `81.69% <ø> (-0.16%)` | :arrow_down: |
| postgres | `81.75% <ø> (-0.16%)` | :arrow_down: |
| presto | `?` | |
| python | `82.15% <ø> (-0.27%)` | :arrow_down: |
| sqlite | `81.41% <ø> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nfigModal/FiltersConfigForm/CollapsibleControl.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0NvbGxhcHNpYmxlQ29udHJvbC50c3g=) | `88.46% <0.00%> (ø)` | |
| [...mponents/nativeFilters/FiltersConfigModal/utils.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL3V0aWxzLnRz) | `72.22% <0.00%> (+1.33%)` | :arrow_up: |
| [...nd/src/dashboard/components/nativeFilters/state.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc3RhdGUudHM=) | `75.00% <0.00%> (ø)` | |
| [...nd/src/dashboard/components/nativeFilters/utils.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdXRpbHMudHM=) | `56.25% <ø> (ø)` | |
| [...ilters/FilterBar/FilterControls/FilterControls.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlckNvbnRyb2xzLnRzeA==) | `80.00% <75.00%> (ø)` | |
| [...eFilters/FiltersConfigModal/FiltersConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdNb2RhbC50c3g=) | `94.31% <96.87%> (+5.85%)` | :arrow_up: |
| [...ts/nativeFilters/FiltersConfigModal/FilterTabs.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlclRhYnMudHN4) | `86.66% <100.00%> (ø)` | |
| [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `73.20% <100.00%> (-0.63%)` | :arrow_down: |
| [...nd/src/dashboard/components/nativeFilters/types.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdHlwZXMudHM=) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/components/Select/utils.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3V0aWxzLnRz) | `61.53% <0.00%> (-30.77%)` | :arrow_down: |
| ... and [186 more](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [87baac7...33fa6f3](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-895530605
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-895530605
# [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16154](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cb6bec8) into [master](https://codecov.io/gh/apache/superset/commit/93ebe3d963c857ccc4185ef3ca5c6175397e17c9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (93ebe3d) will **decrease** coverage by `0.33%`.
> The diff coverage is `76.63%`.
> :exclamation: Current head cb6bec8 differs from pull request most recent head 0ff99c4. Consider uploading reports for the commit 0ff99c4 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16154 +/- ##
==========================================
- Coverage 76.93% 76.59% -0.34%
==========================================
Files 1030 1033 +3
Lines 55019 55188 +169
Branches 7465 7499 +34
==========================================
- Hits 42331 42274 -57
- Misses 12434 12664 +230
+ Partials 254 250 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `70.24% <76.63%> (-0.68%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ilters/FilterBar/FilterControls/FilterControls.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlckNvbnRyb2xzLnRzeA==) | `26.66% <0.00%> (-53.34%)` | :arrow_down: |
| [...nd/src/dashboard/components/nativeFilters/state.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc3RhdGUudHM=) | `26.31% <0.00%> (-48.69%)` | :arrow_down: |
| [...ilters/FiltersConfigModal/FilterTitleContainer.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlclRpdGxlQ29udGFpbmVyLnRzeA==) | `57.69% <57.69%> (ø)` | |
| [...mponents/nativeFilters/FiltersConfigModal/utils.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL3V0aWxzLnRz) | `69.10% <63.04%> (-1.79%)` | :arrow_down: |
| [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `73.71% <78.57%> (-0.13%)` | :arrow_down: |
| [...eFilters/FiltersConfigModal/FiltersConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdNb2RhbC50c3g=) | `88.02% <86.53%> (-1.40%)` | :arrow_down: |
| [...tiveFilters/FiltersConfigModal/FilterTitlePane.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlclRpdGxlUGFuZS50c3g=) | `90.90% <90.90%> (ø)` | |
| [...tiveFilters/FiltersConfigModal/DraggableFilter.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0RyYWdnYWJsZUZpbHRlci50c3g=) | `92.10% <92.10%> (ø)` | |
| [...Filters/FiltersConfigModal/FilterConfigurePane.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlckNvbmZpZ3VyZVBhbmUudHN4) | `100.00% <100.00%> (ø)` | |
| [...odal/FiltersConfigForm/FilterScope/FilterScope.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL0ZpbHRlclNjb3BlLnRzeA==) | `89.13% <100.00%> (+0.24%)` | :arrow_up: |
| ... and [18 more](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [93ebe3d...0ff99c4](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-944233823
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-934600127
/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] m-ajay commented on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
m-ajay commented on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-934575439
@michael-s-molina Thanks for the comments. I have fixed the scrolling issue other style comments.
About
> The hover is changing the color of the text and delete icon but not the hover icon
The drag icon is not part of the filter title, but part of the filter group. That's why I did not change the color on hover.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-942488580
/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat commented on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-942609550
@m-ajay i found a issue in the latest build: for the last added component, its column value sometimes now showing up:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jinghua-qa removed a comment on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
jinghua-qa removed a comment on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-944480464
LGTM!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-895530605
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-909664630
@m-ajay Thanks for resolving the issues. The code looks great and I just left some final suggestions.
While testing I found this one:
https://user-images.githubusercontent.com/70410625/131578585-16f61e27-1f43-478e-a73a-9dd8a67f30f9.mov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-895530605
# [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16154](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f8e6994) into [master](https://codecov.io/gh/apache/superset/commit/ccfc95fbe68da36f5eebd57421c2f5e57f7226e9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ccfc95f) will **decrease** coverage by `0.03%`.
> The diff coverage is `92.00%`.
> :exclamation: Current head f8e6994 differs from pull request most recent head 4645e8a. Consider uploading reports for the commit 4645e8a to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16154 +/- ##
==========================================
- Coverage 76.73% 76.69% -0.04%
==========================================
Files 996 996
Lines 52999 52962 -37
Branches 6738 6736 -2
==========================================
- Hits 40668 40620 -48
- Misses 12102 12117 +15
+ Partials 229 225 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `81.57% <ø> (-0.05%)` | :arrow_down: |
| postgres | `81.59% <ø> (-0.05%)` | :arrow_down: |
| presto | `81.43% <ø> (+<0.01%)` | :arrow_up: |
| python | `81.86% <ø> (-0.29%)` | :arrow_down: |
| sqlite | `81.19% <ø> (-0.09%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.27% <ø> (-0.03%)` | :arrow_down: |
| [...ilters/FilterBar/FilterControls/FilterControls.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlckNvbnRyb2xzLnRzeA==) | `80.00% <75.00%> (ø)` | |
| [...eFilters/FiltersConfigModal/FiltersConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdNb2RhbC50c3g=) | `95.45% <87.50%> (ø)` | |
| [...ts/nativeFilters/FiltersConfigModal/FilterTabs.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlclRhYnMudHN4) | `86.66% <100.00%> (ø)` | |
| [...mponents/nativeFilters/FiltersConfigModal/utils.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL3V0aWxzLnRz) | `73.61% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `69.80% <0.00%> (-16.87%)` | :arrow_down: |
| [...rontend/src/components/ListView/CardCollection.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvQ2FyZENvbGxlY3Rpb24udHN4) | `76.92% <0.00%> (-1.65%)` | :arrow_down: |
| ... and [37 more](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ccfc95f...4645e8a](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-895530605
# [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16154](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f74c57f) into [master](https://codecov.io/gh/apache/superset/commit/019e74652d823a90e09851f443f63aea13980005?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (019e746) will **decrease** coverage by `0.03%`.
> The diff coverage is `92.00%`.
[](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16154 +/- ##
==========================================
- Coverage 76.94% 76.90% -0.04%
==========================================
Files 986 990 +4
Lines 51978 52431 +453
Branches 7091 7091
==========================================
+ Hits 39993 40322 +329
- Misses 11759 11883 +124
Partials 226 226
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `81.56% <ø> (+0.13%)` | :arrow_up: |
| postgres | `81.58% <ø> (+0.13%)` | :arrow_up: |
| python | `81.67% <ø> (-0.16%)` | :arrow_down: |
| sqlite | `81.23% <ø> (+0.14%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.27% <ø> (+0.02%)` | :arrow_up: |
| [...ilters/FilterBar/FilterControls/FilterControls.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlckNvbnRyb2xzLnRzeA==) | `80.00% <75.00%> (ø)` | |
| [...eFilters/FiltersConfigModal/FiltersConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdNb2RhbC50c3g=) | `95.23% <87.50%> (ø)` | |
| [...ts/nativeFilters/FiltersConfigModal/FilterTabs.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlclRhYnMudHN4) | `86.66% <100.00%> (ø)` | |
| [...mponents/nativeFilters/FiltersConfigModal/utils.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL3V0aWxzLnRz) | `73.61% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `69.80% <0.00%> (-16.87%)` | :arrow_down: |
| [superset/dashboards/commands/importers/v1/utils.py](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvdXRpbHMucHk=) | `80.59% <0.00%> (-13.53%)` | :arrow_down: |
| [superset/utils/memoized.py](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvbWVtb2l6ZWQucHk=) | `86.11% <0.00%> (-7.83%)` | :arrow_down: |
| [superset/dashboards/commands/export.py](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leHBvcnQucHk=) | `83.09% <0.00%> (-7.23%)` | :arrow_down: |
| ... and [62 more](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [019e746...f74c57f](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-895530605
# [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16154](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d3ee2f7) into [master](https://codecov.io/gh/apache/superset/commit/519baa6f005a67c13ab13ad4bc2776f73afabed0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (519baa6) will **increase** coverage by `0.03%`.
> The diff coverage is `90.19%`.
[](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16154 +/- ##
==========================================
+ Coverage 76.77% 76.81% +0.03%
==========================================
Files 1003 1006 +3
Lines 53959 54110 +151
Branches 7330 7332 +2
==========================================
+ Hits 41427 41562 +135
- Misses 12293 12308 +15
- Partials 239 240 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.35% <ø> (+0.23%)` | :arrow_up: |
| mysql | `81.69% <ø> (+0.15%)` | :arrow_up: |
| postgres | `81.75% <ø> (+0.15%)` | :arrow_up: |
| presto | `?` | |
| python | `82.15% <ø> (+0.04%)` | :arrow_up: |
| sqlite | `81.41% <ø> (+0.19%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nfigModal/FiltersConfigForm/CollapsibleControl.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0NvbGxhcHNpYmxlQ29udHJvbC50c3g=) | `88.46% <0.00%> (ø)` | |
| [...mponents/nativeFilters/FiltersConfigModal/utils.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL3V0aWxzLnRz) | `72.22% <0.00%> (-1.39%)` | :arrow_down: |
| [...nd/src/dashboard/components/nativeFilters/state.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc3RhdGUudHM=) | `75.00% <0.00%> (ø)` | |
| [...nd/src/dashboard/components/nativeFilters/utils.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdXRpbHMudHM=) | `56.25% <ø> (ø)` | |
| [...ilters/FilterBar/FilterControls/FilterControls.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlckNvbnRyb2xzLnRzeA==) | `80.00% <75.00%> (ø)` | |
| [...eFilters/FiltersConfigModal/FiltersConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdNb2RhbC50c3g=) | `94.31% <96.87%> (-1.14%)` | :arrow_down: |
| [...ts/nativeFilters/FiltersConfigModal/FilterTabs.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlclRhYnMudHN4) | `86.66% <100.00%> (ø)` | |
| [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `73.20% <100.00%> (+0.07%)` | :arrow_up: |
| [...nd/src/dashboard/components/nativeFilters/types.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdHlwZXMudHM=) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `84.51% <0.00%> (-5.86%)` | :arrow_down: |
| ... and [57 more](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [519baa6...d3ee2f7](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-899789171
https://user-images.githubusercontent.com/70410625/129623092-a3da2276-f70b-4af3-be76-cacc4c3570dd.mov
- After the drop, the previous position is getting highlighted.
- The colors of selected and hover states could be more distinct. Currently, it's hard to see which item is hovered and which one is selected.
- In the drag animation, add padding to the text.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-895530605
# [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16154](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4645e8a) into [master](https://codecov.io/gh/apache/superset/commit/ccfc95fbe68da36f5eebd57421c2f5e57f7226e9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ccfc95f) will **decrease** coverage by `0.05%`.
> The diff coverage is `56.97%`.
[](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16154 +/- ##
==========================================
- Coverage 76.73% 76.67% -0.06%
==========================================
Files 996 997 +1
Lines 52999 53172 +173
Branches 6738 6782 +44
==========================================
+ Hits 40668 40772 +104
- Misses 12102 12169 +67
- Partials 229 231 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `70.89% <56.97%> (-0.08%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...mponents/nativeFilters/FiltersConfigModal/utils.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL3V0aWxzLnRz) | `72.97% <25.00%> (-0.64%)` | :arrow_down: |
| [...ilters/FilterBar/FilterControls/FilterControls.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlckNvbnRyb2xzLnRzeA==) | `80.00% <50.00%> (ø)` | |
| [...ativeFilters/FiltersConfigModal/FilterTabTitle.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlclRhYlRpdGxlLnRzeA==) | `55.35% <55.35%> (ø)` | |
| [...eFilters/FiltersConfigModal/FiltersConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdNb2RhbC50c3g=) | `89.00% <63.15%> (-6.46%)` | :arrow_down: |
| [...ts/nativeFilters/FiltersConfigModal/FilterTabs.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlclRhYnMudHN4) | `87.50% <80.00%> (+0.83%)` | :arrow_up: |
| [...perset-frontend/src/addSlice/AddSliceContainer.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FkZFNsaWNlQ29udGFpbmVyLnRzeA==) | `56.66% <0.00%> (-22.13%)` | :arrow_down: |
| [...tend/src/explore/components/ExploreChartHeader.jsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRIZWFkZXIuanN4) | `49.29% <0.00%> (-6.26%)` | :arrow_down: |
| [...d/src/explore/components/DatasourcePanel/index.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwvaW5kZXgudHN4) | `76.00% <0.00%> (-4.73%)` | :arrow_down: |
| [...frontend/src/dashboard/components/Header/index.jsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci9pbmRleC5qc3g=) | `59.88% <0.00%> (-3.19%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/welcome/ChartTable.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9DaGFydFRhYmxlLnRzeA==) | `73.17% <0.00%> (-1.83%)` | :arrow_down: |
| ... and [17 more](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ccfc95f...4645e8a](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-895530605
# [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16154](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b81c9e9) into [master](https://codecov.io/gh/apache/superset/commit/87baac7650bdb6a8f8f82cf4992567a2c5c73cba?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (87baac7) will **decrease** coverage by `0.38%`.
> The diff coverage is `80.16%`.
> :exclamation: Current head b81c9e9 differs from pull request most recent head 33fa6f3. Consider uploading reports for the commit 33fa6f3 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16154 +/- ##
==========================================
- Coverage 76.97% 76.59% -0.39%
==========================================
Files 1022 1033 +11
Lines 54903 55190 +287
Branches 7485 7496 +11
==========================================
+ Hits 42262 42273 +11
- Misses 12393 12668 +275
- Partials 248 249 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `70.25% <77.21%> (-0.78%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...d/src/SqlLab/components/AceEditorWrapper/index.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIvaW5kZXgudHN4) | `58.75% <ø> (ø)` | |
| [...erset-frontend/src/SqlLab/components/App/index.jsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FwcC9pbmRleC5qc3g=) | `57.14% <ø> (ø)` | |
| [...tend/src/SqlLab/components/ColumnElement/index.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0NvbHVtbkVsZW1lbnQvaW5kZXgudHN4) | `95.45% <ø> (ø)` | |
| [...qlLab/components/EstimateQueryCostButton/index.jsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0VzdGltYXRlUXVlcnlDb3N0QnV0dG9uL2luZGV4LmpzeA==) | `20.83% <ø> (ø)` | |
| [...lLab/components/ExploreCtasResultsButton/index.jsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVDdGFzUmVzdWx0c0J1dHRvbi9pbmRleC5qc3g=) | `7.69% <ø> (ø)` | |
| [...c/SqlLab/components/ExploreResultsButton/index.jsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVSZXN1bHRzQnV0dG9uL2luZGV4LmpzeA==) | `92.00% <ø> (ø)` | |
| [...d/src/SqlLab/components/QueryAutoRefresh/index.jsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5QXV0b1JlZnJlc2gvaW5kZXguanN4) | `65.90% <ø> (ø)` | |
| [...c/SqlLab/components/RunQueryActionButton/index.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1J1blF1ZXJ5QWN0aW9uQnV0dG9uL2luZGV4LnRzeA==) | `65.11% <ø> (ø)` | |
| [...d/src/SqlLab/components/SaveDatasetModal/index.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NhdmVEYXRhc2V0TW9kYWwvaW5kZXgudHN4) | `88.23% <ø> (ø)` | |
| [...frontend/src/SqlLab/components/SaveQuery/index.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NhdmVRdWVyeS9pbmRleC50c3g=) | `75.55% <ø> (ø)` | |
| ... and [88 more](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [87baac7...33fa6f3](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-938128199
I noticed that the collapse panels are behaving weirdly. The basic section should start opened and it's closed when there's a hierarchy. When I click to open it, it does nothing. It only opens when I click again. The same thing is happening for the Advanced section, if I have the parent set, it should start opened but it's not.
https://user-images.githubusercontent.com/70410625/136456541-a06d049c-c620-4df5-8908-3fa91d5acff2.mov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-895530605
# [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16154](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f74c57f) into [master](https://codecov.io/gh/apache/superset/commit/019e74652d823a90e09851f443f63aea13980005?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (019e746) will **decrease** coverage by `0.03%`.
> The diff coverage is `92.00%`.
[](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16154 +/- ##
==========================================
- Coverage 76.94% 76.90% -0.04%
==========================================
Files 986 990 +4
Lines 51978 52431 +453
Branches 7091 7091
==========================================
+ Hits 39993 40322 +329
- Misses 11759 11883 +124
Partials 226 226
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `81.56% <ø> (+0.13%)` | :arrow_up: |
| postgres | `81.59% <ø> (+0.13%)` | :arrow_up: |
| python | `81.67% <ø> (-0.16%)` | :arrow_down: |
| sqlite | `81.23% <ø> (+0.14%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.27% <ø> (+0.02%)` | :arrow_up: |
| [...ilters/FilterBar/FilterControls/FilterControls.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlckNvbnRyb2xzLnRzeA==) | `80.00% <75.00%> (ø)` | |
| [...eFilters/FiltersConfigModal/FiltersConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdNb2RhbC50c3g=) | `95.23% <87.50%> (ø)` | |
| [...ts/nativeFilters/FiltersConfigModal/FilterTabs.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlclRhYnMudHN4) | `86.66% <100.00%> (ø)` | |
| [...mponents/nativeFilters/FiltersConfigModal/utils.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL3V0aWxzLnRz) | `73.61% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `69.80% <0.00%> (-16.87%)` | :arrow_down: |
| [superset/dashboards/commands/importers/v1/utils.py](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvdXRpbHMucHk=) | `80.59% <0.00%> (-13.53%)` | :arrow_down: |
| [superset/utils/memoized.py](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvbWVtb2l6ZWQucHk=) | `86.11% <0.00%> (-7.83%)` | :arrow_down: |
| [superset/dashboards/commands/export.py](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leHBvcnQucHk=) | `83.09% <0.00%> (-7.23%)` | :arrow_down: |
| ... and [62 more](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [019e746...f74c57f](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat edited a comment on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
graceguo-supercat edited a comment on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-909743589
Thanks @michael-s-molina and @m-ajay I also played a little bit, here is my feedback:
1. only parent (top level filters) are shown in the filters list
2. In the edit mode, nested filters are also dragable and could be reordered. But there is no use to do this change, since nested filters don't show up in the filters list. In my opinion, we should probably not offer any action that is no use :)
3. it's pretty easy to hit `Cannot read property 'tagName' of null` error if i move nested filters.
I understand we want to allow user fully control the nested filter so we show them as first-class filter component. But make user move them up and down do not make sense to me. So my suggestion is:
- make child filter always next to parent filter,
- when user moves parent filter, children should be moved along,
- children (nested filters) itself, should not be dragable or rearrangeable.
@m-ajay @michael-s-molina @junlincc please let me know your opinion about this behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jinghua-qa commented on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
jinghua-qa commented on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-895605898
I have tested in the test environment, the drag and drop is not accurate, it always drop the filter to the bottom no matter i move up or move down, some time i just want to change the filter position from 1st to 2nd and it was dropped to the last
https://user-images.githubusercontent.com/81597121/128784760-b9f0ef16-7e2e-4cfa-a19c-706130be5f91.mov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-938012094
@graceguo-supercat Ephemeral environment creation is currently limited to committers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #16154:
URL: https://github.com/apache/superset/pull/16154#discussion_r724541838
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterConfigurePane.tsx
##########
@@ -0,0 +1,94 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { styled } from '@superset-ui/core';
+import React from 'react';
+import FilterTitlePane from './FilterTitlePane';
+import { FilterRemoval } from './types';
+
+interface Props {
+ children: (filterId: string) => React.ReactNode;
+ getFilterTitle: (filterId: string) => string;
+ onChange: (activeKey: string) => void;
+ onEdit: (filterId: string, action: 'add' | 'remove') => void;
+ onRearrange: (dragIndex: number, targetIndex: number) => void;
+ restoreFilter: (id: string) => void;
+ currentFilterId: string;
+ filterGroups: string[][];
+ removedFilters: Record<string, FilterRemoval>;
+}
+
+const Container = styled.div`
+ display: flex;
+ height: 100%;
+`;
+const ContentHolder = styled.div`
+ flex-grow: 3;
+ margin-left: ${({ theme }) => theme.gridUnit * -1 - 1};
+`;
+const TitlesContainer = styled.div`
+ width: 270px;
+ border-right: 1px solid ${({ theme }) => theme.colors.grayscale.light2};
+`;
+
+const FiltureConfigurePane: React.FC<Props> = ({
+ getFilterTitle,
+ onChange,
+ onEdit,
+ onRearrange,
+ restoreFilter,
+ children,
+ currentFilterId,
+ filterGroups,
+ removedFilters,
+}) => {
+ const active = filterGroups.flat().filter(id => id === currentFilterId)[0];
+ return (
+ <Container>
+ <TitlesContainer>
+ <FilterTitlePane
+ currentFilterId={currentFilterId}
+ filterGroups={filterGroups}
+ getFilterTitle={getFilterTitle}
+ onChange={onChange}
+ onEdit={onEdit}
+ onRearrage={onRearrange}
+ onRemove={(id: string) => onEdit(id, 'remove')}
+ removedFilters={removedFilters}
+ restoreFilter={restoreFilter}
+ />
+ </TitlesContainer>
+ <ContentHolder>
+ {filterGroups.flat().map(id => (
+ <div
+ key={id}
+ style={{
+ height: '100%',
+ overflowY: 'scroll',
Review comment:
This one is important to avoid showing the right panel scroll when the content fits on the screen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat commented on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-909743589
Thanks @michael-s-molina and @m-ajay I also played a little bit, here is my feedback:
1. only parent (top level filters) are shown in the filters list
2. In the edit mode, nested filters are also dragable and could be reordered. But there is no impact for display in the filter list, since nested filters don't show up in the filters list.
I understand we want to allow user fully control the nested filter so we show them as first-class filter component. But make user move them up and down do not make sense to me. So my suggestion is:
- make child filter always next to parent filter,
- when user moves parent filter, children should be moved along,
- children (nested filters) itself, should not be dragable or rearrangeable.
@m-ajay @michael-s-molina @junlincc please let me know your opinion about this behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #16154:
URL: https://github.com/apache/superset/pull/16154#discussion_r727293437
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal.tsx
##########
@@ -249,28 +279,69 @@ export function FiltersConfigModal({
const handleCancel = () => {
const changed = form.getFieldValue('changed');
- if (unsavedFiltersIds.length > 0 || form.isFieldsTouched() || changed) {
+ const initialOrder = buildFilterGroup(getInitialFilterHierarchy()).flat();
+ const didChangeOrder =
+ orderedFilters.flat().length !== initialOrder.length ||
+ orderedFilters.flat().some((val, index) => val !== initialOrder[index]);
+ if (
+ unsavedFiltersIds.length > 0 ||
+ form.isFieldsTouched() ||
+ changed ||
+ didChangeOrder
+ ) {
setSaveAlertVisible(true);
} else {
handleConfirmCancel();
}
};
+ const onRearrage = (dragIndex: number, targetIndex: number) => {
+ const newOrderedFilter = orderedFilters.map(group => [...group]);
+
+ const removed = newOrderedFilter.splice(dragIndex, 1)[0];
+ newOrderedFilter.splice(targetIndex, 0, removed);
+ setOrderedFilters(newOrderedFilter);
+ };
+ const handleFilterHierarchyChange = useCallback(
+ (filterId: string, parentFilter?: { value: string; label: string }) => {
+ const index = filterHierarchy.findIndex(item => item.id === filterId);
+ const newState = [...filterHierarchy];
+ newState.splice(index, 1, {
+ id: filterId,
+ parentId: parentFilter ? parentFilter.value : null,
+ });
+ setFilterHierarchy(newState);
+ setOrderedFilters(buildFilterGroup(newState));
+ },
+ [setFilterHierarchy, setOrderedFilters, filterHierarchy],
+ );
const onValuesChange = useMemo(
- () =>
- debounce((changes: any, values: NativeFiltersForm) => {
Review comment:
Debouncing was added because we had a performance problem updating the form values every time a user typed a character while filling the filter name. We can only remove it if we provide an alternative solution for this problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-925605153
⚠️ @m-ajay Your base branch `master` has just also updated `superset/migrations`.
❗ **Please consider rebasing your branch to avoid db migration conflicts.**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina edited a comment on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
michael-s-molina edited a comment on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-938128199
I noticed that the collapse panels are behaving weirdly. The basic section should start opened and it's closed when there's a hierarchy. When I click to open it, it does nothing. It only opens when I click it again. The same thing is happening for the Advanced section, if I have the parent set, it should start opened but it's not.
https://user-images.githubusercontent.com/70410625/136456541-a06d049c-c620-4df5-8908-3fa91d5acff2.mov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat commented on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-938011933
/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat commented on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-938011933
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-895530605
# [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16154](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5ba6717) into [master](https://codecov.io/gh/apache/superset/commit/5e85f48515df2854251e78a91a1e9ce15a8ae785?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5e85f48) will **increase** coverage by `0.03%`.
> The diff coverage is `77.22%`.
> :exclamation: Current head 5ba6717 differs from pull request most recent head 2b81f94. Consider uploading reports for the commit 2b81f94 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16154 +/- ##
==========================================
+ Coverage 76.88% 76.92% +0.03%
==========================================
Files 1031 1033 +2
Lines 55183 55195 +12
Branches 7505 7503 -2
==========================================
+ Hits 42430 42459 +29
+ Misses 12501 12482 -19
- Partials 252 254 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `70.93% <77.22%> (+0.11%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ilters/FilterBar/FilterConfigurationLink/index.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbmZpZ3VyYXRpb25MaW5rL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...mponents/nativeFilters/FiltersConfigModal/state.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL3N0YXRlLnRz) | `81.25% <0.00%> (+4.77%)` | :arrow_up: |
| [...nd/src/dashboard/components/nativeFilters/state.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc3RhdGUudHM=) | `73.21% <0.00%> (-1.34%)` | :arrow_down: |
| [...ilters/FiltersConfigModal/FilterTitleContainer.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlclRpdGxlQ29udGFpbmVyLnRzeA==) | `58.82% <58.82%> (ø)` | |
| [...mponents/nativeFilters/FiltersConfigModal/utils.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL3V0aWxzLnRz) | `68.54% <61.70%> (-1.83%)` | :arrow_down: |
| [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `73.71% <78.57%> (+2.10%)` | :arrow_up: |
| [...eFilters/FiltersConfigModal/FiltersConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdNb2RhbC50c3g=) | `87.94% <86.53%> (-1.41%)` | :arrow_down: |
| [...ilters/FilterBar/FilterControls/FilterControls.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlckNvbnRyb2xzLnRzeA==) | `80.00% <87.50%> (ø)` | |
| [...tiveFilters/FiltersConfigModal/FilterTitlePane.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlclRpdGxlUGFuZS50c3g=) | `92.00% <92.00%> (ø)` | |
| [...tiveFilters/FiltersConfigModal/DraggableFilter.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0RyYWdnYWJsZUZpbHRlci50c3g=) | `92.10% <92.10%> (ø)` | |
| ... and [38 more](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5e85f48...2b81f94](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-944231848
/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-933743212
@m-ajay I was just checking the latest version of the interface and I found many differences in relation to what we have on master.
This is the master version:
<img width="900" alt="Screen Shot 2021-10-04 at 3 01 57 PM" src="https://user-images.githubusercontent.com/70410625/135901213-192ed6d3-5183-4ddf-b353-c53bfc84ec4b.png">
This is the latest version of this branch:
<img width="897" alt="Screen Shot 2021-10-04 at 2 57 04 PM" src="https://user-images.githubusercontent.com/70410625/135901265-93086915-14dc-4a64-a0ff-397aeca6919e.png">
I marked some of the differences:
- Double vertical bars on the left panel. The bar is appearing even if we have only one item.
- The Add Filter button is disappearing from the screen
- The top margin on the right panel is different
- We have a vertical scrollbar on the right panel even when the content fits
- The right border of the collapse panel is duplicated, giving the impression that is thicker than the other borders
- The selected filter state is different. Previously we had a background color indicating the selected filter
- The left padding on the left panel is different. Look how the filters are aligned with the Filters title on master
About the new feature:
- I noticed that the cursor is changing (grab/grabbing) only when I drag using the icon but if I drag using the name the cursor does not change
- The drag image contains a bottom padding
- The hover is changing the color of the text and delete icon but not the hover icon
These points are just something that I noticed very quickly but maybe we can have more. I suggest that you compare the proposed view with the one on master to make sure the behaviors are the same with the added drag and drop functionality.
Just ping me if any of these points are not clear or if you need any help 😉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #16154:
URL: https://github.com/apache/superset/pull/16154#discussion_r727293437
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal.tsx
##########
@@ -249,28 +279,69 @@ export function FiltersConfigModal({
const handleCancel = () => {
const changed = form.getFieldValue('changed');
- if (unsavedFiltersIds.length > 0 || form.isFieldsTouched() || changed) {
+ const initialOrder = buildFilterGroup(getInitialFilterHierarchy()).flat();
+ const didChangeOrder =
+ orderedFilters.flat().length !== initialOrder.length ||
+ orderedFilters.flat().some((val, index) => val !== initialOrder[index]);
+ if (
+ unsavedFiltersIds.length > 0 ||
+ form.isFieldsTouched() ||
+ changed ||
+ didChangeOrder
+ ) {
setSaveAlertVisible(true);
} else {
handleConfirmCancel();
}
};
+ const onRearrage = (dragIndex: number, targetIndex: number) => {
+ const newOrderedFilter = orderedFilters.map(group => [...group]);
+
+ const removed = newOrderedFilter.splice(dragIndex, 1)[0];
+ newOrderedFilter.splice(targetIndex, 0, removed);
+ setOrderedFilters(newOrderedFilter);
+ };
+ const handleFilterHierarchyChange = useCallback(
+ (filterId: string, parentFilter?: { value: string; label: string }) => {
+ const index = filterHierarchy.findIndex(item => item.id === filterId);
+ const newState = [...filterHierarchy];
+ newState.splice(index, 1, {
+ id: filterId,
+ parentId: parentFilter ? parentFilter.value : null,
+ });
+ setFilterHierarchy(newState);
+ setOrderedFilters(buildFilterGroup(newState));
+ },
+ [setFilterHierarchy, setOrderedFilters, filterHierarchy],
+ );
const onValuesChange = useMemo(
- () =>
- debounce((changes: any, values: NativeFiltersForm) => {
Review comment:
Debouncing was added because we had a performance problem updating the form values every time a user typed a character while filling the filter name. We can only remove it if we provide an alternative solution for this problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] m-ajay commented on a change in pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
m-ajay commented on a change in pull request #16154:
URL: https://github.com/apache/superset/pull/16154#discussion_r727290303
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal.tsx
##########
@@ -249,28 +279,69 @@ export function FiltersConfigModal({
const handleCancel = () => {
const changed = form.getFieldValue('changed');
- if (unsavedFiltersIds.length > 0 || form.isFieldsTouched() || changed) {
+ const initialOrder = buildFilterGroup(getInitialFilterHierarchy()).flat();
+ const didChangeOrder =
+ orderedFilters.flat().length !== initialOrder.length ||
+ orderedFilters.flat().some((val, index) => val !== initialOrder[index]);
+ if (
+ unsavedFiltersIds.length > 0 ||
+ form.isFieldsTouched() ||
+ changed ||
+ didChangeOrder
+ ) {
setSaveAlertVisible(true);
} else {
handleConfirmCancel();
}
};
+ const onRearrage = (dragIndex: number, targetIndex: number) => {
+ const newOrderedFilter = orderedFilters.map(group => [...group]);
+
+ const removed = newOrderedFilter.splice(dragIndex, 1)[0];
+ newOrderedFilter.splice(targetIndex, 0, removed);
+ setOrderedFilters(newOrderedFilter);
+ };
+ const handleFilterHierarchyChange = useCallback(
+ (filterId: string, parentFilter?: { value: string; label: string }) => {
+ const index = filterHierarchy.findIndex(item => item.id === filterId);
+ const newState = [...filterHierarchy];
+ newState.splice(index, 1, {
+ id: filterId,
+ parentId: parentFilter ? parentFilter.value : null,
+ });
+ setFilterHierarchy(newState);
+ setOrderedFilters(buildFilterGroup(newState));
+ },
+ [setFilterHierarchy, setOrderedFilters, filterHierarchy],
+ );
const onValuesChange = useMemo(
- () =>
- debounce((changes: any, values: NativeFiltersForm) => {
Review comment:
Debouncing was causing a latency in filter hierarchy change when adding/removing parent filters.
Thats why I removed it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-909631446
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-895530605
# [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16154](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d3ee2f7) into [master](https://codecov.io/gh/apache/superset/commit/519baa6f005a67c13ab13ad4bc2776f73afabed0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (519baa6) will **increase** coverage by `0.03%`.
> The diff coverage is `90.19%`.
> :exclamation: Current head d3ee2f7 differs from pull request most recent head 7a46859. Consider uploading reports for the commit 7a46859 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16154 +/- ##
==========================================
+ Coverage 76.77% 76.81% +0.03%
==========================================
Files 1003 1006 +3
Lines 53959 54110 +151
Branches 7330 7332 +2
==========================================
+ Hits 41427 41562 +135
- Misses 12293 12308 +15
- Partials 239 240 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.35% <ø> (+0.23%)` | :arrow_up: |
| mysql | `81.69% <ø> (+0.15%)` | :arrow_up: |
| postgres | `81.75% <ø> (+0.15%)` | :arrow_up: |
| presto | `?` | |
| python | `82.15% <ø> (+0.04%)` | :arrow_up: |
| sqlite | `81.41% <ø> (+0.19%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nfigModal/FiltersConfigForm/CollapsibleControl.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0NvbGxhcHNpYmxlQ29udHJvbC50c3g=) | `88.46% <0.00%> (ø)` | |
| [...mponents/nativeFilters/FiltersConfigModal/utils.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL3V0aWxzLnRz) | `72.22% <0.00%> (-1.39%)` | :arrow_down: |
| [...nd/src/dashboard/components/nativeFilters/state.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc3RhdGUudHM=) | `75.00% <0.00%> (ø)` | |
| [...nd/src/dashboard/components/nativeFilters/utils.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdXRpbHMudHM=) | `56.25% <ø> (ø)` | |
| [...ilters/FilterBar/FilterControls/FilterControls.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlckNvbnRyb2xzLnRzeA==) | `80.00% <75.00%> (ø)` | |
| [...eFilters/FiltersConfigModal/FiltersConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdNb2RhbC50c3g=) | `94.31% <96.87%> (-1.14%)` | :arrow_down: |
| [...ts/nativeFilters/FiltersConfigModal/FilterTabs.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlclRhYnMudHN4) | `86.66% <100.00%> (ø)` | |
| [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `73.20% <100.00%> (+0.07%)` | :arrow_up: |
| [...nd/src/dashboard/components/nativeFilters/types.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdHlwZXMudHM=) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `84.51% <0.00%> (-5.86%)` | :arrow_down: |
| ... and [57 more](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [519baa6...7a46859](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-934629334
/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-934633064
@michael-s-molina Ephemeral environment spinning up at http://34.222.135.121:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-909631446
/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-895530605
# [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16154](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f8e6994) into [master](https://codecov.io/gh/apache/superset/commit/019e74652d823a90e09851f443f63aea13980005?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (019e746) will **decrease** coverage by `0.24%`.
> The diff coverage is `66.64%`.
> :exclamation: Current head f8e6994 differs from pull request most recent head 2d2fa28. Consider uploading reports for the commit 2d2fa28 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16154 +/- ##
==========================================
- Coverage 76.94% 76.69% -0.25%
==========================================
Files 986 996 +10
Lines 51978 52962 +984
Branches 7091 6736 -355
==========================================
+ Hits 39993 40620 +627
- Misses 11759 12117 +358
+ Partials 226 225 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `81.57% <83.40%> (+0.14%)` | :arrow_up: |
| postgres | `81.59% <83.42%> (+0.14%)` | :arrow_up: |
| presto | `81.43% <83.42%> (?)` | |
| python | `81.86% <83.70%> (+0.03%)` | :arrow_up: |
| sqlite | `81.19% <82.13%> (+0.10%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `44.64% <0.00%> (-1.66%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | `37.17% <0.00%> (-0.80%)` | :arrow_down: |
| [...-frontend/src/components/CronPicker/CronPicker.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ3JvblBpY2tlci9Dcm9uUGlja2VyLnRzeA==) | `91.66% <ø> (ø)` | |
| [superset-frontend/src/components/Icons/index.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbnMvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [.../src/components/dataViewCommon/TableCollection.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvZGF0YVZpZXdDb21tb24vVGFibGVDb2xsZWN0aW9uLnRzeA==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/dashboard/actions/hydrate.js](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2h5ZHJhdGUuanM=) | `1.69% <0.00%> (-0.02%)` | :arrow_down: |
| [...rc/dashboard/components/dnd/dragDroppableConfig.js](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9kcmFnRHJvcHBhYmxlQ29uZmlnLmpz) | `31.81% <0.00%> (-3.19%)` | :arrow_down: |
| [...d/src/dashboard/components/gridComponents/Tabs.jsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL1RhYnMuanN4) | `86.48% <0.00%> (-2.41%)` | :arrow_down: |
| [...ters/FiltersConfigModal/FiltersConfigForm/utils.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL3V0aWxzLnRz) | `90.47% <ø> (ø)` | |
| [...nativeFilters/FiltersConfigModal/Footer/Footer.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0Zvb3Rlci9Gb290ZXIudHN4) | `100.00% <ø> (+5.26%)` | :arrow_up: |
| ... and [178 more](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [019e746...2d2fa28](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-895530605
# [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16154](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5ba6717) into [master](https://codecov.io/gh/apache/superset/commit/93ebe3d963c857ccc4185ef3ca5c6175397e17c9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (93ebe3d) will **decrease** coverage by `0.01%`.
> The diff coverage is `77.22%`.
> :exclamation: Current head 5ba6717 differs from pull request most recent head abdffb6. Consider uploading reports for the commit abdffb6 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16154 +/- ##
==========================================
- Coverage 76.93% 76.92% -0.02%
==========================================
Files 1030 1033 +3
Lines 55019 55195 +176
Branches 7465 7503 +38
==========================================
+ Hits 42331 42459 +128
- Misses 12434 12482 +48
Partials 254 254
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `70.93% <77.22%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ilters/FilterBar/FilterConfigurationLink/index.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbmZpZ3VyYXRpb25MaW5rL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...mponents/nativeFilters/FiltersConfigModal/state.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL3N0YXRlLnRz) | `81.25% <0.00%> (+4.77%)` | :arrow_up: |
| [...nd/src/dashboard/components/nativeFilters/state.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc3RhdGUudHM=) | `73.21% <0.00%> (-1.79%)` | :arrow_down: |
| [...ilters/FiltersConfigModal/FilterTitleContainer.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlclRpdGxlQ29udGFpbmVyLnRzeA==) | `58.82% <58.82%> (ø)` | |
| [...mponents/nativeFilters/FiltersConfigModal/utils.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL3V0aWxzLnRz) | `68.54% <61.70%> (-2.34%)` | :arrow_down: |
| [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `73.71% <78.57%> (-0.13%)` | :arrow_down: |
| [...eFilters/FiltersConfigModal/FiltersConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdNb2RhbC50c3g=) | `87.94% <86.53%> (-1.48%)` | :arrow_down: |
| [...ilters/FilterBar/FilterControls/FilterControls.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlckNvbnRyb2xzLnRzeA==) | `80.00% <87.50%> (ø)` | |
| [...tiveFilters/FiltersConfigModal/FilterTitlePane.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlclRpdGxlUGFuZS50c3g=) | `92.00% <92.00%> (ø)` | |
| [...tiveFilters/FiltersConfigModal/DraggableFilter.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0RyYWdnYWJsZUZpbHRlci50c3g=) | `92.10% <92.10%> (ø)` | |
| ... and [28 more](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [93ebe3d...abdffb6](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-938138868
The text is not vertically aligned with the icon (center):
<img width="244" alt="Screen Shot 2021-10-07 at 5 37 43 PM" src="https://user-images.githubusercontent.com/70410625/136458535-70875cd7-a6b7-47a9-9502-7a7fc140a1da.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina edited a comment on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
michael-s-molina edited a comment on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-938138868
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-895530605
# [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16154](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5ba6717) into [master](https://codecov.io/gh/apache/superset/commit/93ebe3d963c857ccc4185ef3ca5c6175397e17c9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (93ebe3d) will **decrease** coverage by `0.01%`.
> The diff coverage is `77.22%`.
[](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16154 +/- ##
==========================================
- Coverage 76.93% 76.92% -0.02%
==========================================
Files 1030 1033 +3
Lines 55019 55195 +176
Branches 7465 7503 +38
==========================================
+ Hits 42331 42459 +128
- Misses 12434 12482 +48
Partials 254 254
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `70.93% <77.22%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ilters/FilterBar/FilterConfigurationLink/index.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbmZpZ3VyYXRpb25MaW5rL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...mponents/nativeFilters/FiltersConfigModal/state.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL3N0YXRlLnRz) | `81.25% <0.00%> (+4.77%)` | :arrow_up: |
| [...nd/src/dashboard/components/nativeFilters/state.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc3RhdGUudHM=) | `73.21% <0.00%> (-1.79%)` | :arrow_down: |
| [...ilters/FiltersConfigModal/FilterTitleContainer.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlclRpdGxlQ29udGFpbmVyLnRzeA==) | `58.82% <58.82%> (ø)` | |
| [...mponents/nativeFilters/FiltersConfigModal/utils.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL3V0aWxzLnRz) | `68.54% <61.70%> (-2.34%)` | :arrow_down: |
| [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `73.71% <78.57%> (-0.13%)` | :arrow_down: |
| [...eFilters/FiltersConfigModal/FiltersConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdNb2RhbC50c3g=) | `87.94% <86.53%> (-1.48%)` | :arrow_down: |
| [...ilters/FilterBar/FilterControls/FilterControls.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlckNvbnRyb2xzLnRzeA==) | `80.00% <87.50%> (ø)` | |
| [...tiveFilters/FiltersConfigModal/FilterTitlePane.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlclRpdGxlUGFuZS50c3g=) | `92.00% <92.00%> (ø)` | |
| [...tiveFilters/FiltersConfigModal/DraggableFilter.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0RyYWdnYWJsZUZpbHRlci50c3g=) | `92.10% <92.10%> (ø)` | |
| ... and [28 more](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [93ebe3d...5ba6717](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-895530605
# [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16154](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (00c020c) into [master](https://codecov.io/gh/apache/superset/commit/93ebe3d963c857ccc4185ef3ca5c6175397e17c9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (93ebe3d) will **decrease** coverage by `0.33%`.
> The diff coverage is `77.25%`.
[](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16154 +/- ##
==========================================
- Coverage 76.93% 76.60% -0.34%
==========================================
Files 1030 1033 +3
Lines 55019 55199 +180
Branches 7465 7502 +37
==========================================
- Hits 42331 42283 -48
- Misses 12434 12666 +232
+ Partials 254 250 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `70.25% <77.25%> (-0.67%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ilters/FilterBar/FilterConfigurationLink/index.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbmZpZ3VyYXRpb25MaW5rL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...ilters/FilterBar/FilterControls/FilterControls.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlckNvbnRyb2xzLnRzeA==) | `26.66% <0.00%> (-53.34%)` | :arrow_down: |
| [...nd/src/dashboard/components/nativeFilters/state.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc3RhdGUudHM=) | `26.78% <0.00%> (-48.22%)` | :arrow_down: |
| [...ilters/FiltersConfigModal/FilterTitleContainer.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlclRpdGxlQ29udGFpbmVyLnRzeA==) | `57.69% <57.69%> (ø)` | |
| [...mponents/nativeFilters/FiltersConfigModal/utils.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL3V0aWxzLnRz) | `68.54% <61.70%> (-2.34%)` | :arrow_down: |
| [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `73.71% <78.57%> (-0.13%)` | :arrow_down: |
| [...eFilters/FiltersConfigModal/FiltersConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdNb2RhbC50c3g=) | `88.27% <87.50%> (-1.15%)` | :arrow_down: |
| [...tiveFilters/FiltersConfigModal/FilterTitlePane.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlclRpdGxlUGFuZS50c3g=) | `92.00% <92.00%> (ø)` | |
| [...tiveFilters/FiltersConfigModal/DraggableFilter.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0RyYWdnYWJsZUZpbHRlci50c3g=) | `92.10% <92.10%> (ø)` | |
| [...omponents/nativeFilters/FilterBar/Header/index.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0hlYWRlci9pbmRleC50c3g=) | `97.05% <100.00%> (-2.95%)` | :arrow_down: |
| ... and [39 more](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [93ebe3d...00c020c](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat commented on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-938029964
I tested manually, it is pretty good by now. @michael-s-molina @etr2460
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat commented on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-944810808
@michael-s-molina @jinghua-qa thanks for the hard work!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-942493358
@rusackas Ephemeral environment spinning up at http://34.217.68.142:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-895530605
# [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16154](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d3ee2f7) into [master](https://codecov.io/gh/apache/superset/commit/519baa6f005a67c13ab13ad4bc2776f73afabed0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (519baa6) will **decrease** coverage by `0.10%`.
> The diff coverage is `90.19%`.
[](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16154 +/- ##
==========================================
- Coverage 76.77% 76.66% -0.11%
==========================================
Files 1003 1006 +3
Lines 53959 54110 +151
Branches 7330 7332 +2
==========================================
+ Hits 41427 41485 +58
- Misses 12293 12385 +92
- Partials 239 240 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `81.69% <ø> (+0.15%)` | :arrow_up: |
| postgres | `81.75% <ø> (+0.15%)` | :arrow_up: |
| presto | `?` | |
| python | `81.88% <ø> (-0.24%)` | :arrow_down: |
| sqlite | `81.41% <ø> (+0.19%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nfigModal/FiltersConfigForm/CollapsibleControl.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0NvbGxhcHNpYmxlQ29udHJvbC50c3g=) | `88.46% <0.00%> (ø)` | |
| [...mponents/nativeFilters/FiltersConfigModal/utils.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL3V0aWxzLnRz) | `72.22% <0.00%> (-1.39%)` | :arrow_down: |
| [...nd/src/dashboard/components/nativeFilters/state.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc3RhdGUudHM=) | `75.00% <0.00%> (ø)` | |
| [...nd/src/dashboard/components/nativeFilters/utils.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdXRpbHMudHM=) | `56.25% <ø> (ø)` | |
| [...ilters/FilterBar/FilterControls/FilterControls.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlckNvbnRyb2xzLnRzeA==) | `80.00% <75.00%> (ø)` | |
| [...eFilters/FiltersConfigModal/FiltersConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdNb2RhbC50c3g=) | `94.31% <96.87%> (-1.14%)` | :arrow_down: |
| [...ts/nativeFilters/FiltersConfigModal/FilterTabs.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlclRhYnMudHN4) | `86.66% <100.00%> (ø)` | |
| [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `73.20% <100.00%> (+0.07%)` | :arrow_up: |
| [...nd/src/dashboard/components/nativeFilters/types.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdHlwZXMudHM=) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| ... and [59 more](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [519baa6...d3ee2f7](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-922102374
Let's discuss it during next Wednesday meeting. 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-895530605
# [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16154](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d3ee2f7) into [master](https://codecov.io/gh/apache/superset/commit/87baac7650bdb6a8f8f82cf4992567a2c5c73cba?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (87baac7) will **decrease** coverage by `0.16%`.
> The diff coverage is `90.19%`.
> :exclamation: Current head d3ee2f7 differs from pull request most recent head ec034ae. Consider uploading reports for the commit ec034ae to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16154 +/- ##
==========================================
- Coverage 76.97% 76.81% -0.17%
==========================================
Files 1022 1006 -16
Lines 54903 54110 -793
Branches 7485 7332 -153
==========================================
- Hits 42262 41562 -700
+ Misses 12393 12308 -85
+ Partials 248 240 -8
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.35% <ø> (-0.11%)` | :arrow_down: |
| mysql | `81.69% <ø> (-0.16%)` | :arrow_down: |
| postgres | `81.75% <ø> (-0.16%)` | :arrow_down: |
| presto | `?` | |
| python | `82.15% <ø> (-0.27%)` | :arrow_down: |
| sqlite | `81.41% <ø> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nfigModal/FiltersConfigForm/CollapsibleControl.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0NvbGxhcHNpYmxlQ29udHJvbC50c3g=) | `88.46% <0.00%> (ø)` | |
| [...mponents/nativeFilters/FiltersConfigModal/utils.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL3V0aWxzLnRz) | `72.22% <0.00%> (+1.33%)` | :arrow_up: |
| [...nd/src/dashboard/components/nativeFilters/state.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc3RhdGUudHM=) | `75.00% <0.00%> (ø)` | |
| [...nd/src/dashboard/components/nativeFilters/utils.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdXRpbHMudHM=) | `56.25% <ø> (ø)` | |
| [...ilters/FilterBar/FilterControls/FilterControls.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlckNvbnRyb2xzLnRzeA==) | `80.00% <75.00%> (ø)` | |
| [...eFilters/FiltersConfigModal/FiltersConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdNb2RhbC50c3g=) | `94.31% <96.87%> (+5.85%)` | :arrow_up: |
| [...ts/nativeFilters/FiltersConfigModal/FilterTabs.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlclRhYnMudHN4) | `86.66% <100.00%> (ø)` | |
| [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `73.20% <100.00%> (-0.63%)` | :arrow_down: |
| [...nd/src/dashboard/components/nativeFilters/types.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdHlwZXMudHM=) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/components/Select/utils.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3V0aWxzLnRz) | `61.53% <0.00%> (-30.77%)` | :arrow_down: |
| ... and [186 more](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [87baac7...ec034ae](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat commented on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-909743589
Thanks @michael-s-molina and @m-ajay I also played a little bit, here is my feedback:
1. only parent (top level filters) are shown in the filters list
2. In the edit mode, nested filters are also dragable and could be reordered. But there is no impact for display in the filter list, since nested filters don't show up in the filters list.
I understand we want to allow user fully control the nested filter so we show them as first-class filter component. But make user move them up and down do not make sense to me. So my suggestion is:
- make child filter always next to parent filter,
- when user moves parent filter, children should be moved along,
- children (nested filters) itself, should not be dragable or rearrangeable.
@m-ajay @michael-s-molina @junlincc please let me know your opinion about this behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-895530605
# [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16154](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f8e6994) into [master](https://codecov.io/gh/apache/superset/commit/019e74652d823a90e09851f443f63aea13980005?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (019e746) will **decrease** coverage by `0.24%`.
> The diff coverage is `66.64%`.
> :exclamation: Current head f8e6994 differs from pull request most recent head ec1559c. Consider uploading reports for the commit ec1559c to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16154 +/- ##
==========================================
- Coverage 76.94% 76.69% -0.25%
==========================================
Files 986 996 +10
Lines 51978 52962 +984
Branches 7091 6736 -355
==========================================
+ Hits 39993 40620 +627
- Misses 11759 12117 +358
+ Partials 226 225 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `81.57% <83.40%> (+0.14%)` | :arrow_up: |
| postgres | `81.59% <83.42%> (+0.14%)` | :arrow_up: |
| presto | `81.43% <83.42%> (?)` | |
| python | `81.86% <83.70%> (+0.03%)` | :arrow_up: |
| sqlite | `81.19% <82.13%> (+0.10%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `44.64% <0.00%> (-1.66%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | `37.17% <0.00%> (-0.80%)` | :arrow_down: |
| [...-frontend/src/components/CronPicker/CronPicker.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ3JvblBpY2tlci9Dcm9uUGlja2VyLnRzeA==) | `91.66% <ø> (ø)` | |
| [superset-frontend/src/components/Icons/index.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbnMvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [.../src/components/dataViewCommon/TableCollection.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvZGF0YVZpZXdDb21tb24vVGFibGVDb2xsZWN0aW9uLnRzeA==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/dashboard/actions/hydrate.js](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2h5ZHJhdGUuanM=) | `1.69% <0.00%> (-0.02%)` | :arrow_down: |
| [...rc/dashboard/components/dnd/dragDroppableConfig.js](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9kcmFnRHJvcHBhYmxlQ29uZmlnLmpz) | `31.81% <0.00%> (-3.19%)` | :arrow_down: |
| [...d/src/dashboard/components/gridComponents/Tabs.jsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL1RhYnMuanN4) | `86.48% <0.00%> (-2.41%)` | :arrow_down: |
| [...ters/FiltersConfigModal/FiltersConfigForm/utils.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL3V0aWxzLnRz) | `90.47% <ø> (ø)` | |
| [...nativeFilters/FiltersConfigModal/Footer/Footer.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0Zvb3Rlci9Gb290ZXIudHN4) | `100.00% <ø> (+5.26%)` | :arrow_up: |
| ... and [178 more](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [019e746...ec1559c](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-903057509
it appears to me that there's some lagging when reordering. could we optimize the perf?
https://user-images.githubusercontent.com/67837651/130310816-c0157357-55cd-48a3-85ef-df292c97cdd4.mov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-895530605
# [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16154](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f8e6994) into [master](https://codecov.io/gh/apache/superset/commit/019e74652d823a90e09851f443f63aea13980005?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (019e746) will **decrease** coverage by `0.24%`.
> The diff coverage is `66.64%`.
> :exclamation: Current head f8e6994 differs from pull request most recent head 4e5d00b. Consider uploading reports for the commit 4e5d00b to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16154 +/- ##
==========================================
- Coverage 76.94% 76.69% -0.25%
==========================================
Files 986 996 +10
Lines 51978 52962 +984
Branches 7091 6736 -355
==========================================
+ Hits 39993 40620 +627
- Misses 11759 12117 +358
+ Partials 226 225 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `81.57% <83.40%> (+0.14%)` | :arrow_up: |
| postgres | `81.59% <83.42%> (+0.14%)` | :arrow_up: |
| presto | `81.43% <83.42%> (?)` | |
| python | `81.86% <83.70%> (+0.03%)` | :arrow_up: |
| sqlite | `81.19% <82.13%> (+0.10%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `44.64% <0.00%> (-1.66%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | `37.17% <0.00%> (-0.80%)` | :arrow_down: |
| [...-frontend/src/components/CronPicker/CronPicker.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ3JvblBpY2tlci9Dcm9uUGlja2VyLnRzeA==) | `91.66% <ø> (ø)` | |
| [superset-frontend/src/components/Icons/index.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbnMvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [.../src/components/dataViewCommon/TableCollection.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvZGF0YVZpZXdDb21tb24vVGFibGVDb2xsZWN0aW9uLnRzeA==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/dashboard/actions/hydrate.js](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2h5ZHJhdGUuanM=) | `1.69% <0.00%> (-0.02%)` | :arrow_down: |
| [...rc/dashboard/components/dnd/dragDroppableConfig.js](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9kcmFnRHJvcHBhYmxlQ29uZmlnLmpz) | `31.81% <0.00%> (-3.19%)` | :arrow_down: |
| [...d/src/dashboard/components/gridComponents/Tabs.jsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL1RhYnMuanN4) | `86.48% <0.00%> (-2.41%)` | :arrow_down: |
| [...ters/FiltersConfigModal/FiltersConfigForm/utils.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL3V0aWxzLnRz) | `90.47% <ø> (ø)` | |
| [...nativeFilters/FiltersConfigModal/Footer/Footer.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0Zvb3Rlci9Gb290ZXIudHN4) | `100.00% <ø> (+5.26%)` | :arrow_up: |
| ... and [178 more](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [019e746...4e5d00b](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-895530605
# [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16154](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f8e6994) into [master](https://codecov.io/gh/apache/superset/commit/019e74652d823a90e09851f443f63aea13980005?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (019e746) will **decrease** coverage by `0.33%`.
> The diff coverage is `66.64%`.
> :exclamation: Current head f8e6994 differs from pull request most recent head 7e988e3. Consider uploading reports for the commit 7e988e3 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16154 +/- ##
==========================================
- Coverage 76.94% 76.60% -0.34%
==========================================
Files 986 996 +10
Lines 51978 52962 +984
Branches 7091 6736 -355
==========================================
+ Hits 39993 40571 +578
- Misses 11759 12166 +407
+ Partials 226 225 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `81.57% <83.40%> (+0.14%)` | :arrow_up: |
| postgres | `81.59% <83.42%> (+0.14%)` | :arrow_up: |
| python | `81.68% <83.70%> (-0.15%)` | :arrow_down: |
| sqlite | `81.19% <82.13%> (+0.10%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `44.64% <0.00%> (-1.66%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0UmVuZGVyZXIuanN4) | `37.17% <0.00%> (-0.80%)` | :arrow_down: |
| [...-frontend/src/components/CronPicker/CronPicker.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ3JvblBpY2tlci9Dcm9uUGlja2VyLnRzeA==) | `91.66% <ø> (ø)` | |
| [superset-frontend/src/components/Icons/index.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbnMvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [.../src/components/dataViewCommon/TableCollection.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvZGF0YVZpZXdDb21tb24vVGFibGVDb2xsZWN0aW9uLnRzeA==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/dashboard/actions/hydrate.js](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2h5ZHJhdGUuanM=) | `1.69% <0.00%> (-0.02%)` | :arrow_down: |
| [...rc/dashboard/components/dnd/dragDroppableConfig.js](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9kcmFnRHJvcHBhYmxlQ29uZmlnLmpz) | `31.81% <0.00%> (-3.19%)` | :arrow_down: |
| [...d/src/dashboard/components/gridComponents/Tabs.jsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL1RhYnMuanN4) | `86.48% <0.00%> (-2.41%)` | :arrow_down: |
| [...ters/FiltersConfigModal/FiltersConfigForm/utils.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL3V0aWxzLnRz) | `90.47% <ø> (ø)` | |
| [...nativeFilters/FiltersConfigModal/Footer/Footer.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0Zvb3Rlci9Gb290ZXIudHN4) | `100.00% <ø> (+5.26%)` | :arrow_up: |
| ... and [179 more](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [019e746...7e988e3](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-938012094
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina edited a comment on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
michael-s-molina edited a comment on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-938138868
Can we vertically align the grab icon and text with the trash icon (center)?
<img width="264" alt="Screen Shot 2021-10-07 at 5 41 33 PM" src="https://user-images.githubusercontent.com/70410625/136459023-9614bbf2-48bd-4bdc-8b96-84465f4e3edd.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #16154:
URL: https://github.com/apache/superset/pull/16154#discussion_r699656540
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterTabTitle.tsx
##########
@@ -0,0 +1,203 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { styled, t } from '@superset-ui/core';
+import React, { useRef } from 'react';
+import { DropTargetMonitor, useDrag, useDrop, XYCoord } from 'react-dnd';
+import Icons from 'src/components/Icons';
+import { REMOVAL_DELAY_SECS } from './utils';
+
+interface TabTitleContainerProps {
+ readonly isDragging: boolean;
+}
+const FILTER_TYPE = 'FILTER';
+const StyledFilterTitle = styled.span`
+ white-space: normal;
+ color: ${({ theme }) => theme.colors.grayscale.dark1};
+`;
+const TabTitleContainer = styled.div<TabTitleContainerProps>`
+ ${({ theme, isDragging }) => `
+ display: flex;
+ width: 100%;
+ border-radius: ${theme.borderRadius}px;
+ opacity: ${isDragging ? 0.5 : 1};
+ padding-top: ${theme.gridUnit}px;
+ padding-bottom: ${theme.gridUnit}px;
+ padding-left: ${2 * theme.gridUnit}px;
+ &:hover {
+ transition: all 0.3s;
+ span, .anticon {
+ color: ${theme.colors.primary.dark1};
+ }
+ }
+`}
+`;
Review comment:
```suggestion
const TabTitleContainer = styled.div<TabTitleContainerProps>`
${({ theme, isDragging }) => `
display: flex;
width: 100%;
border-radius: ${theme.borderRadius}px;
opacity: ${isDragging ? 0.5 : 1};
padding-top: ${theme.gridUnit}px;
padding-bottom: ${theme.gridUnit}px;
padding-left: ${2 * theme.gridUnit}px;
&:hover {
transition: all 0.3s;
span, .anticon {
color: ${theme.colors.primary.dark1};
}
}
`}
`;
```
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal.tsx
##########
@@ -208,7 +230,11 @@ export function FiltersConfigModal({
if (values) {
createHandleSave(
filterConfigMap,
- filterIds,
+ filterIds
+ .slice()
+ .sort(
+ (a, b) => orderedFilters.indexOf(a) - orderedFilters.indexOf(b),
+ ),
Review comment:
This code is duplicated in 3 places in this file. Could you extract it to a function?
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterTabs.tsx
##########
@@ -111,36 +71,42 @@ const FilterTabsContainer = styled(LineEditableTabs)`
.ant-tabs-nav-list {
overflow-x: hidden;
overflow-y: auto;
+ width: 270px;
padding-top: ${theme.gridUnit * 2}px;
padding-right: ${theme.gridUnit}px;
padding-bottom: ${theme.gridUnit * 3}px;
padding-left: ${theme.gridUnit * 3}px;
- width: 270px;
}
// extra selector specificity:
&.ant-tabs-card > .ant-tabs-nav .ant-tabs-tab {
- min-width: ${FILTER_WIDTH}px;
- margin: 0 ${theme.gridUnit * 2}px 0 0;
- padding: ${theme.gridUnit}px
- ${theme.gridUnit * 2}px;
- &:hover,
+ margin: 0;
+ padding: 0;
&-active {
color: ${theme.colors.grayscale.dark1};
- border-radius: ${theme.borderRadius}px;
+ margin-bottom: ${theme.gridUnit / 2}px;
background-color: ${theme.colors.secondary.light4};
.ant-tabs-tab-remove > span {
color: ${theme.colors.grayscale.base};
transition: all 0.3s;
}
+ .anticon {
+ color: ${theme.colors.grayscale.base};
+ }
+ :hover{
+ span {
+ color: ${theme.colors.grayscale.base} !important;
Review comment:
We try to always avoid `!important`. Can you find another way to override the color? You can increase the specificity using `&`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina removed a comment on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
michael-s-molina removed a comment on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-934600127
/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-927645824
⚠️ @m-ajay Your base branch `master` has just also updated `superset/migrations`.
❗ **Please consider rebasing your branch to avoid db migration conflicts.**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] removed a comment on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
github-actions[bot] removed a comment on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-934603872
@michael-s-molina Ephemeral environment spinning up at http://54.188.145.74:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #16154:
URL: https://github.com/apache/superset/pull/16154#discussion_r728873140
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx
##########
@@ -92,19 +92,25 @@ import {
} from '../FiltersConfigModal';
import DatasetSelect from './DatasetSelect';
-const { TabPane } = Tabs;
+const TabPane = styled(Tabs.TabPane)`
+ padding: ${({ theme }) => theme.gridUnit * 4}px 0px;
+`;
const StyledContainer = styled.div`
- display: flex;
- flex-direction: row-reverse;
- justify-content: space-between;
+ ${({ theme }) => `
+ display: flex;
+ flex-direction: row-reverse;
+ justify-content: space-between;
+ padding: 0px ${theme.gridUnit * 4}px;
+`}
Review comment:
```suggestion
`}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jinghua-qa commented on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
jinghua-qa commented on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-944480464
LGTM!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-942488580
/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat edited a comment on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
graceguo-supercat edited a comment on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-909743589
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-895530605
# [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16154](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d3ee2f7) into [master](https://codecov.io/gh/apache/superset/commit/87baac7650bdb6a8f8f82cf4992567a2c5c73cba?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (87baac7) will **decrease** coverage by `0.16%`.
> The diff coverage is `90.19%`.
> :exclamation: Current head d3ee2f7 differs from pull request most recent head fa5fc03. Consider uploading reports for the commit fa5fc03 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16154 +/- ##
==========================================
- Coverage 76.97% 76.81% -0.17%
==========================================
Files 1022 1006 -16
Lines 54903 54110 -793
Branches 7485 7332 -153
==========================================
- Hits 42262 41562 -700
+ Misses 12393 12308 -85
+ Partials 248 240 -8
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.35% <ø> (-0.11%)` | :arrow_down: |
| mysql | `81.69% <ø> (-0.16%)` | :arrow_down: |
| postgres | `81.75% <ø> (-0.16%)` | :arrow_down: |
| presto | `?` | |
| python | `82.15% <ø> (-0.27%)` | :arrow_down: |
| sqlite | `81.41% <ø> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nfigModal/FiltersConfigForm/CollapsibleControl.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0NvbGxhcHNpYmxlQ29udHJvbC50c3g=) | `88.46% <0.00%> (ø)` | |
| [...mponents/nativeFilters/FiltersConfigModal/utils.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL3V0aWxzLnRz) | `72.22% <0.00%> (+1.33%)` | :arrow_up: |
| [...nd/src/dashboard/components/nativeFilters/state.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc3RhdGUudHM=) | `75.00% <0.00%> (ø)` | |
| [...nd/src/dashboard/components/nativeFilters/utils.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdXRpbHMudHM=) | `56.25% <ø> (ø)` | |
| [...ilters/FilterBar/FilterControls/FilterControls.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlckNvbnRyb2xzLnRzeA==) | `80.00% <75.00%> (ø)` | |
| [...eFilters/FiltersConfigModal/FiltersConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdNb2RhbC50c3g=) | `94.31% <96.87%> (+5.85%)` | :arrow_up: |
| [...ts/nativeFilters/FiltersConfigModal/FilterTabs.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlclRhYnMudHN4) | `86.66% <100.00%> (ø)` | |
| [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `73.20% <100.00%> (-0.63%)` | :arrow_down: |
| [...nd/src/dashboard/components/nativeFilters/types.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdHlwZXMudHM=) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/components/Select/utils.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3V0aWxzLnRz) | `61.53% <0.00%> (-30.77%)` | :arrow_down: |
| ... and [186 more](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [87baac7...fa5fc03](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-938012576
/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-895530605
# [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16154](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1b2a88f) into [master](https://codecov.io/gh/apache/superset/commit/93ebe3d963c857ccc4185ef3ca5c6175397e17c9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (93ebe3d) will **decrease** coverage by `0.35%`.
> The diff coverage is `76.63%`.
> :exclamation: Current head 1b2a88f differs from pull request most recent head 0ff99c4. Consider uploading reports for the commit 0ff99c4 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16154 +/- ##
==========================================
- Coverage 76.93% 76.58% -0.36%
==========================================
Files 1030 1028 -2
Lines 55019 55023 +4
Branches 7465 7499 +34
==========================================
- Hits 42331 42140 -191
- Misses 12434 12633 +199
+ Partials 254 250 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `70.24% <76.63%> (-0.68%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ilters/FilterBar/FilterControls/FilterControls.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlckNvbnRyb2xzLnRzeA==) | `26.66% <0.00%> (-53.34%)` | :arrow_down: |
| [...nd/src/dashboard/components/nativeFilters/state.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc3RhdGUudHM=) | `26.31% <0.00%> (-48.69%)` | :arrow_down: |
| [...ilters/FiltersConfigModal/FilterTitleContainer.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlclRpdGxlQ29udGFpbmVyLnRzeA==) | `57.69% <57.69%> (ø)` | |
| [...mponents/nativeFilters/FiltersConfigModal/utils.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL3V0aWxzLnRz) | `69.10% <63.04%> (-1.79%)` | :arrow_down: |
| [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `73.71% <78.57%> (-0.13%)` | :arrow_down: |
| [...eFilters/FiltersConfigModal/FiltersConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdNb2RhbC50c3g=) | `88.02% <86.53%> (-1.40%)` | :arrow_down: |
| [...tiveFilters/FiltersConfigModal/FilterTitlePane.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlclRpdGxlUGFuZS50c3g=) | `90.90% <90.90%> (ø)` | |
| [...tiveFilters/FiltersConfigModal/DraggableFilter.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0RyYWdnYWJsZUZpbHRlci50c3g=) | `92.10% <92.10%> (ø)` | |
| [...Filters/FiltersConfigModal/FilterConfigurePane.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlckNvbmZpZ3VyZVBhbmUudHN4) | `100.00% <100.00%> (ø)` | |
| [...odal/FiltersConfigForm/FilterScope/FilterScope.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL0ZpbHRlclNjb3BlLnRzeA==) | `89.13% <100.00%> (+0.24%)` | :arrow_up: |
| ... and [40 more](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [93ebe3d...0ff99c4](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-899791917
https://user-images.githubusercontent.com/70410625/129623964-edf862ba-0938-4658-9345-6959eb0dfb1d.mov
- Show the unsaved changes message if the user reorders a filter and presses cancel
- After canceling, the original order should be preserved. Currently, it's not canceling the reordering.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #16154:
URL: https://github.com/apache/superset/pull/16154#discussion_r699656540
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterTabTitle.tsx
##########
@@ -0,0 +1,203 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { styled, t } from '@superset-ui/core';
+import React, { useRef } from 'react';
+import { DropTargetMonitor, useDrag, useDrop, XYCoord } from 'react-dnd';
+import Icons from 'src/components/Icons';
+import { REMOVAL_DELAY_SECS } from './utils';
+
+interface TabTitleContainerProps {
+ readonly isDragging: boolean;
+}
+const FILTER_TYPE = 'FILTER';
+const StyledFilterTitle = styled.span`
+ white-space: normal;
+ color: ${({ theme }) => theme.colors.grayscale.dark1};
+`;
+const TabTitleContainer = styled.div<TabTitleContainerProps>`
+ ${({ theme, isDragging }) => `
+ display: flex;
+ width: 100%;
+ border-radius: ${theme.borderRadius}px;
+ opacity: ${isDragging ? 0.5 : 1};
+ padding-top: ${theme.gridUnit}px;
+ padding-bottom: ${theme.gridUnit}px;
+ padding-left: ${2 * theme.gridUnit}px;
+ &:hover {
+ transition: all 0.3s;
+ span, .anticon {
+ color: ${theme.colors.primary.dark1};
+ }
+ }
+`}
+`;
Review comment:
```suggestion
const TabTitleContainer = styled.div<TabTitleContainerProps>`
${({ theme, isDragging }) => `
display: flex;
width: 100%;
border-radius: ${theme.borderRadius}px;
opacity: ${isDragging ? 0.5 : 1};
padding-top: ${theme.gridUnit}px;
padding-bottom: ${theme.gridUnit}px;
padding-left: ${2 * theme.gridUnit}px;
&:hover {
transition: all 0.3s;
span, .anticon {
color: ${theme.colors.primary.dark1};
}
}
`}
`;
```
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal.tsx
##########
@@ -208,7 +230,11 @@ export function FiltersConfigModal({
if (values) {
createHandleSave(
filterConfigMap,
- filterIds,
+ filterIds
+ .slice()
+ .sort(
+ (a, b) => orderedFilters.indexOf(a) - orderedFilters.indexOf(b),
+ ),
Review comment:
This code is duplicated in 3 places in this file. Could you extract it to a function?
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterTabs.tsx
##########
@@ -111,36 +71,42 @@ const FilterTabsContainer = styled(LineEditableTabs)`
.ant-tabs-nav-list {
overflow-x: hidden;
overflow-y: auto;
+ width: 270px;
padding-top: ${theme.gridUnit * 2}px;
padding-right: ${theme.gridUnit}px;
padding-bottom: ${theme.gridUnit * 3}px;
padding-left: ${theme.gridUnit * 3}px;
- width: 270px;
}
// extra selector specificity:
&.ant-tabs-card > .ant-tabs-nav .ant-tabs-tab {
- min-width: ${FILTER_WIDTH}px;
- margin: 0 ${theme.gridUnit * 2}px 0 0;
- padding: ${theme.gridUnit}px
- ${theme.gridUnit * 2}px;
- &:hover,
+ margin: 0;
+ padding: 0;
&-active {
color: ${theme.colors.grayscale.dark1};
- border-radius: ${theme.borderRadius}px;
+ margin-bottom: ${theme.gridUnit / 2}px;
background-color: ${theme.colors.secondary.light4};
.ant-tabs-tab-remove > span {
color: ${theme.colors.grayscale.base};
transition: all 0.3s;
}
+ .anticon {
+ color: ${theme.colors.grayscale.base};
+ }
+ :hover{
+ span {
+ color: ${theme.colors.grayscale.base} !important;
Review comment:
We try to always avoid `!important`. Can you find another way to override the color? You can increase the specificity using `&`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-895530605
# [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16154](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8a52631) into [master](https://codecov.io/gh/apache/superset/commit/519baa6f005a67c13ab13ad4bc2776f73afabed0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (519baa6) will **decrease** coverage by `0.27%`.
> The diff coverage is `61.22%`.
> :exclamation: Current head 8a52631 differs from pull request most recent head d3ee2f7. Consider uploading reports for the commit d3ee2f7 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16154 +/- ##
==========================================
- Coverage 76.77% 76.50% -0.28%
==========================================
Files 1003 1001 -2
Lines 53959 53568 -391
Branches 7330 6829 -501
==========================================
- Hits 41427 40982 -445
- Misses 12293 12347 +54
Partials 239 239
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `70.59% <61.22%> (-0.49%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...mponents/nativeFilters/FiltersConfigModal/utils.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL3V0aWxzLnRz) | `72.60% <0.00%> (-1.01%)` | :arrow_down: |
| [...nd/src/dashboard/components/nativeFilters/state.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc3RhdGUudHM=) | `73.68% <0.00%> (-1.32%)` | :arrow_down: |
| [...ilters/FilterBar/FilterControls/FilterControls.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlckNvbnRyb2xzLnRzeA==) | `80.00% <50.00%> (ø)` | |
| [...ativeFilters/FiltersConfigModal/FilterTabTitle.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlclRhYlRpdGxlLnRzeA==) | `54.54% <54.54%> (ø)` | |
| [...ts/nativeFilters/FiltersConfigModal/FilterTabs.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlclRhYnMudHN4) | `87.50% <66.66%> (+0.83%)` | :arrow_up: |
| [...eFilters/FiltersConfigModal/FiltersConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdNb2RhbC50c3g=) | `90.17% <79.41%> (-5.28%)` | :arrow_down: |
| [superset-frontend/src/setup/setupPlugins.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2lucy50cw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupPluginsExtra.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2luc0V4dHJhLnRz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `0.00% <0.00%> (-80.00%)` | :arrow_down: |
| [...c/visualizations/FilterBox/FilterBoxChartPlugin.js](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3hDaGFydFBsdWdpbi5qcw==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| ... and [94 more](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [519baa6...d3ee2f7](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-934603872
@michael-s-molina Ephemeral environment spinning up at http://54.188.145.74:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-938015937
@michael-s-molina Ephemeral environment spinning up at http://34.219.199.3:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-895530605
# [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16154](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d3ee2f7) into [master](https://codecov.io/gh/apache/superset/commit/87baac7650bdb6a8f8f82cf4992567a2c5c73cba?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (87baac7) will **decrease** coverage by `0.16%`.
> The diff coverage is `90.19%`.
> :exclamation: Current head d3ee2f7 differs from pull request most recent head 575c201. Consider uploading reports for the commit 575c201 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16154 +/- ##
==========================================
- Coverage 76.97% 76.81% -0.17%
==========================================
Files 1022 1006 -16
Lines 54903 54110 -793
Branches 7485 7332 -153
==========================================
- Hits 42262 41562 -700
+ Misses 12393 12308 -85
+ Partials 248 240 -8
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.35% <ø> (-0.11%)` | :arrow_down: |
| mysql | `81.69% <ø> (-0.16%)` | :arrow_down: |
| postgres | `81.75% <ø> (-0.16%)` | :arrow_down: |
| presto | `?` | |
| python | `82.15% <ø> (-0.27%)` | :arrow_down: |
| sqlite | `81.41% <ø> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nfigModal/FiltersConfigForm/CollapsibleControl.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0NvbGxhcHNpYmxlQ29udHJvbC50c3g=) | `88.46% <0.00%> (ø)` | |
| [...mponents/nativeFilters/FiltersConfigModal/utils.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL3V0aWxzLnRz) | `72.22% <0.00%> (+1.33%)` | :arrow_up: |
| [...nd/src/dashboard/components/nativeFilters/state.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc3RhdGUudHM=) | `75.00% <0.00%> (ø)` | |
| [...nd/src/dashboard/components/nativeFilters/utils.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdXRpbHMudHM=) | `56.25% <ø> (ø)` | |
| [...ilters/FilterBar/FilterControls/FilterControls.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlckNvbnRyb2xzLnRzeA==) | `80.00% <75.00%> (ø)` | |
| [...eFilters/FiltersConfigModal/FiltersConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdNb2RhbC50c3g=) | `94.31% <96.87%> (+5.85%)` | :arrow_up: |
| [...ts/nativeFilters/FiltersConfigModal/FilterTabs.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlclRhYnMudHN4) | `86.66% <100.00%> (ø)` | |
| [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `73.20% <100.00%> (-0.63%)` | :arrow_down: |
| [...nd/src/dashboard/components/nativeFilters/types.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdHlwZXMudHM=) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/components/Select/utils.ts](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3V0aWxzLnRz) | `61.53% <0.00%> (-30.77%)` | :arrow_down: |
| ... and [186 more](https://codecov.io/gh/apache/superset/pull/16154/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [87baac7...575c201](https://codecov.io/gh/apache/superset/pull/16154?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina edited a comment on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
michael-s-molina edited a comment on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-931311793
Hi @m-ajay. This [PR](https://github.com/apache/superset/pull/16919) contains the drag icon. You also need to adjust the cursor accordingly (grab, grabbing).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina edited a comment on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
michael-s-molina edited a comment on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-938138868
Can we vertically align the grab icon and text with the trash icon (center):
<img width="264" alt="Screen Shot 2021-10-07 at 5 41 33 PM" src="https://user-images.githubusercontent.com/70410625/136459023-9614bbf2-48bd-4bdc-8b96-84465f4e3edd.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-895594262
@junlincc Ephemeral environment spinning up at http://34.209.125.69:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #16154: feat(dashboard): Let users re-arrange native filters
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #16154:
URL: https://github.com/apache/superset/pull/16154#discussion_r689808197
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBar.test.tsx
##########
@@ -219,11 +221,16 @@ describe('FilterBar', () => {
});
const renderWrapper = (props = closedBarProps, state?: object) =>
- render(<FilterBar {...props} width={280} height={400} offset={0} />, {
- useRedux: true,
- initialState: state,
- useRouter: true,
- });
+ render(
+ <DndProvider backend={HTML5Backend}>
+ <FilterBar {...props} width={280} height={400} offset={0} />
+ </DndProvider>,
+ {
+ useRedux: true,
+ initialState: state,
+ useRouter: true,
+ },
+ );
Review comment:
```suggestion
render(<FilterBar {...props} width={280} height={400} offset={0} />, {
useRedux: true,
initialState: state,
useRouter: true,
useDnd: true,
});
```
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal.test.tsx
##########
@@ -30,6 +30,8 @@ import {
import { render, screen, waitFor } from 'spec/helpers/testing-library';
import mockDatasource, { id, datasourceId } from 'spec/fixtures/mockDatasource';
import chartQueries from 'spec/fixtures/mockChartQueries';
+import { DndProvider } from 'react-dnd';
+import { HTML5Backend } from 'react-dnd-html5-backend';
Review comment:
```suggestion
```
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal.test.tsx
##########
@@ -149,10 +151,15 @@ beforeAll(() => {
});
function defaultRender(initialState = defaultState()) {
- return render(<FiltersConfigModal {...props} />, {
- useRedux: true,
- initialState,
- });
+ return render(
+ <DndProvider backend={HTML5Backend}>
+ <FiltersConfigModal {...props} />
+ </DndProvider>,
+ {
+ useRedux: true,
+ initialState,
+ },
+ );
Review comment:
```suggestion
return render(<FiltersConfigModal {...props} />, {
useRedux: true,
useDnd: true,
initialState,
});
```
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterTabTitle.tsx
##########
@@ -0,0 +1,196 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { styled, t } from '@superset-ui/core';
+import React, { useRef } from 'react';
+import { DropTargetMonitor, useDrag, useDrop, XYCoord } from 'react-dnd';
+import Icons from 'src/components/Icons';
+import { REMOVAL_DELAY_SECS } from './utils';
+
+const FILTER_TYPE = 'FILTER';
+const StyledFilterTitle = styled.span`
+ white-space: normal;
+ color: ${({ theme }) => theme.colors.grayscale.dark1};
+`;
+const TabTitleContainer = styled.div`
+ display: flex;
+ width: 100%;
+ border-radius: ${({ theme }) => theme.gridUnit}px;
+`;
+const StyledFilterTabTitle = styled.span`
+ transition: color ${({ theme }) => theme.transitionTiming}s;
+ width: 100%;
+ display: flex;
+ flex-direction: row;
+ justify-content: space-between;
+
+ @keyframes tabTitleRemovalAnimation {
+ 0%,
+ 90% {
+ opacity: 1;
+ }
+ 95%,
+ 100% {
+ opacity: 0;
+ }
+ }
+
+ &.removed {
+ color: ${({ theme }) => theme.colors.warning.dark1};
+ transform-origin: top;
+ animation-name: tabTitleRemovalAnimation;
+ animation-duration: ${REMOVAL_DELAY_SECS}s;
+ }
+`;
+const StyledSpan = styled.span`
+ cursor: pointer;
+ color: ${({ theme }) => theme.colors.primary.dark1};
+ &:hover {
+ color: ${({ theme }) => theme.colors.primary.dark2};
+ }
+`;
+
+const StyledTrashIcon = styled(Icons.Trash)`
+ color: ${({ theme }) => theme.colors.grayscale.light3};
+ &:hover {
+ color: ${({ theme }) => theme.colors.primary.dark2};
+ }
+`;
+
+interface FilterTabTitleProps {
+ id: string;
+ isRemoved: boolean;
+ index: number;
+ getFilterTitle: (id: string) => string;
+ restoreFilter: (id: string) => void;
+ onRearrage: (itemId: string, targetIndex: number) => void;
+ onRemove: (id: string) => void;
+}
+
+interface DragItem {
+ index: number;
+ id: string;
+ type: string;
+}
+
+export const FilterTabTitle: React.FC<FilterTabTitleProps> = ({
+ id,
+ index,
+ isRemoved,
+ getFilterTitle,
+ restoreFilter,
+ onRearrage,
+ onRemove,
+}) => {
+ const ref = useRef<HTMLDivElement>(null);
+ const [{ isDragging }, drag] = useDrag({
+ item: { id, type: FILTER_TYPE, index },
+ collect: (monitor: any) => ({
+ isDragging: monitor.isDragging(),
+ }),
+ });
+ const [, drop] = useDrop({
+ accept: FILTER_TYPE,
+ hover: (item: DragItem, monitor: DropTargetMonitor) => {
+ if (!ref.current) {
+ return;
+ }
+
+ const dragIndex = item.index;
+ const hoverIndex = index;
+
+ // Don't replace items with themselves
+ if (dragIndex === hoverIndex) {
+ return;
+ }
+ // Determine rectangle on screen
+ const hoverBoundingRect = ref.current?.getBoundingClientRect();
+
+ // Get vertical middle
+ const hoverMiddleY =
+ (hoverBoundingRect.bottom - hoverBoundingRect.top) / 2;
+
+ // Determine mouse position
+ const clientOffset = monitor.getClientOffset();
+
+ // Get pixels to the top
+ const hoverClientY = (clientOffset as XYCoord).y - hoverBoundingRect.top;
+
+ // Only perform the move when the mouse has crossed half of the items height
+ // When dragging downwards, only move when the cursor is below 50%
+ // When dragging upwards, only move when the cursor is above 50%
+
+ // Dragging downwards
+ if (dragIndex < hoverIndex && hoverClientY < hoverMiddleY) {
+ return;
+ }
+
+ // Dragging upwards
+ if (dragIndex > hoverIndex && hoverClientY > hoverMiddleY) {
+ return;
+ }
+
+ onRearrage(item.id, index);
+ // Note: we're mutating the monitor item here.
+ // Generally it's better to avoid mutations,
+ // but it's good here for the sake of performance
+ // to avoid expensive index searches.
+ // eslint-disable-next-line no-param-reassign
+ item.index = hoverIndex;
+ },
+ });
+ drag(drop(ref));
+ return (
+ <TabTitleContainer
+ ref={ref}
+ style={{
Review comment:
It would be nice to pass `isDragging` to `TabTitleContainer` to keep all the styles in one place.
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBar.test.tsx
##########
@@ -29,6 +29,8 @@ import { TimeFilterPlugin, SelectFilterPlugin } from 'src/filters/components';
import { DATE_FILTER_CONTROL_TEST_ID } from 'src/explore/components/controls/DateFilterControl/DateFilterLabel';
import fetchMock from 'fetch-mock';
import { waitFor } from '@testing-library/react';
+import { DndProvider } from 'react-dnd';
+import { HTML5Backend } from 'react-dnd-html5-backend';
Review comment:
```suggestion
```
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterTabTitle.tsx
##########
@@ -0,0 +1,196 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { styled, t } from '@superset-ui/core';
+import React, { useRef } from 'react';
+import { DropTargetMonitor, useDrag, useDrop, XYCoord } from 'react-dnd';
+import Icons from 'src/components/Icons';
+import { REMOVAL_DELAY_SECS } from './utils';
+
+const FILTER_TYPE = 'FILTER';
+const StyledFilterTitle = styled.span`
+ white-space: normal;
+ color: ${({ theme }) => theme.colors.grayscale.dark1};
+`;
+const TabTitleContainer = styled.div`
+ display: flex;
+ width: 100%;
+ border-radius: ${({ theme }) => theme.gridUnit}px;
+`;
+const StyledFilterTabTitle = styled.span`
+ transition: color ${({ theme }) => theme.transitionTiming}s;
+ width: 100%;
+ display: flex;
+ flex-direction: row;
+ justify-content: space-between;
+
+ @keyframes tabTitleRemovalAnimation {
+ 0%,
+ 90% {
+ opacity: 1;
+ }
+ 95%,
+ 100% {
+ opacity: 0;
+ }
+ }
+
+ &.removed {
+ color: ${({ theme }) => theme.colors.warning.dark1};
+ transform-origin: top;
+ animation-name: tabTitleRemovalAnimation;
+ animation-duration: ${REMOVAL_DELAY_SECS}s;
+ }
+`;
+const StyledSpan = styled.span`
+ cursor: pointer;
+ color: ${({ theme }) => theme.colors.primary.dark1};
+ &:hover {
+ color: ${({ theme }) => theme.colors.primary.dark2};
+ }
+`;
+
+const StyledTrashIcon = styled(Icons.Trash)`
+ color: ${({ theme }) => theme.colors.grayscale.light3};
+ &:hover {
+ color: ${({ theme }) => theme.colors.primary.dark2};
+ }
+`;
+
+interface FilterTabTitleProps {
+ id: string;
+ isRemoved: boolean;
+ index: number;
+ getFilterTitle: (id: string) => string;
+ restoreFilter: (id: string) => void;
+ onRearrage: (itemId: string, targetIndex: number) => void;
+ onRemove: (id: string) => void;
+}
+
+interface DragItem {
+ index: number;
+ id: string;
+ type: string;
+}
+
+export const FilterTabTitle: React.FC<FilterTabTitleProps> = ({
+ id,
+ index,
+ isRemoved,
+ getFilterTitle,
+ restoreFilter,
+ onRearrage,
+ onRemove,
+}) => {
+ const ref = useRef<HTMLDivElement>(null);
+ const [{ isDragging }, drag] = useDrag({
+ item: { id, type: FILTER_TYPE, index },
+ collect: (monitor: any) => ({
+ isDragging: monitor.isDragging(),
+ }),
+ });
+ const [, drop] = useDrop({
+ accept: FILTER_TYPE,
+ hover: (item: DragItem, monitor: DropTargetMonitor) => {
+ if (!ref.current) {
+ return;
+ }
+
+ const dragIndex = item.index;
+ const hoverIndex = index;
+
+ // Don't replace items with themselves
+ if (dragIndex === hoverIndex) {
+ return;
+ }
+ // Determine rectangle on screen
+ const hoverBoundingRect = ref.current?.getBoundingClientRect();
+
+ // Get vertical middle
+ const hoverMiddleY =
+ (hoverBoundingRect.bottom - hoverBoundingRect.top) / 2;
+
+ // Determine mouse position
+ const clientOffset = monitor.getClientOffset();
+
+ // Get pixels to the top
+ const hoverClientY = (clientOffset as XYCoord).y - hoverBoundingRect.top;
+
+ // Only perform the move when the mouse has crossed half of the items height
+ // When dragging downwards, only move when the cursor is below 50%
+ // When dragging upwards, only move when the cursor is above 50%
+
+ // Dragging downwards
+ if (dragIndex < hoverIndex && hoverClientY < hoverMiddleY) {
+ return;
+ }
+
+ // Dragging upwards
+ if (dragIndex > hoverIndex && hoverClientY > hoverMiddleY) {
+ return;
+ }
+
+ onRearrage(item.id, index);
+ // Note: we're mutating the monitor item here.
+ // Generally it's better to avoid mutations,
+ // but it's good here for the sake of performance
+ // to avoid expensive index searches.
+ // eslint-disable-next-line no-param-reassign
+ item.index = hoverIndex;
+ },
+ });
+ drag(drop(ref));
+ return (
+ <TabTitleContainer
+ ref={ref}
+ style={{
+ opacity: isDragging ? 0.5 : 1,
+ }}
+ >
+ <StyledFilterTabTitle className={isRemoved ? 'removed' : ''}>
+ <StyledFilterTitle>
+ {isRemoved ? t('(Removed)') : getFilterTitle(id)}
+ </StyledFilterTitle>
+ {isRemoved && (
+ <StyledSpan
+ role="button"
+ data-test="undo-button"
+ tabIndex={0}
+ onClick={() => restoreFilter(id)}
+ >
+ {t('Undo?')}
+ </StyledSpan>
+ )}
+ </StyledFilterTabTitle>
+ <div style={{ alignSelf: 'flex-end' }}>
Review comment:
Avoid using `style`. Currently, we are using Emotion `styled` or `css` depending on the situation. You can check this [guide](https://github.com/apache/superset/issues/15264) for more information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org