[jira] [Commented] (HBASE-19682) Use Collections.emptyList() For Empty List Values

["Mike Drob (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-19682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16396458#comment-16396458 ] 

Mike Drob commented on HBASE-19682:
-----------------------------------

Patch looks good to me but I haven't looked at the older ones to see the delta.

@appy returning iterable is awkward because it doesn't have size method.

> Use Collections.emptyList() For Empty List Values
> -------------------------------------------------
>
>                 Key: HBASE-19682
>                 URL: https://issues.apache.org/jira/browse/HBASE-19682
>             Project: HBase
>          Issue Type: Improvement
>          Components: hbase
>    Affects Versions: 3.0.0
>            Reporter: BELUGA BEHR
>            Assignee: BELUGA BEHR
>            Priority: Minor
>         Attachments: HBASE-19682.1.patch, HBASE-19682.2.patch, HBASE-19682.3.1.patch, HBASE-19682.4.patch, example.patch
>
>
> Use {{Collection.emptyList()}} for returning an empty list instead of {{return new ArrayList<> ()}}.  The default constructor creates a buffer of size 10 for _ArrayList_ therefore, returning this static value saves on some memory and GC pressure and saves time not having to allocate a new internally buffer for each instantiation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)