[GitHub] [libcloud] shengwubin commented on pull request #1796: Fix Aliyun OSS storage upload_object KeyError: 'ETag' issue

["shengwubin (via GitHub)" <gi...@apache.org>]

shengwubin commented on PR #1796:
URL: https://github.com/apache/libcloud/pull/1796#issuecomment-1399397932

   > Looks like this still needs more work since tests are now failing with:
   > 
   > ```shell
   > >       result_dict = self._upload_object(
   >             object_name=object_name,
   >             content_type=content_type,
   >             request_path=request_path,
   >             request_method=method,
   >             headers=headers,
   >             file_path=file_path,
   >             stream=stream,
   >             container=container,
   >         )
   > E       TypeError: upload_file() got an unexpected keyword argument 'container'
   > ```
   
   @Kami I add `container=container` to the oss storage test cases. The issue here is that when replacing the original `_upload_object` with `upload_file`, the argument `container` is missing


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org