You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by robertkowalski <gi...@git.apache.org> on 2015/03/02 18:12:17 UTC
[GitHub] couchdb-fauxton pull request: fix broken api-url link
GitHub user robertkowalski opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/298
fix broken api-url link
also removes unused parameter from function, the only usage of
`indexedDocs.urlRef` is in `routes-index-editor.js`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertkowalski/couchdb-fauxton fix-url-views
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/298.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #298
----
commit bbebeb7e0538588934ff82ac5bb8814c3b50c4b3
Author: Robert Kowalski <ro...@apache.org>
Date: 2015-03-02T17:09:28Z
fix broken api-url link
also removes unused parameter from function, the only usage of
`indexedDocs.urlRef` is in `routes-index-editor.js`
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: fix broken api-url link
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/298#discussion_r25623841
--- Diff: app/addons/documents/tests/resourcesSpec.js ---
@@ -29,7 +29,11 @@ define([
database: {id: 'databaseId', safeID: function () { return this.id; }},
design: '_design/myDoc'
});
+ });
+
+ it('does not remove an id attribute', function () {
--- End diff --
accidental newline?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: fix broken api-url link
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/298#issuecomment-76909105
merged as bbebeb7e0538588934ff82ac5bb8814c3b50c4b3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: fix broken api-url link
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/298#issuecomment-76872594
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: fix broken api-url link
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/298#discussion_r25671444
--- Diff: app/addons/documents/tests/resourcesSpec.js ---
@@ -29,7 +29,11 @@ define([
database: {id: 'databaseId', safeID: function () { return this.id; }},
design: '_design/myDoc'
});
+ });
+
+ it('does not remove an id attribute', function () {
--- End diff --
no, we often make a newline before the final assertion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: fix broken api-url link
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/298
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---