You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by robertkowalski <gi...@git.apache.org> on 2014/11/10 13:47:35 UTC
[GitHub] couchdb-fauxton pull request: Stay on same page after logout
GitHub user robertkowalski opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/143
Stay on same page after logout
If the anonymous user does not have the permissions, they are
redirected to the login in the next step.
Closes COUCHDB-2435
---
Only exception here are actions that don't open a new page, e.g. in a database that is only accessible as admin, logout and click `changes`. You will get a spinning wheel of death and an error notification. So far no general solution came to my mind, open for suggestions!
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertkowalski/couchdb-fauxton COUCHDB-2435-logout-stay-on-page
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/143.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #143
----
commit 614854c0aa4dabcf438d93e925c2d149ede50db1
Author: Robert Kowalski <ro...@apache.org>
Date: 2014-11-10T10:23:03Z
navbar: fix intendation
commit 7b49270a36423f66adbb993da48be507c3a4ea20
Author: Robert Kowalski <ro...@apache.org>
Date: 2014-11-10T10:24:01Z
Stay on same page after logout
If the anonymous user does not have the permissions, they are
redirected to the login in the next step.
Closes COUCHDB-2435
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Stay on same page after logout
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/143#issuecomment-62873655
For now I would just like to land 614854c (the intendation fix) and close this until we have a good solution.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Stay on same page after logout
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/143#issuecomment-62410566
Hey @robertkowalski - nice! Very excited about this one. Question: when being logged out and going to the Databases, Active Tasks and Config pages, it shows the Permissions Denied page. But when logged in and on one of those pages, clicking logout leaves the page intact. Shouldn’t it show the Login page instead?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Stay on same page after logout
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/143#issuecomment-62592441
Spoke with Robert, this looks good. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Stay on same page after logout
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/143
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Stay on same page after logout
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/143#issuecomment-62632151
Let's discuss this again tomorrow
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Stay on same page after logout
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/143#issuecomment-62935890
Sounds good. +1 on landing the indentation fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---