[GitHub] [skywalking-cli] Alexxxing commented on a diff in pull request #143: feature: update install.sh version regex

[GitBox <gi...@apache.org>]

Alexxxing commented on code in PR #143:
URL: https://github.com/apache/skywalking-cli/pull/143#discussion_r849166048


##########
scripts/install.sh:
##########
@@ -51,7 +51,7 @@ done
 OS=$(echo $OS | awk '{print tolower($0)}')
 
 # Get the latest version of swctl.
-VERSION=$(curl "https://raw.githubusercontent.com/apache/skywalking-website/master/data/releases.yml" | grep --after-context=7 "name: SkyWalking CLI" | grep "version" | grep -o "[0-9].[0-9].[0-9]")
+VERSION=$(curl "https://raw.githubusercontent.com/apache/skywalking-website/master/data/releases.yml" | grep --after-context=7 "name: SkyWalking CLI" | grep "version" | grep -Eo "[0-9].[0-9]+.[0-9]")

Review Comment:
   I can't install skywalking-cli on Centos 7.x，the match result is None，i need to modify the install.sh regex to install skywalking-cli v0.10.0



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org