You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/03 17:03:10 UTC
[GitHub] [spark] Yikun opened a new pull request, #37399: [SPARK-39959][BUILD][INFRA] Pin roxygen2 version to 7.2.0 in infra
Yikun opened a new pull request, #37399:
URL: https://github.com/apache/spark/pull/37399
### What changes were proposed in this pull request?
Pin `roxygen2` to 7.2.0 to make sparkr job work
### Why are the changes needed?
R job failed due to `checking for missing documentation entries`
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
All CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #37399: [SPARK-39959][BUILD][INFRA] Pin roxygen2 version to 7.2.0 in infra
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #37399:
URL: https://github.com/apache/spark/pull/37399#issuecomment-1204708254
Thanks @Yikun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #37399: [SPARK-39959][BUILD][INFRA] Pin roxygen2 version to 7.2.0 in infra
Posted by GitBox <gi...@apache.org>.
Yikun commented on PR #37399:
URL: https://github.com/apache/spark/pull/37399#issuecomment-1204698781
@dongjoon-hyun @HyukjinKwon Thanks, I do a local test in my repo all works well!
I also take a deep look on why cache not working: the `ubuntu:20.04` hash changes [before](https://github.com/apache/spark/runs/7552458947?check_suite_focus=true#step:7:115) and [after](https://github.com/apache/spark/runs/7653584220?check_suite_focus=true#step:7:118) cache outdate. (`FROM` is a specific case in docker registry cache, it's not based on static text cache)
There might some improvement in followup:
- https://github.com/apache/spark/pull/37402 Add separate image tag to help debug and recover CI if needed.
- Pin to ubuntu:20.04 to static hash, and only change it when upgrade the hash when manully
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #37399: [SPARK-39959][BUILD][INFRA] Pin roxygen2 version to 7.2.0 in infra
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #37399: [SPARK-39959][BUILD][INFRA] Pin roxygen2 version to 7.2.0 in infra
URL: https://github.com/apache/spark/pull/37399
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #37399: [SPARK-39959][BUILD][INFRA] Pin roxygen2 version to 7.2.0 in infra
Posted by GitBox <gi...@apache.org>.
Yikun commented on PR #37399:
URL: https://github.com/apache/spark/pull/37399#issuecomment-1204245839
- The root reason of sparkr job failed should be `roxygen2` 7.2.0 --> 7.2.1
- Docker cache not working (looks like is outdate for some reason) since 2 days before
- https://www.diffchecker.com/TpOlQsg1 from results, it might related to change on github action docker config change.
- Then do a real time build in each job, thus roxygen2 is upgraded in real time build job.
Solution: merge this if all CI passed (This will also do a cache refresh to make cache back again)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #37399: [SPARK-39959][BUILD][INFRA] Pin roxygen2 version to 7.2.0 in infra
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #37399:
URL: https://github.com/apache/spark/pull/37399#issuecomment-1204561094
Awesome!!!!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org