You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2021/03/29 03:40:49 UTC

svn commit: r1888151 - /pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdfwriter/COSWriter.java

Author: tilman
Date: Mon Mar 29 03:40:48 2021
New Revision: 1888151

URL: http://svn.apache.org/viewvc?rev=1888151&view=rev
Log:
PDFBOX-4892: optimize / simplify, as suggested by valerybokov

Modified:
    pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdfwriter/COSWriter.java

Modified: pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdfwriter/COSWriter.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdfwriter/COSWriter.java?rev=1888151&r1=1888150&r2=1888151&view=diff
==============================================================================
--- pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdfwriter/COSWriter.java (original)
+++ pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdfwriter/COSWriter.java Mon Mar 29 03:40:48 2021
@@ -587,11 +587,11 @@ public class COSWriter implements ICOSVi
         String headerString;
         if (fdfDocument != null)
         {
-            headerString = "%FDF-"+ Float.toString(doc.getVersion());
+            headerString = "%FDF-"+ doc.getVersion();
         }
         else
         {
-            headerString = "%PDF-"+ Float.toString(doc.getVersion());
+            headerString = "%PDF-"+ doc.getVersion();
         }
         getStandardOutput().write( headerString.getBytes(Charsets.ISO_8859_1) );
         
@@ -713,15 +713,18 @@ public class COSWriter implements ICOSVi
         int xRefLength = xRefRanges.length;
         int x = 0;
         int j = 0;
-        while (x < xRefLength && (xRefLength % 2) == 0)
+        if ((xRefLength % 2) == 0)
         {
-            writeXrefRange(xRefRanges[x], xRefRanges[x + 1]);
-
-            for (int i = 0; i < xRefRanges[x + 1]; ++i)
+            while (x < xRefLength)
             {
-                writeXrefEntry(xRefEntries.get(j++));
+                writeXrefRange(xRefRanges[x], xRefRanges[x + 1]);
+
+                for (int i = 0; i < xRefRanges[x + 1]; ++i)
+                {
+                    writeXrefEntry(xRefEntries.get(j++));
+                }
+                x += 2;
             }
-            x += 2;
         }
     }