[GitHub] [dubbo] zrlw commented on a change in pull request #8872: Close status error noclose exception，i think #7410 have bug

[GitBox <gi...@apache.org>]

zrlw commented on a change in pull request #8872:
URL: https://github.com/apache/dubbo/pull/8872#discussion_r713906773



##########
File path: dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/exchange/support/header/HeaderExchangeChannel.java
##########
@@ -168,7 +169,7 @@ public void close(int timeout) {
         if (closed) {
             return;
         }
-        closed = true;
+        close();

Review comment:
       async clients will not receive any result if you move close() here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org