You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gora.apache.org by djkevincr <gi...@git.apache.org> on 2016/09/16 19:45:50 UTC
[GitHub] gora pull request #88: GORA-495 fix
GitHub user djkevincr opened a pull request:
https://github.com/apache/gora/pull/88
GORA-495 fix
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/djkevincr/gora GORA-495
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/gora/pull/88.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #88
----
commit c103f8951106f037b7e2b075c69610372d65aa4c
Author: Kevin Ratnasekera <dj...@yahoo.com>
Date: 2016-09-16T19:43:47Z
GORA-495 fix
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora issue #88: GORA-495 fix
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the issue:
https://github.com/apache/gora/pull/88
Yes it does come from velocity. It's in the record template though I am
sure.
I am +1 to merge and then we can address that issue elsewhere... Actually
we may have already created a hit a issue for it.
On Sep 16, 2016 4:09 PM, "Kevin Ratnasekera" <no...@github.com>
wrote:
> @lewismc <https://github.com/lewismc> I added license headers. I think
> that compiler flag comes from record.vm velocity template,
> How do we proceed with this?
>
> \u2014
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/gora/pull/88#issuecomment-247729180>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/ABHJl7By-BlqFB0CnbS4-KJwAbCPrKuCks5qqyGbgaJpZM4J_SJM>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora issue #88: GORA-495 fix
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the issue:
https://github.com/apache/gora/pull/88
yes you do... the canonical repository is at https://git-wip-us.apache.org/repos/asf/gora.git
Push to that repository and everything else is magic :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request #88: GORA-495 fix
Posted by alfonsonishikawa <gi...@git.apache.org>.
Github user alfonsonishikawa commented on a diff in the pull request:
https://github.com/apache/gora/pull/88#discussion_r79947161
--- Diff: gora-compiler/src/main/velocity/org/apache/gora/compiler/templates/record.vm ---
@@ -18,7 +18,7 @@
#if ($schema.getNamespace())
package $schema.getNamespace();
#end
-@SuppressWarnings("all")
--- End diff --
I don't have permissions to accept pull requests :\
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request #88: GORA-495 fix
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/gora/pull/88#discussion_r79938119
--- Diff: gora-compiler/src/main/velocity/org/apache/gora/compiler/templates/record.vm ---
@@ -18,7 +18,7 @@
#if ($schema.getNamespace())
package $schema.getNamespace();
#end
-@SuppressWarnings("all")
--- End diff --
i think most of the warnings will be down to type safety. Feel free to commit this @alfonsonishikawa thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora issue #88: GORA-495 fix
Posted by djkevincr <gi...@git.apache.org>.
Github user djkevincr commented on the issue:
https://github.com/apache/gora/pull/88
@lewismc All the databeans Gora codebase have been updated with this. All the data beans currently have this 2 variable declaration. Just looking at commit history in my final pull request, these two variable declarations unintentionally got missing after adding java docs record velocity template.
Apologize for the confusion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora issue #88: GORA-495 fix
Posted by djkevincr <gi...@git.apache.org>.
Github user djkevincr commented on the issue:
https://github.com/apache/gora/pull/88
+1, There's already opened ticket GORA-412 for this. I have updated the PR with removing @SuppressWarnings(all) and recompiled data beans again and pushed the changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora issue #88: GORA-495 fix
Posted by alfonsonishikawa <gi...@git.apache.org>.
Github user alfonsonishikawa commented on the issue:
https://github.com/apache/gora/pull/88
Didn't know about that "magic" :) This evening I will push it :D Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request #88: GORA-495 fix
Posted by alfonsonishikawa <gi...@git.apache.org>.
Github user alfonsonishikawa commented on a diff in the pull request:
https://github.com/apache/gora/pull/88#discussion_r79923310
--- Diff: gora-compiler/src/main/velocity/org/apache/gora/compiler/templates/record.vm ---
@@ -18,7 +18,7 @@
#if ($schema.getNamespace())
package $schema.getNamespace();
#end
-@SuppressWarnings("all")
--- End diff --
In https://issues.apache.org/jira/browse/GORA-412 where the consensus was to remove the @SuppressWarnings("all") and let the warnings be shown in the IDE.
I guess it will show warnings, but who cares? ;)
I vote +1 to apply the patch :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora issue #88: GORA-495 fix
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the issue:
https://github.com/apache/gora/pull/88
No problems... I was just checking up. If you could add the newly compiled data beans to the PR then we can test and merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora issue #88: GORA-495 fix
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the issue:
https://github.com/apache/gora/pull/88
Dynamite. Some comments
* can you add back in the Apache license headers.. Right now this is a manual task.. We used to have a compiler flag to enable license header generation but that was with old compiler.
* I wonder if we can investigate removal of the SupresdAll compiler flag. I think this is another issue though.
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request #88: GORA-495 fix
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/gora/pull/88#discussion_r79887906
--- Diff: gora-compiler/src/main/velocity/org/apache/gora/compiler/templates/record.vm ---
@@ -18,7 +18,7 @@
#if ($schema.getNamespace())
package $schema.getNamespace();
#end
-@SuppressWarnings("all")
--- End diff --
Did this not result in compiler warnings?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora issue #88: GORA-495 fix
Posted by djkevincr <gi...@git.apache.org>.
Github user djkevincr commented on the issue:
https://github.com/apache/gora/pull/88
@lewismc I added license headers. I think that compiler flag comes from record.vm velocity template,
How do we proceed with this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora issue #88: GORA-495 fix
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the issue:
https://github.com/apache/gora/pull/88
Hi @djkevincr is it not necessary to recompile all of the existing data beans within the Gora codebase?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request #88: GORA-495 fix
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/gora/pull/88
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora issue #88: GORA-495 fix
Posted by djkevincr <gi...@git.apache.org>.
Github user djkevincr commented on the issue:
https://github.com/apache/gora/pull/88
@lewismc I have recompiled all the databeans again and pushed the changes. There is no code change except for formatting and newly generated serialVersionUID. Please let me know if you have any further concerns.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---