[jira] [Commented] (HDFS-8026) Trace FSOutputSummer#writeChecksumChunks rather than DFSOutputStream#writeChunk

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-8026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14389571#comment-14389571 ] 

Hadoop QA commented on HDFS-8026:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12708293/HDFS-8026.001.patch
  against trunk revision 79f7f2a.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:

                  org.apache.hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/10131//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/10131//console

This message is automatically generated.

> Trace FSOutputSummer#writeChecksumChunks rather than DFSOutputStream#writeChunk
> -------------------------------------------------------------------------------
>
>                 Key: HDFS-8026
>                 URL: https://issues.apache.org/jira/browse/HDFS-8026
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.7.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Minor
>         Attachments: HDFS-8026.001.patch
>
>
> We should trace FSOutputSummer#writeChecksumChunks rather than DFSOutputStream#writeChunk.  When tracing writeChunk, we get a new trace span every 512 bytes; when tracing writeChecksumChunks, we normally get a new trace span only when the FSOutputSummer buffer is full (9x less often.)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)