You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by dh...@apache.org on 2016/09/29 17:29:02 UTC
[2/2] incubator-beam git commit: BoundedReadFromUnboundedSourceTest:
remove unused code
BoundedReadFromUnboundedSourceTest: remove unused code
Project: http://git-wip-us.apache.org/repos/asf/incubator-beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-beam/commit/242fde7d
Tree: http://git-wip-us.apache.org/repos/asf/incubator-beam/tree/242fde7d
Diff: http://git-wip-us.apache.org/repos/asf/incubator-beam/diff/242fde7d
Branch: refs/heads/master
Commit: 242fde7d075b02adabba4306dc68c1d84b843c6d
Parents: efb2b83
Author: Dan Halperin <dh...@google.com>
Authored: Thu Sep 29 09:42:31 2016 -0700
Committer: Dan Halperin <dh...@google.com>
Committed: Thu Sep 29 10:28:50 2016 -0700
----------------------------------------------------------------------
.../beam/sdk/io/BoundedReadFromUnboundedSourceTest.java | 10 ----------
1 file changed, 10 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/242fde7d/sdks/java/core/src/test/java/org/apache/beam/sdk/io/BoundedReadFromUnboundedSourceTest.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/test/java/org/apache/beam/sdk/io/BoundedReadFromUnboundedSourceTest.java b/sdks/java/core/src/test/java/org/apache/beam/sdk/io/BoundedReadFromUnboundedSourceTest.java
index 7bf0f35..5a58519 100644
--- a/sdks/java/core/src/test/java/org/apache/beam/sdk/io/BoundedReadFromUnboundedSourceTest.java
+++ b/sdks/java/core/src/test/java/org/apache/beam/sdk/io/BoundedReadFromUnboundedSourceTest.java
@@ -18,7 +18,6 @@
package org.apache.beam.sdk.io;
import static org.apache.beam.sdk.transforms.display.DisplayDataMatchers.includesDisplayDataFrom;
-import static org.hamcrest.Matchers.containsInAnyOrder;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertThat;
import static org.junit.Assert.assertTrue;
@@ -46,7 +45,6 @@ import org.junit.runners.JUnit4;
@RunWith(JUnit4.class)
public class BoundedReadFromUnboundedSourceTest implements Serializable{
private static final int NUM_RECORDS = 100;
- private static List<Integer> finalizeTracker = null;
@Test
@Category(RunnableOnService.class)
@@ -109,9 +107,6 @@ public class BoundedReadFromUnboundedSourceTest implements Serializable{
for (int i = 0; i < values.size(); i++) {
assertEquals(i, (int) values.get(i));
}
- if (finalizeTracker != null) {
- assertThat(finalizeTracker, containsInAnyOrder(values.size() - 1));
- }
return null;
}
}
@@ -128,11 +123,6 @@ public class BoundedReadFromUnboundedSourceTest implements Serializable{
? p.apply(Read.from(source).withMaxReadTime(Duration.millis(200)))
: p.apply(Read.from(source).withMaxNumRecords(NUM_RECORDS));
- List<KV<Integer, Integer>> expectedOutput = new ArrayList<>();
- for (int i = 0; i < NUM_RECORDS; i++) {
- expectedOutput.add(KV.of(0, i));
- }
-
// Because some of the NUM_RECORDS elements read are dupes, the final output
// will only have output from 0 to n where n < NUM_RECORDS.
PAssert.that(output).satisfies(new Checker(dedup, timeBound));