You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "airborne12 (via GitHub)" <gi...@apache.org> on 2026/10/18 15:41:02 UTC
[PR] branch-4.2: [improvement](be) Speed up dense unscored inverted index conjunctions (#69172) [doris]
airborne12 opened a new pull request, #69239:
URL: https://github.com/apache/doris/pull/69239
### What problem does this PR solve?
Issue Number: N/A
Related PR: #69172, #69206
Problem Summary: Backport #69172 after #69206 introduced the shared inverted-index query engine to branch-4.2. Dense unscored conjunctions now skip terms held by every row, write a lone term directly to the result bitmap, use branch-free block intersection, and bound streaming-source batches. Query results are unchanged.
Source PR: https://github.com/apache/doris/pull/69172
Source squash commit: `f937d950d45313f20864d287df453e1b90f5c615` (cherry-picked with `-x`).
### Release note
None
### Check List (For Author)
- Test
- [x] Regression test: `test_match_format_parity` passed on an isolated branch-4.2 FE/BE cluster after rebasing onto `ecd322ad31193cda19cf4f3b08e0f3f9d12dd67c` (1 suite, 0 failures).
- [x] Unit Test: `ListedTermsTest.*:CursorChainedPostings.*` passed (41 tests in 2 suites); all 9 source-added tests were listed and executed. No sanitizer report.
- [x] Manual test: `./build.sh --be -j64` and `./build.sh --fe -j8` passed; isolated backend reported `Alive=true`, and `SELECT 1` succeeded.
- Behavior changed:
- [x] No. Unscored conjunction execution is faster; query results are unchanged.
- Does this need documentation?
- [x] No.
### Validation
- `build-support/check-format.sh`: PASS.
- Complete merged-tree format preflight against `origin/branch-4.2`: PASS.
- Complete PR diff English description check: PASS (5 source files, no exceptions).
- Branch-4.2 has no `build-support/run-clang-tidy.sh`; the branch's BE build and format gates passed.
### Hunk audit
The source squash patch ID matches the final source PR head. The cherry-pick was clean, and every changed file has a byte-identical postimage to the source commit.
| Source file | Disposition |
| --- | --- |
| `be/src/storage/index/inverted/query/engine/boolean_query/listed_terms.cpp` | Ported (verbatim) |
| `be/src/storage/index/inverted/query/exec/cursor_chained_postings.cpp` | Ported (verbatim) |
| `be/src/storage/index/inverted/query/exec/cursor_chained_postings.h` | Ported (verbatim) |
| `be/test/storage/index/inverted/query/engine/boolean_query/listed_terms_test.cpp` | Ported (verbatim) |
| `be/test/storage/index/inverted/query/exec/cursor_chained_postings_test.cpp` | Ported (verbatim) |
`git range-diff` shows only the `-x` cherry-pick provenance line; the code patch is unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-4.2: [improvement](be) Speed up dense unscored inverted index conjunctions (#69172) [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69239:
URL: https://github.com/apache/doris/pull/69239#issuecomment-6251812650
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://doris.apache.org/community/how-to-contribute/review-and-ci).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-4.2: [improvement](be) Speed up dense unscored inverted index conjunctions (#69172) [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69239:
URL: https://github.com/apache/doris/pull/69239#issuecomment-6257857844
# BE UT Coverage Report
Increment line coverage `100.00% (145/145)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/287223d7edd483468d44747f70546c0405547708_287223d7edd483468d44747f70546c0405547708/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/287223d7edd483468d44747f70546c0405547708_287223d7edd483468d44747f70546c0405547708/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 64.00% (29651/46330) |
| Line Coverage | 48.81% (312064/639302) |
| Region Coverage | 44.62% (250891/562318) |
| Branch Coverage | 46.26% (118201/255505) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-4.2: [improvement](be) Speed up dense unscored inverted index conjunctions (#69172) [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #69239:
URL: https://github.com/apache/doris/pull/69239#issuecomment-6259154491
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-4.2: [improvement](be) Speed up dense unscored inverted index conjunctions (#69172) [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #69239:
URL: https://github.com/apache/doris/pull/69239#issuecomment-6259155022
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-4.2: [improvement](be) Speed up dense unscored inverted index conjunctions (#69172) [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #69239:
URL: https://github.com/apache/doris/pull/69239
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-4.2: [improvement](be) Speed up dense unscored inverted index conjunctions (#69172) [doris]
Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 commented on PR #69239:
URL: https://github.com/apache/doris/pull/69239#issuecomment-6256760428
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org