[GitHub] [couchdb] rnewson commented on a diff in pull request #4718: enhance smoosh to cleanup search indexes when ddocs change

["rnewson (via GitHub)" <gi...@apache.org>]

rnewson commented on code in PR #4718:
URL: https://github.com/apache/couchdb/pull/4718#discussion_r1284734200


##########
src/smoosh/src/smoosh_server.erl:
##########
@@ -342,6 +345,8 @@ find_channel(#state{} = State, [Channel | Rest], Object) ->
             find_channel(State, Rest, Object)
     end.
 
+stale_enough({?INDEX_CLEANUP, _}) ->
+    true;

Review Comment:
   ddoc_updated events are rare, unlike database updates, so choosing not to action one would leave unreferenced indexes on disk for a long time, perhaps indefinitely.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org