You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Gautam Borad <gb...@gmail.com> on 2015/09/18 12:37:59 UTC
Review Request 38479: AMBARI-13138 Use ranger port value from configs
for alerts in Ambari (HDP-2.2)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38479/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Velmurugan Periasamy, and Yusaku Sako.
Bugs: AMBARI-13138
https://issues.apache.org/jira/browse/AMBARI-13138
Repository: ambari
Description
-------
For HDP-2.2
Alerts uses default port value i.e. 6080 instead of using expected port values from configs. Need to take the port value from configs.
Diffs
-----
ambari-server/src/main/resources/common-services/RANGER/0.4.0/alerts.json 05ccc1d
ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-site.xml 293c925
Diff: https://reviews.apache.org/r/38479/diff/
Testing
-------
Ranger installation was successful on centos6. Alerts were working as expected when http, https ports values are changed.
Thanks,
Gautam Borad
Re: Review Request 38479: AMBARI-13138 Use ranger port value from
configs for alerts in Ambari (HDP-2.2)
Posted by Gautam Borad <gb...@gmail.com>.
> On Sept. 18, 2015, 5:26 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/common-services/RANGER/0.4.0/alerts.json, line 12
> > <https://reviews.apache.org/r/38479/diff/1/?file=1076542#file1076542line12>
> >
> > This will cause problems with existing deployments that already have this definition as a PORT definition. You'll also need to update the upgrade catalog.
> >
> > See: https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java#L1195
> >
> > You'll basically need to find instances of this alert definition and change the JSON structure.
Please review changes added in latest patch
- Gautam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38479/#review99560
-----------------------------------------------------------
On Sept. 18, 2015, 10:37 a.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38479/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2015, 10:37 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Velmurugan Periasamy, and Yusaku Sako.
>
>
> Bugs: AMBARI-13138
> https://issues.apache.org/jira/browse/AMBARI-13138
>
>
> Repository: ambari
>
>
> Description
> -------
>
> For HDP-2.2
> Alerts uses default port value i.e. 6080 instead of using expected port values from configs. Need to take the port value from configs.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/alerts.json 05ccc1d
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-site.xml 293c925
>
> Diff: https://reviews.apache.org/r/38479/diff/
>
>
> Testing
> -------
>
> Ranger installation was successful on centos6. Alerts were working as expected when http, https ports values are changed.
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 38479: AMBARI-13138 Use ranger port value from
configs for alerts in Ambari (HDP-2.2)
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38479/#review99560
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/RANGER/0.4.0/alerts.json (line 12)
<https://reviews.apache.org/r/38479/#comment156490>
This will cause problems with existing deployments that already have this definition as a PORT definition. You'll also need to update the upgrade catalog.
See: https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java#L1195
You'll basically need to find instances of this alert definition and change the JSON structure.
- Jonathan Hurley
On Sept. 18, 2015, 6:37 a.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38479/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2015, 6:37 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Velmurugan Periasamy, and Yusaku Sako.
>
>
> Bugs: AMBARI-13138
> https://issues.apache.org/jira/browse/AMBARI-13138
>
>
> Repository: ambari
>
>
> Description
> -------
>
> For HDP-2.2
> Alerts uses default port value i.e. 6080 instead of using expected port values from configs. Need to take the port value from configs.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/alerts.json 05ccc1d
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-site.xml 293c925
>
> Diff: https://reviews.apache.org/r/38479/diff/
>
>
> Testing
> -------
>
> Ranger installation was successful on centos6. Alerts were working as expected when http, https ports values are changed.
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 38479: AMBARI-13138 Use ranger port value from
configs for alerts in Ambari (HDP-2.2)
Posted by Gautam Borad <gb...@gmail.com>.
> On Oct. 21, 2015, 8:24 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-site.xml, line 44
> > <https://reviews.apache.org/r/38479/diff/2/?file=1101677#file1101677line44>
> >
> > Does this value have to change for Stack Upgrades?
> > Say HDP 2.2->2.3?
Nope, it is not mandatory to change this value for upgrade.
- Gautam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38479/#review103466
-----------------------------------------------------------
On Oct. 20, 2015, 12:58 p.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38479/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2015, 12:58 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Velmurugan Periasamy, and Yusaku Sako.
>
>
> Bugs: AMBARI-13138
> https://issues.apache.org/jira/browse/AMBARI-13138
>
>
> Repository: ambari
>
>
> Description
> -------
>
> For HDP-2.2
> Alerts uses default port value i.e. 6080 instead of using expected port values from configs. Need to take the port value from configs.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java 12a1f44
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/alerts.json 05ccc1d
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-site.xml 293c925
>
> Diff: https://reviews.apache.org/r/38479/diff/
>
>
> Testing
> -------
>
> Ranger installation was successful on centos6. Alerts were working as expected when http, https ports values are changed.
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 38479: AMBARI-13138 Use ranger port value from
configs for alerts in Ambari (HDP-2.2)
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38479/#review103466
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-site.xml (line 44)
<https://reviews.apache.org/r/38479/#comment161530>
Does this value have to change for Stack Upgrades?
Say HDP 2.2->2.3?
- Alejandro Fernandez
On Oct. 20, 2015, 12:58 p.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38479/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2015, 12:58 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Velmurugan Periasamy, and Yusaku Sako.
>
>
> Bugs: AMBARI-13138
> https://issues.apache.org/jira/browse/AMBARI-13138
>
>
> Repository: ambari
>
>
> Description
> -------
>
> For HDP-2.2
> Alerts uses default port value i.e. 6080 instead of using expected port values from configs. Need to take the port value from configs.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java 12a1f44
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/alerts.json 05ccc1d
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-site.xml 293c925
>
> Diff: https://reviews.apache.org/r/38479/diff/
>
>
> Testing
> -------
>
> Ranger installation was successful on centos6. Alerts were working as expected when http, https ports values are changed.
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 38479: AMBARI-13138 Use ranger port value from
configs for alerts in Ambari (HDP-2.2)
Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38479/
-----------------------------------------------------------
(Updated Oct. 20, 2015, 12:58 p.m.)
Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Velmurugan Periasamy, and Yusaku Sako.
Changes
-------
Handled UpgradeCatalog210 changes
Bugs: AMBARI-13138
https://issues.apache.org/jira/browse/AMBARI-13138
Repository: ambari
Description
-------
For HDP-2.2
Alerts uses default port value i.e. 6080 instead of using expected port values from configs. Need to take the port value from configs.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java 12a1f44
ambari-server/src/main/resources/common-services/RANGER/0.4.0/alerts.json 05ccc1d
ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-site.xml 293c925
Diff: https://reviews.apache.org/r/38479/diff/
Testing
-------
Ranger installation was successful on centos6. Alerts were working as expected when http, https ports values are changed.
Thanks,
Gautam Borad