You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/08/26 08:14:55 UTC

[GitHub] [incubator-devlake] mindlesscloud commented on a diff in pull request #2850: fix: change the filed user_id to account_id in table pr_comments and issue_comments

mindlesscloud commented on code in PR #2850:
URL: https://github.com/apache/incubator-devlake/pull/2850#discussion_r955656601


##########
models/migrationscripts/archived/issue.go:
##########
@@ -88,7 +88,7 @@ type IssueComment struct {
 	DomainEntity
 	IssueId     string `gorm:"index"`
 	Body        string
-	UserId      string `gorm:"type:varchar(255)"`
+	AccountId   string `gorm:"type:varchar(255)"`

Review Comment:
   the archived models are supposed to be immutable, we should not try to modify them.



##########
models/migrationscripts/archived/pull_request.go:
##########
@@ -77,7 +77,7 @@ type PullRequestComment struct {
 	DomainEntity
 	PullRequestId string `gorm:"index"`
 	Body          string
-	UserId        string `gorm:"type:varchar(255)"`
+	AccountId     string `gorm:"type:varchar(255)"`

Review Comment:
   same as above



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org