You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/09/12 07:53:15 UTC
[GitHub] [incubator-kvrocks] torwig opened a new pull request, #863: Add zstd to available compression algorithms (need help with macOS builds)
torwig opened a new pull request, #863:
URL: https://github.com/apache/incubator-kvrocks/pull/863
Added the `zstd` compression library.
@git-hulk I can't resolve build issues on macOS and need help with that. I googled them, and tried a couple of solutions but had no success.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] aleksraiden commented on pull request #863: Add zstd to available compression algorithms
Posted by GitBox <gi...@apache.org>.
aleksraiden commented on PR #863:
URL: https://github.com/apache/incubator-kvrocks/pull/863#issuecomment-1243463351
Thanks, @torwig
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on a diff in pull request #863: Add zstd to available compression algorithms (need help with macOS builds)
Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on code in PR #863:
URL: https://github.com/apache/incubator-kvrocks/pull/863#discussion_r968133154
##########
cmake/zstd.cmake:
##########
@@ -0,0 +1,44 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+include_guard()
+
+include(cmake/utils.cmake)
+
+FetchContent_DeclareGitHubWithMirror(zstd
+ facebook/zstd v1.5.2
+ MD5=93220bc2dcb92e154f443d1a886ccd6c
+)
+
+FetchContent_GetProperties(zstd)
+if(NOT zstd_POPULATED)
+ FetchContent_Populate(zstd)
+
+ if(CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang")
+ set(APPLE_FLAG "CFLAGS=-isysroot ${CMAKE_OSX_SYSROOT}")
+ endif()
+
+ add_custom_target(make_zstd COMMAND make CC=${CMAKE_C_COMPILER} libzstd.a
Review Comment:
Hi, maybe you need to add `${APPLE_FLAG}` here, I think it is why the CI failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun commented on pull request #863: Add zstd to available compression algorithms
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #863:
URL: https://github.com/apache/incubator-kvrocks/pull/863#issuecomment-1243487725
Waiting for Travis CI reports...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] torwig commented on pull request #863: Add zstd to available compression algorithms
Posted by GitBox <gi...@apache.org>.
torwig commented on PR #863:
URL: https://github.com/apache/incubator-kvrocks/pull/863#issuecomment-1243472404
@tisonkun Yes, I tested it locally. Short manual testing I would say.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk commented on pull request #863: Add zstd to available compression algorithms
Posted by GitBox <gi...@apache.org>.
git-hulk commented on PR #863:
URL: https://github.com/apache/incubator-kvrocks/pull/863#issuecomment-1243560763
Thanks all, merging...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] torwig commented on a diff in pull request #863: Add zstd to available compression algorithms (need help with macOS builds)
Posted by GitBox <gi...@apache.org>.
torwig commented on code in PR #863:
URL: https://github.com/apache/incubator-kvrocks/pull/863#discussion_r968135996
##########
cmake/zstd.cmake:
##########
@@ -0,0 +1,44 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+include_guard()
+
+include(cmake/utils.cmake)
+
+FetchContent_DeclareGitHubWithMirror(zstd
+ facebook/zstd v1.5.2
+ MD5=93220bc2dcb92e154f443d1a886ccd6c
+)
+
+FetchContent_GetProperties(zstd)
+if(NOT zstd_POPULATED)
+ FetchContent_Populate(zstd)
+
+ if(CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang")
+ set(APPLE_FLAG "CFLAGS=-isysroot ${CMAKE_OSX_SYSROOT}")
+ endif()
+
+ add_custom_target(make_zstd COMMAND make CC=${CMAKE_C_COMPILER} libzstd.a
Review Comment:
@PragmaTwice Yes, it should work. This flag was set but not used. Thank you :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on a diff in pull request #863: Add zstd to available compression algorithms (need help with macOS builds)
Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on code in PR #863:
URL: https://github.com/apache/incubator-kvrocks/pull/863#discussion_r968133154
##########
cmake/zstd.cmake:
##########
@@ -0,0 +1,44 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+include_guard()
+
+include(cmake/utils.cmake)
+
+FetchContent_DeclareGitHubWithMirror(zstd
+ facebook/zstd v1.5.2
+ MD5=93220bc2dcb92e154f443d1a886ccd6c
+)
+
+FetchContent_GetProperties(zstd)
+if(NOT zstd_POPULATED)
+ FetchContent_Populate(zstd)
+
+ if(CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang")
+ set(APPLE_FLAG "CFLAGS=-isysroot ${CMAKE_OSX_SYSROOT}")
+ endif()
+
+ add_custom_target(make_zstd COMMAND make CC=${CMAKE_C_COMPILER} libzstd.a
Review Comment:
Hi, maybe you need to add `${APPLE_FLAG}` here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk merged pull request #863: Add zstd to available compression algorithms
Posted by GitBox <gi...@apache.org>.
git-hulk merged PR #863:
URL: https://github.com/apache/incubator-kvrocks/pull/863
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org