You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@datasketches.apache.org by leerho <le...@gmail.com> on 2022/03/01 01:46:20 UTC
Re: [VOTE] Release Apache DataSketches-hive-1.2.0-RC2
-1
I checked
- sha512 and GPG signatures
- LICENCE and NOTICE present and correct
- compiled and unit tests passing including -P strict
- "mvn install" did install the jars fine
Sorry, I had the same failure as David did on the Rat test. Probably most
of us have a "*.properties" exclusion as part of our .gitignore file and
Rat will respect that. But when downloading the Zip file, there is no
.gitignore file, so the exclusion needs to be part of the POM rat plugin
excludes: "<exclude>**/git.properties</exclude>".
It may be a long time before this is updated again, so I suggest we fix it
now. Otherwise, folks downloading the zip file from our downloads site
will experience this failure.
Lee.
On Thu, Feb 24, 2022 at 7:26 AM David Cromberge <dc...@apache.org>
wrote:
> Hi dev community,
>
> +1,
>
> One minor issue were the failing Rat checks. The Rat check failed on the
> git.properties files which is created during the release process. In
> ds-memory and ds-java we had to add this file to the Rat exclusions in the
> maven pom file.
>
> Everything else that I have checked is OK:
> - sha512 and gpg signatures
> - LICENCE and NOTICE present and correct
> - compiled and unit tests passing
> - maven jars and docs uploaded successfully
>
> Thanks,
> David
>
> On 2022/02/22 21:31:56 Alexander Saydakov wrote:
> > Hello Apache DataSketches PMC and Community,
> >
> > This is a call for vote to release datasketches-hive-1.2.0-RC2
> >
> > This is a maintenance release to make this Apache Hive component work
> with
> > the latest versions of datasketches-java-3.1.0 and
> datasketches-memory-2.0.0
> >
> > Changes since RC1:
> > - updated NOTICE
> >
> > Source repository: https://github.com/apache/datasketches-hive
> >
> > Git Tag for this release:
> > https://github.com/apache/datasketches-hive/releases/tag/1.2.0-RC2
> > on branch 1.2.X
> >
> > Git HashId for this tag: f69740d138eec3c289cebafdfea38308426773c6
> >
> > The Release Candidate Dist (Zip Repository):
> > https://dist.apache.org/repos/dist/dev/datasketches/hive/1.2.0-RC2
> >
> > The public signing key can be found in the KEYS file:
> > https://dist.apache.org/repos/dist/dev/datasketches/KEYS
> >
> > The artifacts have been signed with key:
> > 68486114A8E8B4E0 2019-08-20 Alexander Saydakov (CODE SIGNING KEY) <
> > alsay@apache.org>
> >
> > Maven Repository (jar artifacts):
> >
> https://repository.apache.org/content/groups/staging/org/apache/datasketches/datasketches-hive/1.2.0/
> >
> > Build & Test Guide:
> > https://github.com/apache/datasketches-hive/blob/1.2.0-RC2/README.md
> >
> > The vote will be performed as follows:
> > This letter will be published on dev@ and remain open for at least 72
> hours
> > (excluding weekends and holidays), AND until at least 3 (+1) PMC votes
> or a
> > majority of (+1) PMC votes are acquired. Anyone in the community can
> vote.
> >
> > Please vote accordingly:
> >
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> > Thanks,
> > Alexander Saydakov
> > alsay@apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
> For additional commands, e-mail: dev-help@datasketches.apache.org
>
>
Re: Re: [VOTE] Release Apache DataSketches-hive-1.2.0-RC2
Posted by Alexander Saydakov <sa...@yahooinc.com.INVALID>.
Please consider this vote cancelled.
Thank you.
On Mon, Feb 28, 2022 at 5:46 PM leerho <le...@gmail.com> wrote:
> -1
>
> I checked
> - sha512 and GPG signatures
> - LICENCE and NOTICE present and correct
> - compiled and unit tests passing including -P strict
> - "mvn install" did install the jars fine
>
> Sorry, I had the same failure as David did on the Rat test. Probably most
> of us have a "*.properties" exclusion as part of our .gitignore file and
> Rat will respect that. But when downloading the Zip file, there is no
> .gitignore file, so the exclusion needs to be part of the POM rat plugin
> excludes: "<exclude>**/git.properties</exclude>".
>
> It may be a long time before this is updated again, so I suggest we fix it
> now. Otherwise, folks downloading the zip file from our downloads site
> will experience this failure.
>
> Lee.
>
>
> On Thu, Feb 24, 2022 at 7:26 AM David Cromberge <dc...@apache.org>
> wrote:
>
>> Hi dev community,
>>
>> +1,
>>
>> One minor issue were the failing Rat checks. The Rat check failed on the
>> git.properties files which is created during the release process. In
>> ds-memory and ds-java we had to add this file to the Rat exclusions in the
>> maven pom file.
>>
>> Everything else that I have checked is OK:
>> - sha512 and gpg signatures
>> - LICENCE and NOTICE present and correct
>> - compiled and unit tests passing
>> - maven jars and docs uploaded successfully
>>
>> Thanks,
>> David
>>
>> On 2022/02/22 21:31:56 Alexander Saydakov wrote:
>> > Hello Apache DataSketches PMC and Community,
>> >
>> > This is a call for vote to release datasketches-hive-1.2.0-RC2
>> >
>> > This is a maintenance release to make this Apache Hive component work
>> with
>> > the latest versions of datasketches-java-3.1.0 and
>> datasketches-memory-2.0.0
>> >
>> > Changes since RC1:
>> > - updated NOTICE
>> >
>> > Source repository: https://github.com/apache/datasketches-hive
>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-hive__;!!Op6eflyXZCqGR5I!XP0AbgPytVZBO7DXEkFPi-bS0l70XvJ4rgcZMXsTrLKd7455V2W2Dg0FUafX-FndRA$>
>> >
>> > Git Tag for this release:
>> > https://github.com/apache/datasketches-hive/releases/tag/1.2.0-RC2
>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-hive/releases/tag/1.2.0-RC2__;!!Op6eflyXZCqGR5I!XP0AbgPytVZBO7DXEkFPi-bS0l70XvJ4rgcZMXsTrLKd7455V2W2Dg0FUafA4kewzg$>
>> > on branch 1.2.X
>> >
>> > Git HashId for this tag: f69740d138eec3c289cebafdfea38308426773c6
>> >
>> > The Release Candidate Dist (Zip Repository):
>> > https://dist.apache.org/repos/dist/dev/datasketches/hive/1.2.0-RC2
>> <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/hive/1.2.0-RC2__;!!Op6eflyXZCqGR5I!XP0AbgPytVZBO7DXEkFPi-bS0l70XvJ4rgcZMXsTrLKd7455V2W2Dg0FUadvMBRFrQ$>
>> >
>> > The public signing key can be found in the KEYS file:
>> > https://dist.apache.org/repos/dist/dev/datasketches/KEYS
>> <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/KEYS__;!!Op6eflyXZCqGR5I!XP0AbgPytVZBO7DXEkFPi-bS0l70XvJ4rgcZMXsTrLKd7455V2W2Dg0FUafMRbfi-Q$>
>> >
>> > The artifacts have been signed with key:
>> > 68486114A8E8B4E0 2019-08-20 Alexander Saydakov (CODE SIGNING KEY) <
>> > alsay@apache.org>
>> >
>> > Maven Repository (jar artifacts):
>> >
>> https://repository.apache.org/content/groups/staging/org/apache/datasketches/datasketches-hive/1.2.0/
>> <https://urldefense.com/v3/__https://repository.apache.org/content/groups/staging/org/apache/datasketches/datasketches-hive/1.2.0/__;!!Op6eflyXZCqGR5I!XP0AbgPytVZBO7DXEkFPi-bS0l70XvJ4rgcZMXsTrLKd7455V2W2Dg0FUae9Z02MfA$>
>> >
>> > Build & Test Guide:
>> > https://github.com/apache/datasketches-hive/blob/1.2.0-RC2/README.md
>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-hive/blob/1.2.0-RC2/README.md__;!!Op6eflyXZCqGR5I!XP0AbgPytVZBO7DXEkFPi-bS0l70XvJ4rgcZMXsTrLKd7455V2W2Dg0FUaca0l7FaA$>
>> >
>> > The vote will be performed as follows:
>> > This letter will be published on dev@ and remain open for at least 72
>> hours
>> > (excluding weekends and holidays), AND until at least 3 (+1) PMC votes
>> or a
>> > majority of (+1) PMC votes are acquired. Anyone in the community can
>> vote.
>> >
>> > Please vote accordingly:
>> >
>> > [ ] +1 approve
>> > [ ] +0 no opinion
>> > [ ] -1 disapprove with the reason
>> >
>> > Thanks,
>> > Alexander Saydakov
>> > alsay@apache.org
>> >
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
>> For additional commands, e-mail: dev-help@datasketches.apache.org
>>
>>