You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Akihiro Suda (JIRA)" <ji...@apache.org> on 2016/01/07 06:46:39 UTC

[jira] [Created] (HADOOP-12693) Many misusage of assertEquals(expected, actual)

Akihiro Suda created HADOOP-12693:
-------------------------------------

             Summary: Many misusage of assertEquals(expected, actual)
                 Key: HADOOP-12693
                 URL: https://issues.apache.org/jira/browse/HADOOP-12693
             Project: Hadoop Common
          Issue Type: Test
            Reporter: Akihiro Suda
            Priority: Trivial
         Attachments: just-rough-approx.txt

The first arg of {{org.JUnit.Assert.assertEquals()}} should be an {{expected}} value, and the second one should be an {{actual}} value.

{code}
void assertEquals(T expected, T actual);
{code}

http://junit.org/apidocs/org/junit/Assert.html#assertEquals(java.lang.Object, java.lang.Object)

However, there are so many violations in Hadoop, which can make a misleading message like this:
{code}
AssertionError: expected:<actual> but was:<expected>
{code}.

Please refer to {{just-rough-approx.txt}}.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)