You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by necosta <gi...@git.apache.org> on 2017/09/13 08:20:36 UTC
[GitHub] zeppelin pull request #2584: [ZEPPELIN-2928] Hotfix on maven set version fun...
GitHub user necosta opened a pull request:
https://github.com/apache/zeppelin/pull/2584
[ZEPPELIN-2928] Hotfix on maven set version functionality
### What is this PR for?
Hotfix on a recent commit that removed the version soft-coded variable and introduced hard-coded references to version tag.
### What type of PR is it?
[Bug Fix | Hot Fix ]
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-2928
### How should this be tested?
Run "mvn versions:set -DprocessDependencies=false -DnewVersion=0.8.0-SNAPSHOT-123"
### Questions:
* Does the licenses files need update? N
* Is there breaking changes for older versions? N
* Does this needs documentation? N
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nokia/zeppelin zeppelin-2928
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2584.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2584
----
commit f5ccf89bbf174f72d4aa8b07f68dc708dbc77264
Author: Nelson Costa <ne...@gmail.com>
Date: 2017-09-13T08:16:31Z
[ZEPPELIN-2928] Hotfix on maven set version functionality
----
---
[GitHub] zeppelin issue #2584: [ZEPPELIN-2928] Hotfix on maven set version functional...
Posted by necosta <gi...@git.apache.org>.
Github user necosta commented on the issue:
https://github.com/apache/zeppelin/pull/2584
Actually there is one more override missing on zeppelin-jupyter. I'll confirm tomorrow I got them all fixed.
---
[GitHub] zeppelin issue #2584: [ZEPPELIN-2928] Hotfix on maven set version functional...
Posted by necosta <gi...@git.apache.org>.
Github user necosta commented on the issue:
https://github.com/apache/zeppelin/pull/2584
@zjffdu
Done. Ready for final review. Thanks.
---
[GitHub] zeppelin pull request #2584: [ZEPPELIN-2928] Hotfix on maven set version fun...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2584
---
[GitHub] zeppelin issue #2584: [ZEPPELIN-2928] Hotfix on maven set version functional...
Posted by necosta <gi...@git.apache.org>.
Github user necosta commented on the issue:
https://github.com/apache/zeppelin/pull/2584
Missed that bug report. Thanks.
Ok, feel free to merge change or wait for more feedback.
---
[GitHub] zeppelin issue #2584: [ZEPPELIN-2928] Hotfix on maven set version functional...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2584
LGTM, wait for CI pass
---
[GitHub] zeppelin issue #2584: [ZEPPELIN-2928] Hotfix on maven set version functional...
Posted by necosta <gi...@git.apache.org>.
Github user necosta commented on the issue:
https://github.com/apache/zeppelin/pull/2584
Hi @zjffdu , @Leemoonsoo
Should be an easy one to get merged. Let me know if anything does not make sense. Cheers.
---
[GitHub] zeppelin issue #2584: [ZEPPELIN-2928] Hotfix on maven set version functional...
Posted by necosta <gi...@git.apache.org>.
Github user necosta commented on the issue:
https://github.com/apache/zeppelin/pull/2584
Hi @zjffdu , are there known issues on the CI? I'm a bit puzzled.
I am 1 commit on top of master and the CI keeps failing on this stage: https://travis-ci.org/nokia/zeppelin/jobs/274939134. Any suggestions?
I have cleaned the cache already, did not work... Thanks
---
[GitHub] zeppelin issue #2584: [ZEPPELIN-2928] Hotfix on maven set version functional...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2584
That's correct, please go ahead @necosta
---
[GitHub] zeppelin issue #2584: [ZEPPELIN-2928] Hotfix on maven set version functional...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2584
LGTM, will merge it if no more comment
---
[GitHub] zeppelin issue #2584: [ZEPPELIN-2928] Hotfix on maven set version functional...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2584
Don't worry. This is known issue tracked in ZEPPELIN-2927.
---