You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/04 09:21:42 UTC

[GitHub] [apisix-dashboard] juzhiyuan opened a new pull request #1707: chore: improve Upstream/CodeMirror

juzhiyuan opened a new pull request #1707:
URL: https://github.com/apache/apisix-dashboard/pull/1707


   Please answer these questions before submitting a pull request, **or your PR will get closed**.
   
   **Why submit this pull request?**
   
   - [ ] Bugfix
   - [ ] New feature provided
   - [x] Improve performance
   - [ ] Backport patches
   
   **What changes will this PR take into?**
   
   Please update this section with a detailed description.
   
   - [x] use UpperCase for JSON/YAML selector in CodeMirror
   - [x] added more description for Upstream List
   - [ ] added more proper fields description for Upstream Form
   
   **Related issues**
   
   fix/resolve #0001
   
   **Checklist:**
   
   - [ ] Did you explain what problem does this PR solve? Or what new features have been added?
   - [ ] Have you added corresponding test cases?
   - [ ] Have you modified the corresponding document?
   - [ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1707: chore: improve Upstream/CodeMirror

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1707:
URL: https://github.com/apache/apisix-dashboard/pull/1707#issuecomment-813828206


   Oops! When I want to select more reviewers on GitHub app, it unselect some of reviewers.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1707: chore: improve Upstream/CodeMirror

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1707:
URL: https://github.com/apache/apisix-dashboard/pull/1707#issuecomment-813001919


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1707?src=pr&el=h1) Report
   > Merging [#1707](https://codecov.io/gh/apache/apisix-dashboard/pull/1707?src=pr&el=desc) (3fb0ea6) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/8494e45a94f3afc40dbd44f562ea09f7baf0fd46?el=desc) (8494e45) will **decrease** coverage by `19.57%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1707?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #1707       +/-   ##
   ===========================================
   - Coverage   71.87%   52.29%   -19.58%     
   ===========================================
     Files         130       38       -92     
     Lines        5660     2660     -3000     
     Branches      661        0      -661     
   ===========================================
   - Hits         4068     1391     -2677     
   + Misses       1352     1081      -271     
   + Partials      240      188       -52     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `?` | |
   | backend-unit-test | `52.29% <ø> (ø)` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1707?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: |
   | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: |
   | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
   | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: |
   | [api/internal/handler/handler.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGFuZGxlci5nbw==) | `42.59% <0.00%> (-35.19%)` | :arrow_down: |
   | [api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==) | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
   | ... and [106 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1707?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1707?src=pr&el=footer). Last update [8494e45...3fb0ea6](https://codecov.io/gh/apache/apisix-dashboard/pull/1707?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1707: chore: improve Upstream/CodeMirror

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1707:
URL: https://github.com/apache/apisix-dashboard/pull/1707#issuecomment-813461875


   as for default values, we need to refer to https://github.com/api7/lua-resty-healthcheck/tree/master/docs , I will file a new PR to do that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] stu01509 commented on a change in pull request #1707: chore: improve Upstream/CodeMirror

Posted by GitBox <gi...@apache.org>.
stu01509 commented on a change in pull request #1707:
URL: https://github.com/apache/apisix-dashboard/pull/1707#discussion_r607390581



##########
File path: web/src/components/Upstream/UpstreamForm.tsx
##########
@@ -257,15 +249,16 @@ const UpstreamForm: React.FC<Props> = forwardRef(
 
     const ActiveHealthCheck = () => (
       <>
-        <Form.Item label={formatMessage({ id: 'page.upstream.step.healthyCheck.active.timeout' })}>
+        <Form.Item label={formatMessage({ id: 'page.upstream.step.healthyCheck.active.timeout' })} tooltip="主动健康检查的套接字的超时时间">
           <Form.Item name={['checks', 'active', 'timeout']} noStyle>

Review comment:
       `主动健康检查的套接字的超时时间` maybe need to declare in locales file?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1707: chore: improve Upstream/CodeMirror

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1707:
URL: https://github.com/apache/apisix-dashboard/pull/1707#issuecomment-813001919


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1707?src=pr&el=h1) Report
   > Merging [#1707](https://codecov.io/gh/apache/apisix-dashboard/pull/1707?src=pr&el=desc) (a0c212f) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/297a57a4081b7b55d7906f6084d319d0afc21579?el=desc) (297a57a) will **decrease** coverage by `0.54%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1707?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1707      +/-   ##
   ==========================================
   - Coverage   72.01%   71.46%   -0.55%     
   ==========================================
     Files         130       47      -83     
     Lines        5660     3126    -2534     
     Branches      661        0     -661     
   ==========================================
   - Hits         4076     2234    -1842     
   + Misses       1341      649     -692     
     Partials      243      243              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `62.22% <ø> (-0.13%)` | :arrow_down: |
   | backend-e2e-test-ginkgo | `48.49% <ø> (+0.12%)` | :arrow_up: |
   | backend-unit-test | `52.29% <ø> (ø)` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1707?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | `43.63% <0.00%> (-3.64%)` | :arrow_down: |
   | [...ages/Route/components/Step2/RequestRewriteView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAyL1JlcXVlc3RSZXdyaXRlVmlldy50c3g=) | | |
   | [web/src/components/RightContent/AvatarDropdown.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/diff?src=pr&el=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL1JpZ2h0Q29udGVudC9BdmF0YXJEcm9wZG93bi50c3g=) | | |
   | [web/src/pages/Route/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9MaXN0LnRzeA==) | | |
   | [web/src/access.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/diff?src=pr&el=tree#diff-d2ViL3NyYy9hY2Nlc3MudHM=) | | |
   | [web/src/pages/SSL/components/Step1/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9TU0wvY29tcG9uZW50cy9TdGVwMS9pbmRleC50c3g=) | | |
   | [web/src/pages/Service/components/Step1.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9TZXJ2aWNlL2NvbXBvbmVudHMvU3RlcDEudHN4) | | |
   | [web/src/components/Plugin/PluginPage.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/diff?src=pr&el=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5QYWdlLnRzeA==) | | |
   | [...ages/Route/components/DebugViews/DebugDrawView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0RlYnVnVmlld3MvRGVidWdEcmF3Vmlldy50c3g=) | | |
   | [web/src/pages/Service/components/Preview.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9TZXJ2aWNlL2NvbXBvbmVudHMvUHJldmlldy50c3g=) | | |
   | ... and [68 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1707?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1707?src=pr&el=footer). Last update [297a57a...a0c212f](https://codecov.io/gh/apache/apisix-dashboard/pull/1707?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1707: chore: improve Upstream/CodeMirror

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1707:
URL: https://github.com/apache/apisix-dashboard/pull/1707#issuecomment-813001919


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1707?src=pr&el=h1) Report
   > Merging [#1707](https://codecov.io/gh/apache/apisix-dashboard/pull/1707?src=pr&el=desc) (3fb0ea6) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/8494e45a94f3afc40dbd44f562ea09f7baf0fd46?el=desc) (8494e45) will **increase** coverage by `0.17%`.
   > The diff coverage is `45.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1707?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1707      +/-   ##
   ==========================================
   + Coverage   71.87%   72.04%   +0.17%     
   ==========================================
     Files         130      130              
     Lines        5660     5649      -11     
     Branches      661      648      -13     
   ==========================================
   + Hits         4068     4070       +2     
   + Misses       1352     1335      -17     
   - Partials      240      244       +4     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `62.28% <ø> (+0.19%)` | :arrow_up: |
   | backend-e2e-test-ginkgo | `48.43% <ø> (+0.06%)` | :arrow_up: |
   | backend-unit-test | `52.29% <ø> (ø)` | |
   | frontend-e2e-test | `72.69% <45.45%> (+0.15%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1707?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [web/src/pages/Consumer/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9MaXN0LnRzeA==) | `90.00% <ø> (ø)` | |
   | [web/src/pages/Route/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9MaXN0LnRzeA==) | `84.61% <ø> (ø)` | |
   | [web/src/pages/Service/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9TZXJ2aWNlL0xpc3QudHN4) | `97.43% <ø> (ø)` | |
   | [web/src/pages/Upstream/components/Step1.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9VcHN0cmVhbS9jb21wb25lbnRzL1N0ZXAxLnRzeA==) | `100.00% <ø> (ø)` | |
   | [web/src/components/Plugin/PluginDetail.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/diff?src=pr&el=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5EZXRhaWwudHN4) | `52.72% <16.66%> (ø)` | |
   | [web/src/components/Upstream/UpstreamForm.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/diff?src=pr&el=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL1Vwc3RyZWFtRm9ybS50c3g=) | `63.24% <42.85%> (+1.70%)` | :arrow_up: |
   | [web/src/components/RawDataEditor/RawDataEditor.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/diff?src=pr&el=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL1Jhd0RhdGFFZGl0b3IvUmF3RGF0YUVkaXRvci50c3g=) | `37.73% <50.00%> (ø)` | |
   | [web/src/pages/Upstream/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9VcHN0cmVhbS9DcmVhdGUudHN4) | `79.41% <50.00%> (ø)` | |
   | [web/src/components/Upstream/constant.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/diff?src=pr&el=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbnN0YW50LnRz) | `100.00% <100.00%> (ø)` | |
   | [web/src/pages/Upstream/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9VcHN0cmVhbS9MaXN0LnRzeA==) | `90.00% <100.00%> (ø)` | |
   | ... and [4 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1707?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1707?src=pr&el=footer). Last update [8494e45...3fb0ea6](https://codecov.io/gh/apache/apisix-dashboard/pull/1707?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1707: chore: improve Upstream/CodeMirror

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1707:
URL: https://github.com/apache/apisix-dashboard/pull/1707#issuecomment-813691713


   @LiteSun 
   
   ![image](https://user-images.githubusercontent.com/2106987/113635371-10c34380-96a3-11eb-86c3-4b0823e559dc.png)
   
   I have some doubts:
   
   1. Why FE doesn't have coverage 😳
   2. I don't change backend files, but this PR reduces some coverage.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1707: chore: improve Upstream/CodeMirror

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1707:
URL: https://github.com/apache/apisix-dashboard/pull/1707#discussion_r607508610



##########
File path: web/src/components/RawDataEditor/locales/zh-CN.ts
##########
@@ -16,5 +16,5 @@
  */
 export default {
   'component.rawDataEditor.tip': '目前暂不支持编辑',
-  'component.rawDataEditor.title': '元数据编辑器',
+  'component.rawDataEditor.title': 'CodeMirror',

Review comment:
       Maybe I need add some descriptions for CodeMirror and  still keeps using this word? 😊




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] qian0817 commented on a change in pull request #1707: chore: improve Upstream/CodeMirror

Posted by GitBox <gi...@apache.org>.
qian0817 commented on a change in pull request #1707:
URL: https://github.com/apache/apisix-dashboard/pull/1707#discussion_r607564849



##########
File path: web/src/components/Upstream/UpstreamForm.tsx
##########
@@ -771,7 +775,12 @@ const UpstreamForm: React.FC<Props> = forwardRef(
                 {
                   label: formatMessage({ id: 'page.upstream.step.healthyCheck.active' }),
                   name: ['checks', 'active'],
-                  component: <ActiveHealthCheck />,
+                  component: (
+                    <>
+                      <ActiveHealthCheck />
+                      <Divider orientation="left" plain></Divider>

Review comment:
       collapse empty tag
   ```suggestion
                         <Divider orientation="left" plain/>
   ```

##########
File path: web/src/pages/Upstream/List.tsx
##########
@@ -136,12 +136,11 @@ const Page: React.FC = () => {
             <PlusOutlined />
             {formatMessage({ id: 'component.global.create' })}
           </Button>,
-          <Button type="primary" onClick={() => {
+          <Button type="default" onClick={() => {

Review comment:
       I think the original way looks better.
   At the same time, If really need to do this, also need to modify the style of other pages.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1707: chore: improve Upstream/CodeMirror

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1707:
URL: https://github.com/apache/apisix-dashboard/pull/1707#discussion_r607439184



##########
File path: web/src/components/RawDataEditor/locales/en-US.ts
##########
@@ -16,5 +16,5 @@
  */
 export default {
   'component.rawDataEditor.tip': "Don't support edit mode currently",
-  'component.rawDataEditor.title': 'Raw Data Editor',
+  'component.rawDataEditor.title': 'CodeMirror',

Review comment:
       😂 but we don't have a uniform  name for now, `Create with Editor`/`Raw Data Editor`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1707: chore: improve Upstream/CodeMirror

Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #1707:
URL: https://github.com/apache/apisix-dashboard/pull/1707


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1707: chore: improve Upstream/CodeMirror

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1707:
URL: https://github.com/apache/apisix-dashboard/pull/1707#issuecomment-813827904


   Hi, I noticed we have comments all about CodeMirror, how about adding some descriptions for this component? I don't have a better name yet, I would still prefer keeping using CodeMirror than Create with Editor. What's your opinion? 
   
   BTW, how about other changes in this PR? Do they make sense to you?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1707: chore: improve Upstream/CodeMirror

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1707:
URL: https://github.com/apache/apisix-dashboard/pull/1707#discussion_r607508105



##########
File path: web/src/components/RawDataEditor/locales/zh-CN.ts
##########
@@ -16,5 +16,5 @@
  */
 export default {
   'component.rawDataEditor.tip': '目前暂不支持编辑',
-  'component.rawDataEditor.title': '元数据编辑器',
+  'component.rawDataEditor.title': 'CodeMirror',

Review comment:
       Yes.
   
   BTW, I want to make sure most of users know what CodeMirror is 😂
   
   Does this word make sense to you? :)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #1707: chore: improve Upstream/CodeMirror

Posted by GitBox <gi...@apache.org>.
LiteSun commented on a change in pull request #1707:
URL: https://github.com/apache/apisix-dashboard/pull/1707#discussion_r607460099



##########
File path: web/src/locales/en-US/component.ts
##########
@@ -25,12 +25,12 @@ export default {
   'component.global.document': 'Document',
   'component.global.enable': 'Enable',
   'component.global.scope': 'Scope',
-  'component.global.data.editor': 'Data Editor',
+  'component.global.data.editor': 'CodeMirror',
   'component.global.delete': 'Delete',
   'component.global.cancel': 'Cancel',
   'component.global.submit': 'Submit',
   'component.global.create': 'Create',
-  'component.global.createWithEditor': 'Create with Editor',

Review comment:
       I think `Create with Editor` is easier to understand, those who have not used `CodeMirror ` before may not know what codemirror does. 🤔




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on a change in pull request #1707: chore: improve Upstream/CodeMirror

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on a change in pull request #1707:
URL: https://github.com/apache/apisix-dashboard/pull/1707#discussion_r607491347



##########
File path: web/src/components/RawDataEditor/locales/zh-CN.ts
##########
@@ -16,5 +16,5 @@
  */
 export default {
   'component.rawDataEditor.tip': '目前暂不支持编辑',
-  'component.rawDataEditor.title': '元数据编辑器',
+  'component.rawDataEditor.title': 'CodeMirror',

Review comment:
       I guess there is no suitable word for that in cn




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1707: chore: improve Upstream/CodeMirror

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1707:
URL: https://github.com/apache/apisix-dashboard/pull/1707#discussion_r607390954



##########
File path: web/src/components/Upstream/UpstreamForm.tsx
##########
@@ -257,15 +249,16 @@ const UpstreamForm: React.FC<Props> = forwardRef(
 
     const ActiveHealthCheck = () => (
       <>
-        <Form.Item label={formatMessage({ id: 'page.upstream.step.healthyCheck.active.timeout' })}>
+        <Form.Item label={formatMessage({ id: 'page.upstream.step.healthyCheck.active.timeout' })} tooltip="主动健康检查的套接字的超时时间">
           <Form.Item name={['checks', 'active', 'timeout']} noStyle>

Review comment:
       oh yes!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1707: chore: improve Upstream/CodeMirror

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1707:
URL: https://github.com/apache/apisix-dashboard/pull/1707#discussion_r607986180



##########
File path: web/src/pages/Upstream/List.tsx
##########
@@ -136,12 +136,11 @@ const Page: React.FC = () => {
             <PlusOutlined />
             {formatMessage({ id: 'component.global.create' })}
           </Button>,
-          <Button type="primary" onClick={() => {
+          <Button type="default" onClick={() => {

Review comment:
       not sure if we really need the primary button here 🤔 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1707: chore: improve Upstream/CodeMirror

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1707:
URL: https://github.com/apache/apisix-dashboard/pull/1707#issuecomment-813700978


   @iamayushdas @KishaniKandasamy @stu01509 You could also review this PR :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] stu01509 commented on pull request #1707: chore: improve Upstream/CodeMirror

Posted by GitBox <gi...@apache.org>.
stu01509 commented on pull request #1707:
URL: https://github.com/apache/apisix-dashboard/pull/1707#issuecomment-813701451


   > @iamayushdas @KishaniKandasamy @stu01509 You could also review this PR :)
   
   Sure 😃


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] KishaniKandasamy commented on a change in pull request #1707: chore: improve Upstream/CodeMirror

Posted by GitBox <gi...@apache.org>.
KishaniKandasamy commented on a change in pull request #1707:
URL: https://github.com/apache/apisix-dashboard/pull/1707#discussion_r607490164



##########
File path: web/src/components/RawDataEditor/locales/zh-CN.ts
##########
@@ -16,5 +16,5 @@
  */
 export default {
   'component.rawDataEditor.tip': '目前暂不支持编辑',
-  'component.rawDataEditor.title': '元数据编辑器',
+  'component.rawDataEditor.title': 'CodeMirror',

Review comment:
       English in  zh-CN.ts🤔
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1707: chore: improve Upstream/CodeMirror

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1707:
URL: https://github.com/apache/apisix-dashboard/pull/1707#discussion_r607710011



##########
File path: web/src/components/Upstream/UpstreamForm.tsx
##########
@@ -771,7 +775,12 @@ const UpstreamForm: React.FC<Props> = forwardRef(
                 {
                   label: formatMessage({ id: 'page.upstream.step.healthyCheck.active' }),
                   name: ['checks', 'active'],
-                  component: <ActiveHealthCheck />,
+                  component: (
+                    <>
+                      <ActiveHealthCheck />
+                      <Divider orientation="left" plain></Divider>

Review comment:
       Oh yes, and we'd better add a space before / :)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1707: chore: improve Upstream/CodeMirror

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1707:
URL: https://github.com/apache/apisix-dashboard/pull/1707#issuecomment-813001919


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1707?src=pr&el=h1) Report
   > Merging [#1707](https://codecov.io/gh/apache/apisix-dashboard/pull/1707?src=pr&el=desc) (a0c212f) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/297a57a4081b7b55d7906f6084d319d0afc21579?el=desc) (297a57a) will **decrease** coverage by `0.54%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1707?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1707      +/-   ##
   ==========================================
   - Coverage   72.01%   71.46%   -0.55%     
   ==========================================
     Files         130       47      -83     
     Lines        5660     3126    -2534     
     Branches      661        0     -661     
   ==========================================
   - Hits         4076     2234    -1842     
   + Misses       1341      649     -692     
     Partials      243      243              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `62.22% <ø> (-0.13%)` | :arrow_down: |
   | backend-e2e-test-ginkgo | `48.49% <ø> (+0.12%)` | :arrow_up: |
   | backend-unit-test | `52.29% <ø> (ø)` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1707?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | `43.63% <0.00%> (-3.64%)` | :arrow_down: |
   | [web/src/pages/Dashboard/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9EYXNoYm9hcmQvc2VydmljZS50cw==) | | |
   | [web/src/pages/Route/components/Step2/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAyL2luZGV4LnRzeA==) | | |
   | [...eb/src/pages/PluginTemplate/components/Preview.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9QbHVnaW5UZW1wbGF0ZS9jb21wb25lbnRzL1ByZXZpZXcudHN4) | | |
   | [web/src/components/Upstream/constant.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/diff?src=pr&el=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbnN0YW50LnRz) | | |
   | [web/src/pages/Route/transform.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS90cmFuc2Zvcm0udHM=) | | |
   | [web/src/pages/PluginTemplate/components/Step1.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9QbHVnaW5UZW1wbGF0ZS9jb21wb25lbnRzL1N0ZXAxLnRzeA==) | | |
   | [.../Route/components/DebugViews/DebugFormDataView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0RlYnVnVmlld3MvRGVidWdGb3JtRGF0YVZpZXcudHN4) | | |
   | [web/src/components/Plugin/PluginPage.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/diff?src=pr&el=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5QYWdlLnRzeA==) | | |
   | [web/src/services/user.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/diff?src=pr&el=tree#diff-d2ViL3NyYy9zZXJ2aWNlcy91c2VyLnRz) | | |
   | ... and [68 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1707?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1707?src=pr&el=footer). Last update [297a57a...a0c212f](https://codecov.io/gh/apache/apisix-dashboard/pull/1707?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1707: chore: improve Upstream/CodeMirror

Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #1707:
URL: https://github.com/apache/apisix-dashboard/pull/1707#discussion_r607522732



##########
File path: web/src/components/RawDataEditor/locales/en-US.ts
##########
@@ -16,5 +16,5 @@
  */
 export default {
   'component.rawDataEditor.tip': "Don't support edit mode currently",
-  'component.rawDataEditor.title': 'Raw Data Editor',
+  'component.rawDataEditor.title': 'CodeMirror',

Review comment:
       How about looking at this issue from another angle:
   `Create with Editor` is an action that can arouse `CodeMirror`, and `Raw Data Editor` can be considered as a name we gave to `CodeMirror`. So we just need to unify the action name and the `CodeMirror` name.
   
   for the `CodeMirror` name, `Raw Data Editor `is a better choice IMHO




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] KishaniKandasamy commented on a change in pull request #1707: chore: improve Upstream/CodeMirror

Posted by GitBox <gi...@apache.org>.
KishaniKandasamy commented on a change in pull request #1707:
URL: https://github.com/apache/apisix-dashboard/pull/1707#discussion_r607540163



##########
File path: web/src/components/RawDataEditor/locales/zh-CN.ts
##########
@@ -16,5 +16,5 @@
  */
 export default {
   'component.rawDataEditor.tip': '目前暂不支持编辑',
-  'component.rawDataEditor.title': '元数据编辑器',
+  'component.rawDataEditor.title': 'CodeMirror',

Review comment:
       > Yes.
   > 
   > BTW, I want to make sure most of users know what CodeMirror is 😂
   > 
   > Does this word make sense to you? :)
   
   yes :)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1707: chore: improve Upstream/CodeMirror

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1707:
URL: https://github.com/apache/apisix-dashboard/pull/1707#issuecomment-813001919


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1707?src=pr&el=h1) Report
   > Merging [#1707](https://codecov.io/gh/apache/apisix-dashboard/pull/1707?src=pr&el=desc) (a0c212f) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/297a57a4081b7b55d7906f6084d319d0afc21579?el=desc) (297a57a) will **decrease** coverage by `19.72%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1707?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #1707       +/-   ##
   ===========================================
   - Coverage   72.01%   52.29%   -19.73%     
   ===========================================
     Files         130       38       -92     
     Lines        5660     2660     -3000     
     Branches      661        0      -661     
   ===========================================
   - Hits         4076     1391     -2685     
   + Misses       1341     1081      -260     
   + Partials      243      188       -55     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `?` | |
   | backend-unit-test | `52.29% <ø> (ø)` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1707?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: |
   | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: |
   | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
   | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: |
   | [api/internal/handler/handler.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGFuZGxlci5nbw==) | `42.59% <0.00%> (-35.19%)` | :arrow_down: |
   | [api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==) | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
   | ... and [110 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1707/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1707?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1707?src=pr&el=footer). Last update [297a57a...a0c212f](https://codecov.io/gh/apache/apisix-dashboard/pull/1707?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1707: chore: improve Upstream/CodeMirror

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1707:
URL: https://github.com/apache/apisix-dashboard/pull/1707#discussion_r607509227



##########
File path: web/src/locales/en-US/component.ts
##########
@@ -25,12 +25,12 @@ export default {
   'component.global.document': 'Document',
   'component.global.enable': 'Enable',
   'component.global.scope': 'Scope',
-  'component.global.data.editor': 'Data Editor',
+  'component.global.data.editor': 'CodeMirror',
   'component.global.delete': 'Delete',
   'component.global.cancel': 'Cancel',
   'component.global.submit': 'Submit',
   'component.global.create': 'Create',
-  'component.global.createWithEditor': 'Create with Editor',

Review comment:
       Not sure, Create with Editor is more like a description than a feature name IMO :)
   
   How about other changes?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on a change in pull request #1707: chore: improve Upstream/CodeMirror

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on a change in pull request #1707:
URL: https://github.com/apache/apisix-dashboard/pull/1707#discussion_r607514573



##########
File path: web/src/components/RawDataEditor/locales/zh-CN.ts
##########
@@ -16,5 +16,5 @@
  */
 export default {
   'component.rawDataEditor.tip': '目前暂不支持编辑',
-  'component.rawDataEditor.title': '元数据编辑器',
+  'component.rawDataEditor.title': 'CodeMirror',

Review comment:
       That would be good for everyone then, who are having problem with this word right now.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] KishaniKandasamy commented on pull request #1707: chore: improve Upstream/CodeMirror

Posted by GitBox <gi...@apache.org>.
KishaniKandasamy commented on pull request #1707:
URL: https://github.com/apache/apisix-dashboard/pull/1707#issuecomment-813801596


   > @iamayushdas @KishaniKandasamy @stu01509 You could also review this PR :)
   
   
   
   
   👍🏻


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1707: chore: improve Upstream/CodeMirror

Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #1707:
URL: https://github.com/apache/apisix-dashboard/pull/1707#discussion_r607402214



##########
File path: web/src/components/RawDataEditor/locales/en-US.ts
##########
@@ -16,5 +16,5 @@
  */
 export default {
   'component.rawDataEditor.tip': "Don't support edit mode currently",
-  'component.rawDataEditor.title': 'Raw Data Editor',
+  'component.rawDataEditor.title': 'CodeMirror',

Review comment:
       May I ask why did not use `Raw Data Editor` here?  It seems that this is  easier to understand




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1707: chore: improve Upstream/CodeMirror

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1707:
URL: https://github.com/apache/apisix-dashboard/pull/1707#issuecomment-814215138


   Hi all, except those comments, any comments about those changes?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org