You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/03/17 22:42:22 UTC

[GitHub] [druid] techdocsmith commented on a change in pull request #12344: Corrected heading levels in segments doc

techdocsmith commented on a change in pull request #12344:
URL: https://github.com/apache/druid/pull/12344#discussion_r829567838



##########
File path: docs/design/segments.md
##########
@@ -209,7 +207,7 @@ For example, if your real-time ingestion creates 3 segments that were sharded wi
 
 ## Schema changes
 
-## Replacing segments
+### Replacing segments

Review comment:
       @vtlim , @jill-imply This is a little hairier than a simple heading adjustment I'm afraid.
   
   "Schema Changes" doesn't really convey the content here. There seem to be two scenarios:
   - different segment versions that have different schemas
   - differing schemas within a single segment version
   
   Couple other thoughts:
   - Normally we shouldn't have two headings back to back.
   - think we should improve the "Replacing segments" heading because there is a lot of explaining of the segment naming convention before we get to the fact that the new version has a different schema than the old version




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org