[GitHub] dclim commented on a change in pull request #6563: add missing license headers, in particular to MD files; clean up RAT …

[GitBox <gi...@apache.org>]

dclim commented on a change in pull request #6563: add missing license headers, in particular to MD files; clean up RAT …
URL: https://github.com/apache/incubator-druid/pull/6563#discussion_r229942385
 
 

 ##########
 File path: core/src/main/antlr4/org/apache/druid/math/expr/antlr/Expr.g4
 ##########
 @@ -1,5 +1,20 @@
 grammar Expr;
 
+// Licensed to the Apache Software Foundation (ASF) under one or more
 
 Review comment:
   @jihoonson for bash/python scripts, the shebang (`#!`) has to be the first two bytes of an executable file, or else the kernel won't know to invoke the correct interpreter; so the `#!/bin/bash` or other has to be on line 1 with the license header following

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org