You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/08/04 01:24:42 UTC
[PR] [ISSUE #913] Reject missing alert rule updates [rocketmq-dashboard]
Aias00 opened a new pull request, #914:
URL: https://github.com/apache/rocketmq-dashboard/pull/914
### Summary
- fail mock alert rule updates when the target ID does not exist
- avoid returning a fake successful update for stale alert rule IDs
- add a regression test that verifies the alert rule list remains unchanged
### Tests
- `npm test -- --run src/services/opsService.test.ts`
- `npm run lint -- src/services/opsService.ts src/services/opsService.test.ts` (passes with existing fast-refresh warnings in unrelated files)
- `git diff --check`
Closes #913
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #913] Reject missing alert rule updates [rocketmq-dashboard]
Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 closed pull request #914: [ISSUE #913] Reject missing alert rule updates
URL: https://github.com/apache/rocketmq-dashboard/pull/914
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #913] Reject missing alert rule updates [rocketmq-dashboard]
Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 commented on PR #914:
URL: https://github.com/apache/rocketmq-dashboard/pull/914#issuecomment-5173962906
Superseded by consolidated PR #924, which contains this change and has passing checks. Closing this narrower PR to keep review focused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org