You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by hb...@apache.org on 2018/12/09 16:44:17 UTC
[maven] 01/02: [MNG-6529] JUnit Test showcasing the bug
This is an automated email from the ASF dual-hosted git repository.
hboutemy pushed a commit to branch MNG-6529
in repository https://gitbox.apache.org/repos/asf/maven.git
commit 3f6cdc590ae38d5849780aea02202494b1f39e70
Author: Mickael Istria <mi...@redhat.com>
AuthorDate: Tue Nov 27 15:54:14 2018 +0100
[MNG-6529] JUnit Test showcasing the bug
This adds a (failing) unit test showcasing that
ProjectBuilder.build(List<File> projects, boolean,
ProjectBuildingRequest)
doesn't honor ProjectBuildingRequest.isResolveDependencies()
---
.../apache/maven/project/ProjectBuilderTest.java | 28 +++++++++++++++++++++-
.../projects/basic-resolveDependencies.xml | 15 ++++++++++++
2 files changed, 42 insertions(+), 1 deletion(-)
diff --git a/maven-core/src/test/java/org/apache/maven/project/ProjectBuilderTest.java b/maven-core/src/test/java/org/apache/maven/project/ProjectBuilderTest.java
index 5511cb1..37613bf 100644
--- a/maven-core/src/test/java/org/apache/maven/project/ProjectBuilderTest.java
+++ b/maven-core/src/test/java/org/apache/maven/project/ProjectBuilderTest.java
@@ -20,6 +20,8 @@ package org.apache.maven.project;
*/
import java.io.File;
+import java.util.Collections;
+import java.util.List;
import java.util.Properties;
import org.apache.maven.AbstractCoreMavenComponentTestCase;
@@ -30,7 +32,8 @@ import org.apache.maven.model.building.ModelSource;
public class ProjectBuilderTest
extends AbstractCoreMavenComponentTestCase
{
- protected String getProjectsDirectory()
+ @Override
+ protected String getProjectsDirectory()
{
return "src/test/projects/project-builder";
}
@@ -84,4 +87,27 @@ public class ProjectBuilderTest
// this is expected
}
}
+
+ public void testResolveDependencies()
+ throws Exception
+ {
+ File pomFile = new File( "src/test/resources/projects/basic-resolveDependencies.xml" );
+ MavenSession mavenSession = createMavenSession( null );
+ ProjectBuildingRequest configuration = new DefaultProjectBuildingRequest();
+ configuration.setRepositorySession( mavenSession.getRepositorySession() );
+ configuration.setResolveDependencies( true );
+
+ // single project build entry point
+ ProjectBuildingResult result =
+ lookup( org.apache.maven.project.ProjectBuilder.class ).build( pomFile, configuration );
+ assertEquals( 1, result.getProject().getArtifacts().size() );
+ // multi projects build entry point
+ List<ProjectBuildingResult> results =
+ lookup( org.apache.maven.project.ProjectBuilder.class ).build( Collections.singletonList( pomFile ), false,
+ configuration );
+ assertEquals( 1, results.size() );
+ MavenProject mavenProject = results.get( 0 ).getProject();
+ assertEquals( 1, mavenProject.getArtifacts().size() );
+ }
+
}
diff --git a/maven-core/src/test/resources/projects/basic-resolveDependencies.xml b/maven-core/src/test/resources/projects/basic-resolveDependencies.xml
new file mode 100644
index 0000000..d25326b
--- /dev/null
+++ b/maven-core/src/test/resources/projects/basic-resolveDependencies.xml
@@ -0,0 +1,15 @@
+<project>
+ <modelVersion>4.0.0</modelVersion>
+
+ <groupId>test</groupId>
+ <artifactId>basic-resolveDependencies.xml</artifactId>
+ <version>0.0.1-SNAPSHOT</version>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.maven.its</groupId>
+ <artifactId>a</artifactId>
+ <version>0.1</version>
+ </dependency>
+ </dependencies>
+</project>
\ No newline at end of file