You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/25 20:14:20 UTC

[GitHub] [arrow] drin commented on pull request #13487: ARROW-8991: [C++] Add fast_hash_64 scalar compute function

drin commented on PR #13487:
URL: https://github.com/apache/arrow/pull/13487#issuecomment-1227714401

   Forgot that `scalar_hash_test.cc` existed, so had to remove references to `fast_hash_32`. I also decided to add a few more test cases and realized that `list` types weren't being hashed. This was fixed by changing how I try to extract KeyColumnArrays (https://github.com/apache/arrow/pull/13487/commits/0f0b304955c3a91830ab47d9354a31562a9838b5), now I take this approach:
   * Try to grab buffers from ArrayData
     * If successful, grab buffers
     * If not successful, skip buffers (data type is nested so there's no data buffer anyways)
   * recurse on children


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org